Hello community,
here is the log from the commit of package kxmlrpcclient5 for openSUSE:Factory checked in at 2015-09-24 07:14:33
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/kxmlrpcclient5 (Old)
and /work/SRC/openSUSE:Factory/.kxmlrpcclient5.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "kxmlrpcclient5"
Changes:
--------
--- /work/SRC/openSUSE:Factory/kxmlrpcclient5/kxmlrpcclient5.changes 2015-09-02 07:48:58.000000000 +0200
+++ /work/SRC/openSUSE:Factory/.kxmlrpcclient5.new/kxmlrpcclient5.changes 2015-09-24 07:14:35.000000000 +0200
@@ -1,0 +2,8 @@
+Tue Sep 8 17:13:38 UTC 2015 - hrvoje.senjan@gmail.com
+
+- Update to 5.14.0
+ * Avoid QLatin1String wherever it allocates heap memory
+ * For more details please see:
+ https://www.kde.org/announcements/kde-frameworks-5.14.0.php
+
+-------------------------------------------------------------------
Old:
----
kxmlrpcclient-5.13.0.tar.xz
New:
----
kxmlrpcclient-5.14.0.tar.xz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ kxmlrpcclient5.spec ++++++
--- /var/tmp/diff_new_pack.KGTpbe/_old 2015-09-24 07:14:35.000000000 +0200
+++ /var/tmp/diff_new_pack.KGTpbe/_new 2015-09-24 07:14:35.000000000 +0200
@@ -19,9 +19,9 @@
%bcond_without lang
%define rname kxmlrpcclient
%define lname libKF5XmlRpcClient5
-%define _tar_path 5.13
+%define _tar_path 5.14
Name: kxmlrpcclient5
-Version: 5.13.0
+Version: 5.14.0
Release: 0
%define kf5_version %{version}
Summary: Library containing simple XML-RPC Client support
++++++ kxmlrpcclient-5.13.0.tar.xz -> kxmlrpcclient-5.14.0.tar.xz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kxmlrpcclient-5.13.0/.arcconfig new/kxmlrpcclient-5.14.0/.arcconfig
--- old/kxmlrpcclient-5.13.0/.arcconfig 1970-01-01 01:00:00.000000000 +0100
+++ new/kxmlrpcclient-5.14.0/.arcconfig 2015-09-05 11:18:25.000000000 +0200
@@ -0,0 +1,4 @@
+{
+ "phabricator.uri" : "https://phabricator.kde.org/project/profile/34/",
+ "history.immutable" : true
+}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kxmlrpcclient-5.13.0/CMakeLists.txt new/kxmlrpcclient-5.14.0/CMakeLists.txt
--- old/kxmlrpcclient-5.13.0/CMakeLists.txt 2015-08-04 13:45:24.000000000 +0200
+++ new/kxmlrpcclient-5.14.0/CMakeLists.txt 2015-09-05 11:18:25.000000000 +0200
@@ -4,7 +4,7 @@
# ECM setup
include(FeatureSummary)
-find_package(ECM 5.13.0 CONFIG )
+find_package(ECM 5.14.0 CONFIG )
set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules")
feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND FATAL_ON_MISSING_REQUIRED_PACKAGES)
@@ -19,9 +19,10 @@
include(KDEInstallDirs)
include(KDECMakeSettings)
include(KDEFrameworkCompilerSettings)
+include(ECMQtDeclareLoggingCategory)
-set(KF5_VERSION "5.13.0") # handled by release scripts
-set(KF5_DEP_VERSION "5.13.0") # handled by release scripts
+set(KF5_VERSION "5.14.0") # handled by release scripts
+set(KF5_DEP_VERSION "5.14.0") # handled by release scripts
add_definitions(-DTRANSLATION_DOMAIN=\"libkxmlrpcclient5\")
ecm_setup_version(${KF5_VERSION} VARIABLE_PREFIX KXMLRPCCLIENT
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kxmlrpcclient-5.13.0/autotests/CMakeLists.txt new/kxmlrpcclient-5.14.0/autotests/CMakeLists.txt
--- old/kxmlrpcclient-5.13.0/autotests/CMakeLists.txt 2015-08-04 13:45:24.000000000 +0200
+++ new/kxmlrpcclient-5.14.0/autotests/CMakeLists.txt 2015-09-05 11:18:25.000000000 +0200
@@ -8,7 +8,7 @@
ecm_add_test(${_name}.cpp
${CMAKE_SOURCE_DIR}/src/client.cpp
${CMAKE_SOURCE_DIR}/src/query.cpp
- ${CMAKE_SOURCE_DIR}/src/kxmlrpcclient_debug.cpp
+ ${CMAKE_BINARY_DIR}/src/kxmlrpcclient_debug.cpp
LINK_LIBRARIES KF5::KIOCore KF5::I18n Qt5::Xml Qt5::Test
TEST_NAME ${_name}
NAME_PREFIX kxmlrpc)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kxmlrpcclient-5.13.0/autotests/querytest.cpp new/kxmlrpcclient-5.14.0/autotests/querytest.cpp
--- old/kxmlrpcclient-5.13.0/autotests/querytest.cpp 2015-08-04 13:45:24.000000000 +0200
+++ new/kxmlrpcclient-5.14.0/autotests/querytest.cpp 2015-09-05 11:18:25.000000000 +0200
@@ -66,7 +66,7 @@
"</param>\r\n"
XML_CALL_END;
QTest::newRow("string (utf8)") << QString::fromLatin1("MyMethod")
- << (QVariantList() << QString::fromUtf8("Žlutý kůň pěl ďábelské ódy"))
+ << (QVariantList() << QStringLiteral("Žlutý kůň pěl ďábelské ódy"))
<< XML_CALL_HEAD("MyMethod")
"<param>\r\n"
"<value><string><![CDATA[Žlutý kůň pěl ďábelské ódy]]></string></value>\r\n"
@@ -145,7 +145,7 @@
QFETCH(QList<QVariant>, arguments);
QFETCH(QByteArray, xml);
- const QByteArray markup = Query::Private::markupCall(methodName, arguments);
+ const QByteArray markup = QueryPrivate::markupCall(methodName, arguments);
QCOMPARE(markup, xml);
}
@@ -243,17 +243,17 @@
QDomDocument doc;
QVERIFY(doc.setContent(xml));
- QCOMPARE(Query::Private::isMessageResponse(doc), isSuccess);
- QCOMPARE(Query::Private::isFaultResponse(doc), !isSuccess);
+ QCOMPARE(QueryPrivate::isMessageResponse(doc), isSuccess);
+ QCOMPARE(QueryPrivate::isFaultResponse(doc), !isSuccess);
if (isSuccess) {
- const KXmlRpc::Result result = Query::Private::parseMessageResponse(doc);
+ const KXmlRpc::Result result = QueryPrivate::parseMessageResponse(doc);
QVERIFY(result.success());
QCOMPARE(result.errorCode(), -1);
QVERIFY(result.errorString().isEmpty());
QCOMPARE(result.data(), arguments);
} else {
- const KXmlRpc::Result result = Query::Private::parseFaultResponse(doc);
+ const KXmlRpc::Result result = QueryPrivate::parseFaultResponse(doc);
QVERIFY(!result.success());
QCOMPARE(result.errorCode(), arguments[0].toMap()[QLatin1String("faultCode")].toInt());
QCOMPARE(result.errorString(), arguments[0].toMap()[QLatin1String("faultString")].toString());
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kxmlrpcclient-5.13.0/src/CMakeLists.txt new/kxmlrpcclient-5.14.0/src/CMakeLists.txt
--- old/kxmlrpcclient-5.13.0/src/CMakeLists.txt 2015-08-04 13:45:24.000000000 +0200
+++ new/kxmlrpcclient-5.14.0/src/CMakeLists.txt 2015-09-05 11:18:25.000000000 +0200
@@ -1,9 +1,10 @@
set(kxmlrpcclient_SRCS
client.cpp
query.cpp
- kxmlrpcclient_debug.cpp
)
+ecm_qt_declare_logging_category(kxmlrpcclient_SRCS HEADER kxmlrpcclient_debug.h IDENTIFIER KXMLRPCCLIENT_LOG CATEGORY_NAME log_kxmlrpcclient)
+
add_library(KF5XmlRpcClient ${kxmlrpcclient_SRCS})
generate_export_header(KF5XmlRpcClient BASE_NAME kxmlrpcclient)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kxmlrpcclient-5.13.0/src/client.cpp new/kxmlrpcclient-5.14.0/src/client.cpp
--- old/kxmlrpcclient-5.13.0/src/client.cpp 2015-08-04 13:45:24.000000000 +0200
+++ new/kxmlrpcclient-5.14.0/src/client.cpp 2015-09-05 11:18:25.000000000 +0200
@@ -30,10 +30,10 @@
using namespace KXmlRpc;
-class Client::Private
+class ClientPrivate
{
public:
- Private() : mUserAgent(QLatin1String("KDE XMLRPC resources")), mDigestAuth(false) {}
+ ClientPrivate() : mUserAgent(QStringLiteral("KDE XMLRPC resources")), mDigestAuth(false) {}
void queryFinished(Query *);
@@ -43,7 +43,7 @@
QList mPendingQueries;
};
-void Client::Private::queryFinished(Query *query)
+void ClientPrivate::queryFinished(Query *query)
{
mPendingQueries.removeAll(query);
query->deleteLater();
@@ -51,13 +51,13 @@
Client::Client(QObject *parent)
: QObject(parent)
- , d(new Private)
+ , d(new ClientPrivate)
{
}
Client::Client(const QUrl &url, QObject *parent)
: QObject(parent)
- , d(new Private)
+ , d(new ClientPrivate)
{
d->mUrl = url;
}
@@ -116,13 +116,13 @@
//Fill metadata, with userAgent and possible digest auth
if (d->mUserAgent.isEmpty()) {
- metaData[QLatin1String("UserAgent")] = QLatin1String("KDE-XMLRPC");
+ metaData[QStringLiteral("UserAgent")] = QStringLiteral("KDE-XMLRPC");
} else {
- metaData[QLatin1String("UserAgent")] = d->mUserAgent;
+ metaData[QStringLiteral("UserAgent")] = d->mUserAgent;
}
if (d->mDigestAuth) {
- metaData[QLatin1String("WWW-Authenticate:")] = QLatin1String("Digest");
+ metaData[QStringLiteral("WWW-Authenticate:")] = QStringLiteral("Digest");
}
Query *query = Query::create(id, this);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kxmlrpcclient-5.13.0/src/client.h new/kxmlrpcclient-5.14.0/src/client.h
--- old/kxmlrpcclient-5.13.0/src/client.h 2015-08-04 13:45:24.000000000 +0200
+++ new/kxmlrpcclient-5.14.0/src/client.h 2015-09-05 11:18:25.000000000 +0200
@@ -30,6 +30,7 @@
#include
#include
#include
+class ClientPrivate;
/** Names for XmlRpc related classes */
namespace KXmlRpc
@@ -278,8 +279,7 @@
const QVariant &id = QVariant());
private:
- class Private;
- Private *const d;
+ ClientPrivate *const d;
template <typename T>
void call(const QString &method, const QList<T> &arg,
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kxmlrpcclient-5.13.0/src/kxmlrpcclient_debug.cpp new/kxmlrpcclient-5.14.0/src/kxmlrpcclient_debug.cpp
--- old/kxmlrpcclient-5.13.0/src/kxmlrpcclient_debug.cpp 2015-08-04 13:45:24.000000000 +0200
+++ new/kxmlrpcclient-5.14.0/src/kxmlrpcclient_debug.cpp 1970-01-01 01:00:00.000000000 +0100
@@ -1,27 +0,0 @@
-/* This file is part of the KDE project
- Copyright (C) 2014 Laurent Montel
-
- This library is free software; you can redistribute it and/or
- modify it under the terms of the GNU Library General Public
- License as published by the Free Software Foundation; either
- version 2 of the License, or (at your option) any later version.
-
- This library is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- Library General Public License for more details.
-
- You should have received a copy of the GNU Library General Public License
- along with this library; see the file COPYING.LIB. If not, write to
- the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
- Boston, MA 02110-1301, USA.
-*/
-
-#include "kxmlrpcclient_debug.h"
-
-#if QT_VERSION >= QT_VERSION_CHECK(5, 4, 0)
-// logging category for this framework, default: log stuff >= warning
-Q_LOGGING_CATEGORY(KXMLRPCCLIENT_LOG, "log_kxmlrpcclient", QtWarningMsg)
-#else
-Q_LOGGING_CATEGORY(KXMLRPCCLIENT_LOG, "log_kxmlrpcclient")
-#endif
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kxmlrpcclient-5.13.0/src/kxmlrpcclient_debug.h new/kxmlrpcclient-5.14.0/src/kxmlrpcclient_debug.h
--- old/kxmlrpcclient-5.13.0/src/kxmlrpcclient_debug.h 2015-08-04 13:45:24.000000000 +0200
+++ new/kxmlrpcclient-5.14.0/src/kxmlrpcclient_debug.h 1970-01-01 01:00:00.000000000 +0100
@@ -1,27 +0,0 @@
-/* This file is part of the KDE project
- Copyright (C) 2014 Laurent Montel
-
- This library is free software; you can redistribute it and/or
- modify it under the terms of the GNU Library General Public
- License as published by the Free Software Foundation; either
- version 2 of the License, or (at your option) any later version.
-
- This library is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- Library General Public License for more details.
-
- You should have received a copy of the GNU Library General Public License
- along with this library; see the file COPYING.LIB. If not, write to
- the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
- Boston, MA 02110-1301, USA.
-*/
-
-#ifndef KXMLRPCCLIENT_DEBUG_H
-#define KXMLRPCCLIENT_DEBUG_H
-
-#include <QLoggingCategory>
-Q_DECLARE_LOGGING_CATEGORY(KXMLRPCCLIENT_LOG)
-
-#endif
-
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kxmlrpcclient-5.13.0/src/query.cpp new/kxmlrpcclient-5.14.0/src/query.cpp
--- old/kxmlrpcclient-5.13.0/src/query.cpp 2015-08-04 13:45:24.000000000 +0200
+++ new/kxmlrpcclient-5.14.0/src/query.cpp 2015-09-05 11:18:25.000000000 +0200
@@ -63,19 +63,19 @@
return mData;
}
-bool Query::Private::isMessageResponse(const QDomDocument &doc)
+bool QueryPrivate::isMessageResponse(const QDomDocument &doc)
{
return doc.documentElement().firstChild().toElement().tagName().toLower()
== QLatin1String("params");
}
-bool Query::Private::isFaultResponse(const QDomDocument &doc)
+bool QueryPrivate::isFaultResponse(const QDomDocument &doc)
{
return doc.documentElement().firstChild().toElement().tagName().toLower()
== QLatin1String("fault");
}
-Result Query::Private::parseMessageResponse(const QDomDocument &doc)
+Result QueryPrivate::parseMessageResponse(const QDomDocument &doc)
{
Result response;
response.mSuccess = true;
@@ -89,20 +89,20 @@
return response;
}
-Result Query::Private::parseFaultResponse(const QDomDocument &doc)
+Result QueryPrivate::parseFaultResponse(const QDomDocument &doc)
{
Result response;
response.mSuccess = false;
QDomNode errorNode = doc.documentElement().firstChild().firstChild();
const QVariant errorVariant = demarshal(errorNode.toElement());
- response.mErrorCode = errorVariant.toMap()[QLatin1String("faultCode")].toInt();
- response.mErrorString = errorVariant.toMap()[QLatin1String("faultString")].toString();
+ response.mErrorCode = errorVariant.toMap()[QStringLiteral("faultCode")].toInt();
+ response.mErrorString = errorVariant.toMap()[QStringLiteral("faultString")].toString();
return response;
}
-QByteArray Query::Private::markupCall(const QString &cmd,
+QByteArray QueryPrivate::markupCall(const QString &cmd,
const QList<QVariant> &args)
{
QByteArray markup = "<?xml version=\"1.0\" ?>\r\n<methodCall>\r\n";
@@ -123,7 +123,7 @@
return markup;
}
-QByteArray Query::Private::marshal(const QVariant &arg)
+QByteArray QueryPrivate::marshal(const QVariant &arg)
{
switch (arg.type()) {
@@ -180,7 +180,7 @@
return QByteArray();
}
-QVariant Query::Private::demarshal(const QDomElement &element)
+QVariant QueryPrivate::demarshal(const QDomElement &element)
{
Q_ASSERT(element.tagName().toLower() == QLatin1String("value"));
@@ -209,9 +209,9 @@
if (17 <= dateText.length() && dateText.length() <= 18 &&
dateText.at(4) != QLatin1Char('-') && dateText.at(11) == QLatin1Char(':')) {
if (dateText.endsWith(QLatin1Char('Z'))) {
- date = QDateTime::fromString(dateText, QLatin1String("yyyyMMddTHH:mm:ssZ"));
+ date = QDateTime::fromString(dateText, QStringLiteral("yyyyMMddTHH:mm:ssZ"));
} else {
- date = QDateTime::fromString(dateText, QLatin1String("yyyyMMddTHH:mm:ss"));
+ date = QDateTime::fromString(dateText, QStringLiteral("yyyyMMddTHH:mm:ss"));
}
} else {
date = QDateTime::fromString(dateText, Qt::ISODate);
@@ -231,9 +231,9 @@
QDomNode memberNode = typeElement.firstChild();
while (!memberNode.isNull()) {
const QString key = memberNode.toElement().elementsByTagName(
- QLatin1String("name")).item(0).toElement().text();
+ QStringLiteral("name")).item(0).toElement().text();
const QVariant data = demarshal(memberNode.toElement().elementsByTagName(
- QLatin1String("value")).item(0).toElement());
+ QStringLiteral("value")).item(0).toElement());
map[key] = data;
memberNode = memberNode.nextSibling();
}
@@ -244,14 +244,14 @@
return QVariant();
}
-void Query::Private::slotData(KIO::Job *, const QByteArray &data)
+void QueryPrivate::slotData(KIO::Job *, const QByteArray &data)
{
unsigned int oldSize = mBuffer.size();
mBuffer.resize(oldSize + data.size());
memcpy(mBuffer.data() + oldSize, data.data(), data.size());
}
-void Query::Private::slotResult(KJob *job)
+void QueryPrivate::slotResult(KJob *job)
{
mPendingJobs.removeAll(job);
@@ -305,8 +305,8 @@
return;
}
- job->addMetaData(QLatin1String("content-type"), QLatin1String("Content-Type: text/xml; charset=utf-8"));
- job->addMetaData(QLatin1String("ConnectTimeout"), QLatin1String("50"));
+ job->addMetaData(QStringLiteral("content-type"), QStringLiteral("Content-Type: text/xml; charset=utf-8"));
+ job->addMetaData(QStringLiteral("ConnectTimeout"), QStringLiteral("50"));
for (auto it = jobMetaData.begin(), end = jobMetaData.end(); it != end; ++it) {
job->addMetaData(it.key(), it.value());
@@ -321,7 +321,7 @@
}
Query::Query(const QVariant &id, QObject *parent)
- : QObject(parent), d(new Private(this))
+ : QObject(parent), d(new QueryPrivate(this))
{
d->mId = id;
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kxmlrpcclient-5.13.0/src/query.h new/kxmlrpcclient-5.14.0/src/query.h
--- old/kxmlrpcclient-5.13.0/src/query.h 2015-08-04 13:45:24.000000000 +0200
+++ new/kxmlrpcclient-5.14.0/src/query.h 2015-09-05 11:18:25.000000000 +0200
@@ -39,7 +39,7 @@
/** Namespace for XmlRpc related classes */
namespace KXmlRpc
{
-
+class QueryPrivate;
/**
@brief
Query is a class that represents an individual XML-RPC call.
@@ -53,7 +53,6 @@
Q_OBJECT
public:
- class Private;
/**
Constructs a query.
@@ -97,7 +96,7 @@
explicit Query(const QVariant &id, QObject *parent = Q_NULLPTR);
~Query();
- Private *const d;
+ QueryPrivate *const d;
Q_PRIVATE_SLOT(d, void slotData(KIO::Job *, const QByteArray &))
Q_PRIVATE_SLOT(d, void slotResult(KJob *))
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kxmlrpcclient-5.13.0/src/query_p.h new/kxmlrpcclient-5.14.0/src/query_p.h
--- old/kxmlrpcclient-5.13.0/src/query_p.h 2015-08-04 13:45:24.000000000 +0200
+++ new/kxmlrpcclient-5.14.0/src/query_p.h 2015-09-05 11:18:25.000000000 +0200
@@ -32,7 +32,7 @@
class Result
{
friend class Query;
- friend class Query::Private;
+ friend class QueryPrivate;
public:
/**
@@ -79,10 +79,10 @@
QList<QVariant> mData;
};
-class Query::Private
+class QueryPrivate
{
public:
- Private(Query *parent)
+ QueryPrivate(Query *parent)
: mParent(parent)
{
}