Hello community, here is the log from the commit of package knewstuff for openSUSE:Factory checked in at 2015-09-24 07:12:59 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/knewstuff (Old) and /work/SRC/openSUSE:Factory/.knewstuff.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "knewstuff" Changes: -------- --- /work/SRC/openSUSE:Factory/knewstuff/knewstuff.changes 2015-09-02 07:47:18.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.knewstuff.new/knewstuff.changes 2015-09-24 07:13:00.000000000 +0200 @@ -1,0 +2,7 @@ +Tue Sep 8 17:13:21 UTC 2015 - hrvoje.senjan@gmail.com + +- Update to 5.14.0 + * For more details please see: + https://www.kde.org/announcements/kde-frameworks-5.14.0.php + +------------------------------------------------------------------- Old: ---- knewstuff-5.13.0.tar.xz New: ---- knewstuff-5.14.0.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ knewstuff.spec ++++++ --- /var/tmp/diff_new_pack.5u6tWO/_old 2015-09-24 07:13:01.000000000 +0200 +++ /var/tmp/diff_new_pack.5u6tWO/_new 2015-09-24 07:13:01.000000000 +0200 @@ -18,9 +18,9 @@ %bcond_without lang %define lname libKF5NewStuff5 -%define _tar_path 5.13 +%define _tar_path 5.14 Name: knewstuff -Version: 5.13.0 +Version: 5.14.0 Release: 0 %define kf5_version %{version} BuildRequires: attica-qt5-devel >= %{_tar_path} ++++++ knewstuff-5.13.0.tar.xz -> knewstuff-5.14.0.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/knewstuff-5.13.0/CMakeLists.txt new/knewstuff-5.14.0/CMakeLists.txt --- old/knewstuff-5.13.0/CMakeLists.txt 2015-08-04 13:07:48.000000000 +0200 +++ new/knewstuff-5.14.0/CMakeLists.txt 2015-09-05 11:08:44.000000000 +0200 @@ -3,7 +3,7 @@ project(KNewStuff) include(FeatureSummary) -find_package(ECM 5.13.0 NO_MODULE) +find_package(ECM 5.14.0 NO_MODULE) set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules") feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND FATAL_ON_MISSING_REQUIRED_PACKAGES) set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH} ${ECM_KDE_MODULE_DIR}) @@ -16,8 +16,8 @@ find_package(Qt5 ${REQUIRED_QT_VERSION} NO_MODULE REQUIRED COMPONENTS Widgets Xml) # Not part of kdelibs -set(KF5_VERSION "5.13.0") # handled by release scripts -set(KF5_DEP_VERSION "5.13.0") # handled by release scripts +set(KF5_VERSION "5.14.0") # handled by release scripts +set(KF5_DEP_VERSION "5.14.0") # handled by release scripts find_package(KF5Archive ${KF5_DEP_VERSION} REQUIRED) find_package(KF5Completion ${KF5_DEP_VERSION} REQUIRED) find_package(KF5Config ${KF5_DEP_VERSION} REQUIRED) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/knewstuff-5.13.0/data/kmoretools-desktopfiles/htop.desktop new/knewstuff-5.14.0/data/kmoretools-desktopfiles/htop.desktop --- old/knewstuff-5.13.0/data/kmoretools-desktopfiles/htop.desktop 2015-08-04 13:07:48.000000000 +0200 +++ new/knewstuff-5.14.0/data/kmoretools-desktopfiles/htop.desktop 2015-09-05 11:08:44.000000000 +0200 @@ -1,4 +1,3 @@ -#!/usr/bin/env xdg-open [Desktop Entry] X-SuSE-translate=true Version=1.0 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/knewstuff-5.13.0/data/kmoretools-desktopfiles/org.gnome.clocks.desktop new/knewstuff-5.14.0/data/kmoretools-desktopfiles/org.gnome.clocks.desktop --- old/knewstuff-5.13.0/data/kmoretools-desktopfiles/org.gnome.clocks.desktop 2015-08-04 13:07:48.000000000 +0200 +++ new/knewstuff-5.14.0/data/kmoretools-desktopfiles/org.gnome.clocks.desktop 2015-09-05 11:08:44.000000000 +0200 @@ -1,4 +1,3 @@ -### todo fix upstream: remove shebang #!/usr/bin/env xdg-open [Desktop Entry] X-SuSE-translate=true Name=Clocks diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/knewstuff-5.13.0/src/button.cpp new/knewstuff-5.14.0/src/button.cpp --- old/knewstuff-5.13.0/src/button.cpp 2015-08-04 13:07:48.000000000 +0200 +++ new/knewstuff-5.14.0/src/button.cpp 2015-09-05 11:08:44.000000000 +0200 @@ -25,7 +25,7 @@ namespace KNS3 { -class Button::Private +class ButtonPrivate { public: QString configFile; @@ -35,7 +35,7 @@ const QString &configFile, QWidget *parent) : QPushButton(parent), - d(new Private) + d(new ButtonPrivate) { setButtonText(text); d->configFile = configFile; @@ -44,7 +44,7 @@ Button::Button(QWidget *parent) : QPushButton(parent), - d(new Private) + d(new ButtonPrivate) { setButtonText(i18n("Download New Stuff...")); init(); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/knewstuff-5.13.0/src/button.h new/knewstuff-5.14.0/src/button.h --- old/knewstuff-5.13.0/src/button.h 2015-08-04 13:07:48.000000000 +0200 +++ new/knewstuff-5.14.0/src/button.h 2015-09-05 11:08:44.000000000 +0200 @@ -26,7 +26,7 @@ namespace KNS3 { - +class ButtonPrivate; /** * KHotNewStuff push button that makes using KHNS in an application * more convenient by encapsulating most of the details involved in @@ -91,8 +91,7 @@ private: void init(); - class Private; - Private *const d; + ButtonPrivate *const d; }; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/knewstuff-5.13.0/src/downloadmanager.cpp new/knewstuff-5.14.0/src/downloadmanager.cpp --- old/knewstuff-5.13.0/src/downloadmanager.cpp 2015-08-04 13:07:48.000000000 +0200 +++ new/knewstuff-5.14.0/src/downloadmanager.cpp 2015-09-05 11:08:44.000000000 +0200 @@ -24,13 +24,13 @@ namespace KNS3 { -class DownloadManager::Private +class DownloadManagerPrivate { public: DownloadManager *q; Engine *engine; - Private(DownloadManager *q) + DownloadManagerPrivate(DownloadManager *q) : q(q) , engine(new Engine) , isInitialized(false) @@ -39,7 +39,7 @@ , page(0) , pageSize(100) {} - ~Private() + ~DownloadManagerPrivate() { delete engine; } @@ -63,7 +63,7 @@ DownloadManager::DownloadManager(QObject *parent) : QObject(parent) - , d(new Private(this)) + , d(new DownloadManagerPrivate(this)) { QString name = QCoreApplication::applicationName(); d->init(name + ".knsrc"); @@ -71,12 +71,12 @@ DownloadManager::DownloadManager(const QString &configFile, QObject *parent) : QObject(parent) - , d(new Private(this)) + , d(new DownloadManagerPrivate(this)) { d->init(configFile); } -void DownloadManager::Private::init(const QString &configFile) +void DownloadManagerPrivate::init(const QString &configFile) { q->connect(engine, SIGNAL(signalProvidersLoaded()), q, SLOT(_k_slotProvidersLoaded())); q->connect(engine, SIGNAL(signalUpdateableEntriesLoaded(KNS3::EntryInternal::List)), q, SLOT(_k_slotEntriesLoaded(KNS3::EntryInternal::List))); @@ -90,7 +90,7 @@ delete d; } -void DownloadManager::Private::_k_slotProvidersLoaded() +void DownloadManagerPrivate::_k_slotProvidersLoaded() { qCDebug(KNEWSTUFF) << "providers loaded"; isInitialized = true; @@ -110,7 +110,7 @@ } } -void DownloadManager::Private::_k_slotEntriesLoaded(const KNS3::EntryInternal::List &entries) +void DownloadManagerPrivate::_k_slotEntriesLoaded(const KNS3::EntryInternal::List &entries) { KNS3::Entry::List result; foreach (const KNS3::EntryInternal &entry, entries) { @@ -119,7 +119,7 @@ emit q->searchResult(result); } -void KNS3::DownloadManager::Private::_k_slotEntryStatusChanged(const KNS3::EntryInternal &entry) +void KNS3::DownloadManagerPrivate::_k_slotEntryStatusChanged(const KNS3::EntryInternal &entry) { emit q->entryStatusChanged(entry.toEntry()); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/knewstuff-5.13.0/src/downloadmanager.h new/knewstuff-5.14.0/src/downloadmanager.h --- old/knewstuff-5.13.0/src/downloadmanager.h 2015-08-04 13:07:48.000000000 +0200 +++ new/knewstuff-5.14.0/src/downloadmanager.h 2015-09-05 11:08:44.000000000 +0200 @@ -23,7 +23,7 @@ namespace KNS3 { - +class DownloadManagerPrivate; /** * KNewStuff update checker. * This class can be used to search for KNewStuff items @@ -123,8 +123,7 @@ Q_PRIVATE_SLOT(d, void _k_slotProvidersLoaded()) Q_PRIVATE_SLOT(d, void _k_slotEntryStatusChanged(const KNS3::EntryInternal &entry)) Q_PRIVATE_SLOT(d, void _k_slotEntriesLoaded(const KNS3::EntryInternal::List &entries)) - class Private; - Private *const d; + DownloadManagerPrivate *const d; Q_DISABLE_COPY(DownloadManager) }; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/knewstuff-5.13.0/src/entry.cpp new/knewstuff-5.14.0/src/entry.cpp --- old/knewstuff-5.13.0/src/entry.cpp 2015-08-04 13:07:48.000000000 +0200 +++ new/knewstuff-5.14.0/src/entry.cpp 2015-09-05 11:08:44.000000000 +0200 @@ -25,7 +25,7 @@ Q_LOGGING_CATEGORY(KNEWSTUFF, "knewstuff") Entry::Entry() - : d(new Private) + : d(new EntryPrivate) { } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/knewstuff-5.13.0/src/entry.h new/knewstuff-5.14.0/src/entry.h --- old/knewstuff-5.13.0/src/entry.h 2015-08-04 13:07:48.000000000 +0200 +++ new/knewstuff-5.14.0/src/entry.h 2015-09-05 11:08:44.000000000 +0200 @@ -31,7 +31,7 @@ namespace KNS3 { - +class EntryPrivate; /** * @short KNewStuff information about changed entries * @@ -142,8 +142,7 @@ private: Entry(); - class Private; - QExplicitlySharedDataPointer<Private> d; + QExplicitlySharedDataPointer<EntryPrivate> d; friend class EntryInternal; }; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/knewstuff-5.13.0/src/entry_p.h new/knewstuff-5.14.0/src/entry_p.h --- old/knewstuff-5.13.0/src/entry_p.h 2015-08-04 13:07:48.000000000 +0200 +++ new/knewstuff-5.14.0/src/entry_p.h 2015-09-05 11:08:44.000000000 +0200 @@ -24,7 +24,7 @@ namespace KNS3 { -class Entry::Private : public QSharedData +class EntryPrivate : public QSharedData { public: EntryInternal e; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/knewstuff-5.13.0/src/uploaddialog.cpp new/knewstuff-5.14.0/src/uploaddialog.cpp --- old/knewstuff-5.13.0/src/uploaddialog.cpp 2015-08-04 13:07:48.000000000 +0200 +++ new/knewstuff-5.14.0/src/uploaddialog.cpp 2015-09-05 11:08:44.000000000 +0200 @@ -49,7 +49,7 @@ using namespace KNS3; -bool UploadDialog::Private::init(const QString &configfile) +bool UploadDialogPrivate::init(const QString &configfile) { QVBoxLayout *layout = new QVBoxLayout; q->setLayout(layout); @@ -154,19 +154,19 @@ return success; } -void UploadDialog::Private::setBusy(const QString &message) +void UploadDialogPrivate::setBusy(const QString &message) { ui.busyLabel->setText(message); busyWidget->setVisible(true); } -void UploadDialog::Private::setIdle(const QString &message) +void UploadDialogPrivate::setIdle(const QString &message) { ui.busyLabel->setText(message); busyWidget->setVisible(false); } -void UploadDialog::Private::_k_showPage(int page) +void UploadDialogPrivate::_k_showPage(int page) { ui.stackedWidget->setCurrentIndex(page); setIdle(QString()); @@ -213,7 +213,7 @@ _k_updatePage(); } -void UploadDialog::Private::_k_updatePage() +void UploadDialogPrivate::_k_updatePage() { bool firstPage = ui.stackedWidget->currentIndex() == 0; backButton->setEnabled(!firstPage && !finished); @@ -260,7 +260,7 @@ } } -void UploadDialog::Private::_k_providersLoaded(const QStringList &providers) +void UploadDialogPrivate::_k_providersLoaded(const QStringList &providers) { if (providers.size() == 0) { setIdle(i18n("Could not fetch provider information.")); @@ -282,7 +282,7 @@ _k_updatePage(); } -void UploadDialog::Private::_k_providerChanged(const QString &providerName) +void UploadDialogPrivate::_k_providerChanged(const QString &providerName) { atticaHelper->setCurrentProvider(providerName); QString registerUrl = atticaHelper->provider().getRegisterAccountUrl(); @@ -302,12 +302,12 @@ _k_updatePage(); } -void UploadDialog::Private::_k_backPage() +void UploadDialogPrivate::_k_backPage() { _k_showPage(ui.stackedWidget->currentIndex() - 1); } -void UploadDialog::Private::_k_nextPage() +void UploadDialogPrivate::_k_nextPage() { // TODO: validate credentials after user name/password have been entered if (ui.stackedWidget->currentIndex() == UserPasswordPage) { @@ -322,7 +322,7 @@ } } -void UploadDialog::Private::_k_checkCredentialsFinished(bool success) +void UploadDialogPrivate::_k_checkCredentialsFinished(bool success) { ui.providerComboBox->setEnabled(true); ui.username->setEnabled(true); @@ -340,7 +340,7 @@ } } -void UploadDialog::Private::_k_licensesLoaded(const Attica::License::List &licenses) +void UploadDialogPrivate::_k_licensesLoaded(const Attica::License::List &licenses) { ui.mLicenseCombo->clear(); foreach (const Attica::License &license, licenses) { @@ -348,12 +348,12 @@ } } -void UploadDialog::Private::_k_currencyLoaded(const QString ¤cy) +void UploadDialogPrivate::_k_currencyLoaded(const QString ¤cy) { ui.priceCurrency->setText(currency); } -void UploadDialog::Private::_k_contentByCurrentUserLoaded(const Attica::Content::List &contentList) +void UploadDialogPrivate::_k_contentByCurrentUserLoaded(const Attica::Content::List &contentList) { setIdle(i18n("Fetching your previously updated content finished.")); @@ -371,7 +371,7 @@ } -void UploadDialog::Private::_k_updatedContentFetched(const Attica::Content &content) +void UploadDialogPrivate::_k_updatedContentFetched(const Attica::Content &content) { setIdle(i18n("Fetching content data from server finished.")); @@ -400,7 +400,7 @@ ui.fetchContentLinkImageLabel->setPixmap(QIcon::fromTheme("dialog-ok").pixmap(16)); } -void UploadDialog::Private::_k_previewLoaded(int index, const QImage &image) +void UploadDialogPrivate::_k_previewLoaded(int index, const QImage &image) { switch (index) { case 1: @@ -415,20 +415,20 @@ } } -void UploadDialog::Private::_k_updateContentsToggled(bool update) +void UploadDialogPrivate::_k_updateContentsToggled(bool update) { ui.userContentList->setEnabled(update); } UploadDialog::UploadDialog(QWidget *parent) - : QDialog(parent), d(new Private(this)) + : QDialog(parent), d(new UploadDialogPrivate(this)) { const QString name = QCoreApplication::applicationName(); init(name + ".knsrc"); } UploadDialog::UploadDialog(const QString &configFile, QWidget *parent) - : QDialog(parent), d(new Private(this)) + : QDialog(parent), d(new UploadDialogPrivate(this)) { init(configFile); } @@ -553,12 +553,12 @@ } } -void UploadDialog::Private::_k_priceToggled(bool priceEnabled) +void UploadDialogPrivate::_k_priceToggled(bool priceEnabled) { ui.priceGroupBox->setEnabled(priceEnabled); } -void UploadDialog::Private::_k_categoriesLoaded(const Attica::Category::List &loadedCategories) +void UploadDialogPrivate::_k_categoriesLoaded(const Attica::Category::List &loadedCategories) { categories = loadedCategories; @@ -584,7 +584,7 @@ QDialog::accept(); } -void UploadDialog::Private::_k_startUpload() +void UploadDialogPrivate::_k_startUpload() { // FIXME: this only works if categories are set in the .knsrc file // TODO: ask for confirmation when closing the dialog @@ -657,7 +657,7 @@ } } -void UploadDialog::Private::_k_changePreview1() +void UploadDialogPrivate::_k_changePreview1() { const QStringList filters = _supportedMimeTypes(); QPointer<QFileDialog> dialog = new QFileDialog(q, i18n("Select preview image")); @@ -672,7 +672,7 @@ delete dialog; } -void UploadDialog::Private::_k_changePreview2() +void UploadDialogPrivate::_k_changePreview2() { const QStringList filters = _supportedMimeTypes(); QPointer<QFileDialog> dialog = new QFileDialog(q, i18n("Select preview image")); @@ -686,7 +686,7 @@ delete dialog; } -void UploadDialog::Private::_k_changePreview3() +void UploadDialogPrivate::_k_changePreview3() { const QStringList filters = _supportedMimeTypes(); QPointer<QFileDialog> dialog = new QFileDialog(q, i18n("Select preview image")); @@ -700,7 +700,7 @@ delete dialog; } -void UploadDialog::Private::_k_contentAdded(Attica::BaseJob *baseJob) +void UploadDialogPrivate::_k_contentAdded(Attica::BaseJob *baseJob) { if (baseJob->metadata().error()) { if (baseJob->metadata().error() == Attica::Metadata::NetworkError) { @@ -751,12 +751,12 @@ } } -void UploadDialog::Private::_k_openRegisterAccountWebpage(QString) +void UploadDialogPrivate::_k_openRegisterAccountWebpage(QString) { KRun::runUrl(QUrl::fromUserInput(atticaHelper->provider().getRegisterAccountUrl()), "text/html", q); } -void UploadDialog::Private::doUpload(const QString &index, const QUrl &path) +void UploadDialogPrivate::doUpload(const QString &index, const QUrl &path) { QFile file(path.toLocalFile()); if (!file.open(QIODevice::ReadOnly)) { @@ -790,35 +790,35 @@ } } -void UploadDialog::Private::_k_fileUploadFinished(Attica::BaseJob *) +void UploadDialogPrivate::_k_fileUploadFinished(Attica::BaseJob *) { ui.uploadContentImageLabel->setPixmap(QIcon::fromTheme("dialog-ok").pixmap(16)); finishedContents = true; uploadFileFinished(); } -void UploadDialog::Private::_k_preview1UploadFinished(Attica::BaseJob *) +void UploadDialogPrivate::_k_preview1UploadFinished(Attica::BaseJob *) { ui.uploadPreview1ImageLabel->setPixmap(QIcon::fromTheme("dialog-ok").pixmap(16)); finishedPreview1 = true; uploadFileFinished(); } -void UploadDialog::Private::_k_preview2UploadFinished(Attica::BaseJob *) +void UploadDialogPrivate::_k_preview2UploadFinished(Attica::BaseJob *) { ui.uploadPreview2ImageLabel->setPixmap(QIcon::fromTheme("dialog-ok").pixmap(16)); finishedPreview2 = true; uploadFileFinished(); } -void UploadDialog::Private::_k_preview3UploadFinished(Attica::BaseJob *) +void UploadDialogPrivate::_k_preview3UploadFinished(Attica::BaseJob *) { ui.uploadPreview3ImageLabel->setPixmap(QIcon::fromTheme("dialog-ok").pixmap(16)); finishedPreview3 = true; uploadFileFinished(); } -void UploadDialog::Private::uploadFileFinished() +void UploadDialogPrivate::uploadFileFinished() { // FIXME multiple previews if (finishedContents && (previewFile1.isEmpty() || finishedPreview1) @@ -832,14 +832,14 @@ } } -void UploadDialog::Private::_k_detailsLinkLoaded(const QUrl &url) +void UploadDialogPrivate::_k_detailsLinkLoaded(const QUrl &url) { ui.contentWebsiteLink->setText(QLatin1String("") + i18nc("A link to the website where the get hot new stuff upload can be seen", "Visit website") + QLatin1String("</a>")); ui.fetchContentLinkImageLabel->setPixmap(QIcon::fromTheme("dialog-ok").pixmap(16)); } -QStringList UploadDialog::Private::_supportedMimeTypes() const +QStringList UploadDialogPrivate::_supportedMimeTypes() const { QStringList mimeTypes; QList<QByteArray> supported = QImageReader::supportedMimeTypes(); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/knewstuff-5.13.0/src/uploaddialog.h new/knewstuff-5.14.0/src/uploaddialog.h --- old/knewstuff-5.13.0/src/uploaddialog.h 2015-08-04 13:07:48.000000000 +0200 +++ new/knewstuff-5.14.0/src/uploaddialog.h 2015-09-05 11:08:44.000000000 +0200 @@ -36,6 +36,7 @@ namespace KNS3 { +class UploadDialogPrivate; /** * @short KNewStuff file upload dialog. * @@ -160,8 +161,7 @@ private: bool init(const QString &configfile); - class Private; - Private *const d; + UploadDialogPrivate *const d; Q_PRIVATE_SLOT(d, void _k_nextPage()) Q_PRIVATE_SLOT(d, void _k_backPage()) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/knewstuff-5.13.0/src/uploaddialog_p.h new/knewstuff-5.14.0/src/uploaddialog_p.h --- old/knewstuff-5.13.0/src/uploaddialog_p.h 2015-08-04 13:07:48.000000000 +0200 +++ new/knewstuff-5.14.0/src/uploaddialog_p.h 2015-09-05 11:08:44.000000000 +0200 @@ -37,10 +37,10 @@ namespace KNS3 { -class UploadDialog::Private +class UploadDialogPrivate { public: - Private(UploadDialog *q) + UploadDialogPrivate(UploadDialog *q) : q(q) , currentPage(UserPasswordPage) , finished(false)