Hello community, here is the log from the commit of package yast2-packager for openSUSE:Factory checked in at 2015-07-23 15:22:06 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-packager (Old) and /work/SRC/openSUSE:Factory/.yast2-packager.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "yast2-packager" Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-packager/yast2-packager.changes 2015-07-20 15:13:44.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.yast2-packager.new/yast2-packager.changes 2015-07-23 15:22:09.000000000 +0200 @@ -1,0 +2,6 @@ +Tue Jul 21 08:32:41 UTC 2015 - jreidinger@suse.com + +- fix crash when adding addon on DVD (bnc#938786) +- 3.1.76 + +------------------------------------------------------------------- Old: ---- yast2-packager-3.1.75.tar.bz2 New: ---- yast2-packager-3.1.76.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-packager.spec ++++++ --- /var/tmp/diff_new_pack.6jUxFE/_old 2015-07-23 15:22:10.000000000 +0200 +++ /var/tmp/diff_new_pack.6jUxFE/_new 2015-07-23 15:22:10.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-packager -Version: 3.1.75 +Version: 3.1.76 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build ++++++ yast2-packager-3.1.75.tar.bz2 -> yast2-packager-3.1.76.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-3.1.75/package/yast2-packager.changes new/yast2-packager-3.1.76/package/yast2-packager.changes --- old/yast2-packager-3.1.75/package/yast2-packager.changes 2015-07-15 15:03:41.000000000 +0200 +++ new/yast2-packager-3.1.76/package/yast2-packager.changes 2015-07-21 10:53:37.000000000 +0200 @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Tue Jul 21 08:32:41 UTC 2015 - jreidinger@suse.com + +- fix crash when adding addon on DVD (bnc#938786) +- 3.1.76 + +------------------------------------------------------------------- Tue Jul 14 15:46:32 UTC 2015 - lslezak@suse.cz - fixed crash when editing the default URL of a new addon diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-3.1.75/package/yast2-packager.spec new/yast2-packager-3.1.76/package/yast2-packager.spec --- old/yast2-packager-3.1.75/package/yast2-packager.spec 2015-07-15 15:03:41.000000000 +0200 +++ new/yast2-packager-3.1.76/package/yast2-packager.spec 2015-07-21 10:53:37.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-packager -Version: 3.1.75 +Version: 3.1.76 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-3.1.75/src/modules/SourceDialogs.rb new/yast2-packager-3.1.76/src/modules/SourceDialogs.rb --- old/yast2-packager-3.1.75/src/modules/SourceDialogs.rb 2015-07-15 15:03:42.000000000 +0200 +++ new/yast2-packager-3.1.76/src/modules/SourceDialogs.rb 2015-07-21 10:53:37.000000000 +0200 @@ -2266,8 +2266,11 @@ @_url = "smb://" elsif selected == :nfs @_url = "nfs://" + # this case is specific, as it return complete path and not just + # prefix as others elsif selected == :cd || selected == :dvd - @_url = selected == :cd ? "cd://" : "dvd://" + # use three slashes as third slash means path + @_url = selected == :cd ? "cd:///" : "dvd:///" if @cd_device_name != "" @_url = Ops.add( Ops.add(@_url, "?devices="), diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-3.1.75/test/source_dialogs_test.rb new/yast2-packager-3.1.76/test/source_dialogs_test.rb --- old/yast2-packager-3.1.75/test/source_dialogs_test.rb 2015-07-15 15:03:42.000000000 +0200 +++ new/yast2-packager-3.1.76/test/source_dialogs_test.rb 2015-07-21 10:53:37.000000000 +0200 @@ -80,4 +80,15 @@ expect(subject.URLScheme("test")).to eq "url" end end + + describe ".SelectStore" do + it "sets url to full url for DVD and CD selection" do + allow(Yast::UI).to receive(:QueryWidget).with(Id(:type), :CurrentButton) + .and_return(:dvd) + + described_class.SelectStore(:type, {}) + + expect(described_class.instance_variable_get("@_url")).to eq "dvd:///" + end + end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-3.1.75/test/test_helper.rb new/yast2-packager-3.1.76/test/test_helper.rb --- old/yast2-packager-3.1.75/test/test_helper.rb 2015-07-15 15:03:42.000000000 +0200 +++ new/yast2-packager-3.1.76/test/test_helper.rb 2015-07-21 10:53:37.000000000 +0200 @@ -8,3 +8,4 @@ end require "yast" +require "yast/rspec"