Hello community, here is the log from the commit of package telepathy-mission-control for openSUSE:Factory checked in at 2013-01-20 14:55:32 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/telepathy-mission-control (Old) and /work/SRC/openSUSE:Factory/.telepathy-mission-control.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "telepathy-mission-control", Maintainer is "gnome-maintainers@suse.de" Changes: -------- --- /work/SRC/openSUSE:Factory/telepathy-mission-control/telepathy-mission-control.changes 2012-10-06 18:44:13.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.telepathy-mission-control.new/telepathy-mission-control.changes 2013-01-20 14:55:35.000000000 +0100 @@ -1,0 +2,7 @@ +Sun Jan 13 11:08:17 UTC 2013 - zaitor@opensuse.org + +- Added tmc-fire-PropertiesChanged-on-URISchemes-change.patch and + tmc-mailto-is-the-proper-URI-scheme.patch needed to ensure + visual feedback on sip accounts changes (fdo#40393). + +------------------------------------------------------------------- New: ---- tmc-fire-PropertiesChanged-on-URISchemes-change.patch tmc-mailto-is-the-proper-URI-scheme.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ telepathy-mission-control.spec ++++++ --- /var/tmp/diff_new_pack.PU0w3i/_old 2013-01-20 14:55:36.000000000 +0100 +++ /var/tmp/diff_new_pack.PU0w3i/_new 2013-01-20 14:55:36.000000000 +0100 @@ -1,7 +1,7 @@ # # spec file for package telepathy-mission-control # -# Copyright (c) 2012 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2013 SUSE LINUX Products GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -27,6 +27,10 @@ Source: http://telepathy.freedesktop.org/releases/telepathy-mission-control/%{name}-%{version}.tar.gz # PATCH-NEEDS-REBASE lockdown-protocols.patch fdo21699 vuntz@novell.com -- Sent upstream for discussion, it will need a rewrite for MC5 WAS: PATCH-FEATURE-UPSTREAM Patch1: lockdown-protocols.patch +# PATCH-FIX-UPSTREAM tmc-mailto-is-the-proper-URI-scheme.patch fdo#40393 zaitor@opensuse.org -- Changes made to sipaccounts does not appear. +Patch2: tmc-mailto-is-the-proper-URI-scheme.patch +# PATCH-FIX-UPSTREAM tmc-fire-PropertiesChanged-on-URISchemes-change.patch fdo#40393 zaitor@opensuse.org -- Changes made to sipaccounts does not appear. +Patch3: tmc-fire-PropertiesChanged-on-URISchemes-change.patch BuildRequires: dbus-1-glib-devel >= 0.73 BuildRequires: fdupes BuildRequires: libgnome-keyring-devel @@ -78,6 +82,8 @@ %setup -q # NEEDS REBASE # %patch1 -p0 +%patch2 -p1 +%patch3 -p1 %build %configure --disable-static --with-pic\ ++++++ tmc-fire-PropertiesChanged-on-URISchemes-change.patch ++++++
From 9c038fb370c25a2fb87fd80e71b4591cb81c5fa5 Mon Sep 17 00:00:00 2001 From: Guillaume Desmottes
Date: Mon, 07 Jan 2013 15:18:09 +0000 Subject: account-addressing: fire PropertiesChanged on URISchemes change
--- diff --git a/src/mcd-account-addressing.c b/src/mcd-account-addressing.c index d5604cb..19d622d 100644 --- a/src/mcd-account-addressing.c +++ b/src/mcd-account-addressing.c @@ -60,6 +60,7 @@ addressing_set_uri_scheme_association (TpSvcAccountInterfaceAddressing *iface, { GPtrArray *new_schemes = g_ptr_array_new (); gchar **s; + GHashTable *changed; if (association) { @@ -81,6 +82,14 @@ addressing_set_uri_scheme_association (TpSvcAccountInterfaceAddressing *iface, mcd_storage_set_strv (storage, account, SCHEMES, (const gchar * const *) new_schemes->pdata, FALSE); + changed = tp_asv_new ( + "URISchemes", G_TYPE_STRV, new_schemes->pdata, + NULL); + + tp_svc_dbus_properties_emit_properties_changed (self, + TP_IFACE_ACCOUNT_INTERFACE_ADDRESSING, changed, NULL); + + g_hash_table_unref (changed); g_ptr_array_unref (new_schemes); } diff --git a/tests/twisted/account/addressing.py b/tests/twisted/account/addressing.py index 7032a81..e303c93 100755 --- a/tests/twisted/account/addressing.py +++ b/tests/twisted/account/addressing.py @@ -57,8 +57,24 @@ def test(q, bus, mc): uri_schemes = get_schemes (account_props) assertEquals (uri_schemes, ['mailto']) - # remove association to produce empty list + q.expect('dbus-signal', signal='PropertiesChanged', + predicate=(lambda e: + e.args[0] == cs.ACCOUNT_IFACE_ADDRESSING and + set(e.args[1]['URISchemes']) == set(['mailto']))) + + # add a second association + address_iface.SetURISchemeAssociation ('telnet', True) + uri_schemes = get_schemes (account_props) + assertSameSets (['mailto','telnet',], uri_schemes) + + q.expect('dbus-signal', signal='PropertiesChanged', + predicate=(lambda e: + e.args[0] == cs.ACCOUNT_IFACE_ADDRESSING and + set(e.args[1]['URISchemes']) == set(['telnet', 'mailto']))) + + # remove associations to produce empty list address_iface.SetURISchemeAssociation ('mailto', False) + address_iface.SetURISchemeAssociation ('telnet', False) uri_schemes = get_schemes (account_props) assertEquals (uri_schemes, []) -- cgit v0.9.0.2-2-gbebe ++++++ tmc-mailto-is-the-proper-URI-scheme.patch ++++++
From 4b5ccf8a74f6c80d4a9787fcaec445327d589800 Mon Sep 17 00:00:00 2001 From: Guillaume Desmottes
Date: Tue, 08 Jan 2013 12:53:06 +0000 Subject: addressing.py: 'mailto' is the proper URI scheme
--- diff --git a/tests/twisted/account/addressing.py b/tests/twisted/account/addressing.py index 84faae9..7032a81 100755 --- a/tests/twisted/account/addressing.py +++ b/tests/twisted/account/addressing.py @@ -43,22 +43,22 @@ def test(q, bus, mc): assertEquals (uri_schemes, []) # remove URI from empty list: - address_iface.SetURISchemeAssociation ('email', False) + address_iface.SetURISchemeAssociation ('mailto', False) uri_schemes = get_schemes (account_props) assertEquals (uri_schemes, []) # add association to empty list - address_iface.SetURISchemeAssociation ('email', True) + address_iface.SetURISchemeAssociation ('mailto', True) uri_schemes = get_schemes (account_props) - assertEquals (uri_schemes, ['email']) + assertEquals (uri_schemes, ['mailto']) # add association to list where it already resides - address_iface.SetURISchemeAssociation ('email', True) + address_iface.SetURISchemeAssociation ('mailto', True) uri_schemes = get_schemes (account_props) - assertEquals (uri_schemes, ['email']) + assertEquals (uri_schemes, ['mailto']) # remove association to produce empty list - address_iface.SetURISchemeAssociation ('email', False) + address_iface.SetURISchemeAssociation ('mailto', False) uri_schemes = get_schemes (account_props) assertEquals (uri_schemes, []) -- cgit v0.9.0.2-2-gbebe -- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org