Hello community, here is the log from the commit of package libgnomesu for openSUSE:Factory checked in at 2012-02-28 19:24:17 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libgnomesu (Old) and /work/SRC/openSUSE:Factory/.libgnomesu.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "libgnomesu", Maintainer is "gnome-maintainers@suse.de" Changes: -------- --- /work/SRC/openSUSE:Factory/libgnomesu/libgnomesu.changes 2011-12-05 12:44:36.000000000 +0100 +++ /work/SRC/openSUSE:Factory/.libgnomesu.new/libgnomesu.changes 2012-02-28 19:24:24.000000000 +0100 @@ -1,0 +2,8 @@ +Fri Feb 24 10:15:30 UTC 2012 - vuntz@opensuse.org + +- Add libgnomesu-suid_flags.patch: respect SUID_CFLAGS/SUID_LDFLAGS + when building the suid binary gnomesu-pam-backend. +- Set SUID_CFLAGS to -fPIE and SUID_LDFLAGS to -pie in %build. This + fixes bnc#743139. + +------------------------------------------------------------------- New: ---- libgnomesu-suid_flags.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libgnomesu.spec ++++++ --- /var/tmp/diff_new_pack.H3ii7H/_old 2012-02-28 19:24:27.000000000 +0100 +++ /var/tmp/diff_new_pack.H3ii7H/_new 2012-02-28 19:24:27.000000000 +0100 @@ -1,7 +1,7 @@ # # spec file for package libgnomesu # -# Copyright (c) 2011 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2012 SUSE LINUX Products GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -16,14 +16,13 @@ # - Name: libgnomesu Version: 1.0.0 -Release: 337 -License: LGPL-2.1+ +Release: 0 Summary: GNOME su Library -Url: http://members.chello.nl/~h.lai/libgnomesu/ +License: LGPL-2.1+ Group: System/GUI/GNOME +Url: http://members.chello.nl/~h.lai/libgnomesu/ Source: %{name}-%{version}.tar.bz2 Source1: gnomesu-pam.pamd # PATCH-FIX-UPSTREAM libgnomesu-libtool.patch -- Simple build fix @@ -66,11 +65,13 @@ Patch19: libgnomesu-no-gconf.patch # PATCH-FIX-UPSTREAM libgnomesu-gtk3.patch vuntz@opensuse.org -- Port to GTK+ 3 Patch20: libgnomesu-gtk3.patch +# PATCH-FIX-UPSTREAM libgnomesu-suid_flags.patch bnc#743139 vuntz@opensuse.org -- Respect SUID_CFLAGS/SUID_LDFLAGS +Patch21: libgnomesu-suid_flags.patch BuildRequires: fdupes BuildRequires: gtk3-devel BuildRequires: intltool -BuildRequires: pam-devel BuildRequires: libtool +BuildRequires: pam-devel BuildRequires: translation-update-upstream PreReq: permissions # Needed for patch19 @@ -88,7 +89,6 @@ applications. It supports sudo, consolehelper, PAM, and su. %package -n libgnomesu0 -License: LGPL-2.1+ Summary: GNOME su Library Group: System/GUI/GNOME Requires: %{name} >= %{version} @@ -98,7 +98,6 @@ applications. It supports sudo, consolehelper, PAM, and su. %package devel -License: LGPL-2.1+ Summary: Development files for libgnomesu Group: Development/Libraries/GNOME Requires: %{name} = %{version} @@ -129,6 +128,7 @@ %patch18 -p1 %patch19 -p1 %patch20 -p1 +%patch21 -p1 cp -a %{S:1} pam-backend/gnomesu-pam # Upstream is dead, libgnomesu.po in LCN includes strings in our patches: translation-update-upstream @@ -136,6 +136,8 @@ %build autoreconf -f -i intltoolize -f +export SUID_CFLAGS="-fPIE" +export SUID_LDFLAGS="-pie" %configure\ --libexecdir=%{_libexecdir}/%{name}\ --disable-schemas-install\ ++++++ libgnomesu-suid_flags.patch ++++++ Index: libgnomesu-1.0.0/pam-backend/Makefile.am =================================================================== --- libgnomesu-1.0.0.orig/pam-backend/Makefile.am +++ libgnomesu-1.0.0/pam-backend/Makefile.am @@ -5,7 +5,13 @@ libexec_PROGRAMS = gnomesu-pam-backend INCLUDES = $(GNOMESU_PAM_BACKEND_CFLAGS) -I$(top_srcdir)/su-backend gnomesu_pam_backend_SOURCES = pam.c +gnomesu_pam_backend_CFLAGS = \ + $(INCLUDES) \ + $(SUID_CFLAGS) \ + $(AM_CFLAGS) gnomesu_pam_backend_LDFLAGS = \ + $(SUID_LDFLAGS) \ + $(AM_LDFLAGS) \ $(GNOMESU_PAM_BACKEND_LIBS)\ $(top_builddir)/su-backend/libcommon.la \ -lpam Index: libgnomesu-1.0.0/configure.in =================================================================== --- libgnomesu-1.0.0.orig/configure.in +++ libgnomesu-1.0.0/configure.in @@ -247,6 +247,11 @@ else fi AC_SUBST(PAMDIR) +AC_ARG_VAR([SUID_CFLAGS], + [CFLAGS used for binaries which are usually with the suid bit]) +AC_ARG_VAR([SUID_LDFLAGS], + [LDFLAGS used for binaries which are usually with the suid bit]) + AM_BINRELOC Index: libgnomesu-1.0.0/usr/lib/libgnomesu/gnomesu-pam-backend =================================================================== Binary files libgnomesu-1.0.0.orig/usr/lib/libgnomesu/gnomesu-pam-backend and /dev/null differ -- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org