Hello community,
here is the log from the commit of package system-config-printer for openSUSE:12.1:Update:Test checked in at 2012-01-06 18:13:42
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:12.1:Update:Test/system-config-printer (Old)
and /work/SRC/openSUSE:12.1:Update:Test/.system-config-printer.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "system-config-printer", Maintainer is "gnome-maintainers@suse.de"
Changes:
--------
--- /work/SRC/openSUSE:12.1:Update:Test/system-config-printer/system-config-printer.changes 2011-12-08 17:38:02.000000000 +0100
+++ /work/SRC/openSUSE:12.1:Update:Test/.system-config-printer.new/system-config-printer.changes 2012-01-06 18:13:43.000000000 +0100
@@ -1,0 +2,6 @@
+Tue Jan 3 08:25:01 UTC 2012 - vuntz@opensuse.org
+
+- Fix coding errors caught by Stephen Shaw in
+ system-config-printer-subprocess-no-shell.patch.
+
+-------------------------------------------------------------------
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ system-config-printer-subprocess-no-shell.patch ++++++
--- /var/tmp/diff_new_pack.9ddmIf/_old 2012-01-06 18:13:43.000000000 +0100
+++ /var/tmp/diff_new_pack.9ddmIf/_new 2012-01-06 18:13:43.000000000 +0100
@@ -30,7 +30,7 @@
+ new_environ['LC_ALL'] = "C"
+ new_environ['DISPLAY'] = ""
+ args = ["hp-info", "-x", "-i", "-d" + faxuri]
-+ debugprint (faxuri + ": " + args)
++ debugprint (faxuri + ": " + str(args))
try:
- p = subprocess.Popen (cmd, shell=True, close_fds=True,
+ p = subprocess.Popen (args, env=new_environ, close_fds=True,
@@ -45,7 +45,7 @@
- cmd = 'hp-query -k scan-type -d "${URI}"'
- debugprint (uri + ": " + cmd)
+ args = ["hp-query", "-k", "scan-type", "-d", uri]
-+ debugprint (uri + ": " + args)
++ debugprint (uri + ": " + str(args))
try:
- p = subprocess.Popen (cmd, shell=True, close_fds=True,
+ p = subprocess.Popen (args, close_fds=True,
@@ -63,7 +63,7 @@
- cmd = 'hp-makeuri ' + mod + ' "${HOST}"'
- debugprint (host + ": " + cmd)
+ args = ["hp-makeuri", mod, host]
-+ debugprint (host + ": " + args)
++ debugprint (host + ": " + str(args))
uri = None
try:
- p = subprocess.Popen (cmd, shell=True, close_fds=True,
@@ -79,7 +79,7 @@
- cmd = '/usr/lib/cups/backend/snmp "${HOST}"'
- debugprint (host + ": " + cmd)
+ args = ["/usr/lib/cups/backend/snmp", host]
-+ debugprint (host + ": " + args)
++ debugprint (host + ": " + str(args))
stdout = None
try:
- p = subprocess.Popen (cmd, shell=True, close_fds=True,
@@ -126,7 +126,7 @@
p = TimedSubprocess (parent=parent,
timeout=3000,
- args='LC_ALL=C DISPLAY= hp-info -d"$URI"',
-+ args=["hp-info", "-d" + uri,
++ args=["hp-info", "-d" + uri],
close_fds=True,
- shell=True,
+ env=new_environ,
--
To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org
For additional commands, e-mail: opensuse-commit+help@opensuse.org