Hello community, here is the log from the commit of package pam_fp checked in at Thu Nov 6 22:25:20 CET 2008. -------- --- pam_fp/pam_fp.changes 2008-11-05 16:09:10.000000000 +0100 +++ /mounts/work_src_done/STABLE/pam_fp/pam_fp.changes 2008-11-06 11:48:06.000000000 +0100 @@ -1,0 +2,10 @@ +Thu Nov 6 11:47:03 CET 2008 - thoenig@suse.de + +- do not require libfprint0 explicitly + +------------------------------------------------------------------- +Thu Nov 6 11:37:29 CET 2008 - thoenig@suse.de + +- don't crash if user is invalid (bnc#442222) + +------------------------------------------------------------------- calling whatdependson for head-i586 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ pam_fp.spec ++++++ --- /var/tmp/diff_new_pack.dQ4252/_old 2008-11-06 22:23:50.000000000 +0100 +++ /var/tmp/diff_new_pack.dQ4252/_new 2008-11-06 22:23:50.000000000 +0100 @@ -24,13 +24,12 @@ Summary: PAM module to be used with libfprint BuildRequires: coreutils libfprint-devel pam-devel pkgconfig PreReq: coreutils pam pam-config -Requires: libfprint0 # on biarch platforms we need to have it before the call of pam-config Recommends: yast2-fingerprint-reader Obsoletes: pam_thinkfinger <= 0.3 Provides: pam_thinkfinger = 0.3 Version: 0.1 -Release: 9 +Release: 10 License: GPL v2 or later Group: Productivity/Security Source0: %{name}-%{version}.tar.bz2 @@ -101,6 +100,10 @@ /%_lib/security/pam_fp.so %changelog +* Thu Nov 06 2008 thoenig@suse.de +- do not require libfprint0 explicitly +* Thu Nov 06 2008 thoenig@suse.de +- don't crash if user is invalid (bnc#442222) * Wed Nov 05 2008 thoenig@suse.de - move supplementing USB IDs from libfprint0 to pam_fp (bnc#441754) * Tue Oct 28 2008 thoenig@suse.de ++++++ pam_fp-0.1.tar.bz2 ++++++ diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/pam_fp-0.1/src/pam_fp.c new/pam_fp-0.1/src/pam_fp.c --- old/pam_fp-0.1/src/pam_fp.c 2008-10-27 14:10:59.000000000 +0100 +++ new/pam_fp-0.1/src/pam_fp.c 2008-11-06 11:31:54.000000000 +0100 @@ -266,8 +266,8 @@ int ret; pam_fp_libfprint_s *fprint = &pam_fp->fprint; int std_err, std_err_new; - char *home_dir_old; - char *home_dir; + char *home_dir_old = NULL; + char *home_dir = NULL; struct passwd *passwd; /* don't let libfprint clutter console prompts in case of errors */ @@ -277,7 +277,7 @@ passwd = getpwnam (pam_fp->user); if (passwd == NULL) { - pam_fp_log (pam_fp, LOG_ERR, "fork(2) failed."); + pam_fp_log (pam_fp, LOG_ERR, "getpwnam(3) failed."); goto out; } @@ -356,12 +356,13 @@ retval = 0; out: - pam_fp_log (pam_fp, LOG_NOTICE, "Restoring $HOME=\"%s\".", home_dir_old); - ret = setenv ("HOME", home_dir_old, 1); - if (ret < 0) - pam_fp_log (pam_fp, LOG_ERR, "setenv(3) failed."); - if (home_dir_old) + if (home_dir_old) { + pam_fp_log (pam_fp, LOG_NOTICE, "Restoring $HOME=\"%s\".", home_dir_old); + ret = setenv ("HOME", home_dir_old, 1); + if (ret < 0) + pam_fp_log (pam_fp, LOG_ERR, "setenv(3) failed."); free (home_dir_old); + } if (home_dir) free (home_dir); dup2 (std_err, STDERR_FILENO); @@ -444,7 +445,7 @@ static void pam_fp_prompt (pam_fp_s *pam_fp) { int ret = -1; - char *resp; + char *resp = NULL; /* always returning from pam_prompt due to the CR sent by the keyboard or by uinput (child) */ pam_prompt (pam_fp->pamh, PAM_PROMPT_ECHO_OFF, &resp, "Password or swipe finger: "); @@ -481,6 +482,7 @@ int pid; pam_fp.pamh = pamh; + pam_fp.user = NULL; pam_fp.swipe_result = PAM_AUTHINFO_UNAVAIL; pam_fp.swipe_succeeded = 0; pam_fp_options (&pam_fp, argc, argv); ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... -- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org