Hello community, here is the log from the commit of package supportutils checked in at Fri Oct 24 15:30:42 CEST 2008. -------- --- supportutils/supportutils.changes 2008-10-23 17:48:53.000000000 +0200 +++ /mounts/work_src_done/STABLE/supportutils/supportutils.changes 2008-10-24 02:38:05.014231000 +0200 @@ -1,0 +2,6 @@ +Thu Oct 23 16:54:35 MDT 2008 - jrecord@novell.com + +-fixed plugin directory security (bnc#438338) +-fixed conf_file reference (bnc#438317) + +------------------------------------------------------------------- calling whatdependson for head-i586 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ supportutils.spec ++++++ --- /var/tmp/diff_new_pack.C16125/_old 2008-10-24 15:30:26.000000000 +0200 +++ /var/tmp/diff_new_pack.C16125/_new 2008-10-24 15:30:26.000000000 +0200 @@ -25,7 +25,7 @@ Group: System/Management AutoReqProv: on Version: 1.01 -Release: 13 +Release: 14 Source: %{name}-%{version}.tar.gz Summary: Support Troubleshooting Tools BuildRoot: %{_tmppath}/%{name}-%{version}-build @@ -85,6 +85,9 @@ rm -rf $RPM_BUILD_ROOT %changelog +* Thu Oct 23 2008 jrecord@novell.com +-fixed plugin directory security (bnc#438338) +-fixed conf_file reference (bnc#438317) * Fri Oct 17 2008 jrecord@novell.com -added plugin skipped (bnc#436655) -added timed_log_cmd to plugins (bnc#436624) ++++++ supportutils-1.01.tar.gz ++++++ diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/supportutils-1.01/supportconfig new/supportutils-1.01/supportconfig --- old/supportutils-1.01/supportconfig 2008-10-23 17:47:55.000000000 +0200 +++ new/supportutils-1.01/supportconfig 2008-10-24 02:33:30.000000000 +0200 @@ -1,7 +1,7 @@ #!/bin/bash -SVER=2.25-44 -SDATE="2008 10 17" +SVER=2.25-50 +SDATE="2008 10 23" ############################################################################## # supportconfig - Gathers system troubleshooting information for NTS. @@ -632,7 +632,7 @@ log_cmd $OF '/sbin/sysctl kernel.tainted' TAINT=$(sysctl kernel.tainted | cut -d= -f2) else - conf_file $OF '/proc/sys/kernel/tainted' + conf_files $OF '/proc/sys/kernel/tainted' TAINT=$(cat /proc/sys/kernel/tainted) fi if [ $TAINT -gt 0 ]; then @@ -2858,9 +2858,30 @@ fi } +bad_plugin_dir() { + if [ -d $XPLUGIN_DIR ]; then + XPLUGIN_DIR_OWNER=$(stat -c %u $XPLUGIN_DIR) + XPLUGIN_DIR_MODE=$(stat -c %f $XPLUGIN_DIR) + if [ "$XPLUGIN_DIR_MODE" != "41c0" -a "$XPLUGIN_DIR_MODE" != "4140" -o $XPLUGIN_DIR_OWNER -ne 0 ]; then + # return a bad plugin directory + return 0 + else + # return a good plugin directory + return 1 + fi + else + # return a good plugin directory + return 1 + fi +} + exec_plugins() { if [ -d $XPLUGIN_DIR ]; then printlog "Supportconfig Plugins:" + if bad_plugin_dir; then + echolog Skipped + return 5 + fi PLUGIN_CNT=$(\ls -A1 $XPLUGIN_DIR | wc -l) echolog $PLUGIN_CNT for PLUGIN_FEATURE in $PLUGIN_FEATURES @@ -3258,6 +3279,13 @@ if [ "$CURRENT_LOG_DIR" != "$PREFERRED_LOG_DIR" ]; then echolog " NOTICE: Using alternate log directory $CURRENT_LOG_DIR" fi + if bad_plugin_dir; then + echolog " WARNING: Invalid plugin directory, all plugins will be skipped." + echo " See $CSFILE for details." + log_write ${CSFILE} " Plugin Directory: $XPLUGIN_DIR" + log_write ${CSFILE} " Valid Owner (Current): 0 ($XPLUGIN_DIR_OWNER), Try chown root $XPLUGIN_DIR" + log_write ${CSFILE} " Valid Modes (Current): 41c0,4140 ($XPLUGIN_DIR_MODE), Try chmod 0700 $XPLUGIN_DIR" + fi log_write ${CSFILE} " Environment Value: $SLES_VER ($KERNVER)" log_write ${CSFILE} " Command with Args: $0 $ALL_ARGS" test -s $SC_CONF && log_write ${CSFILE} " Using Options: $SC_CONF" diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/supportutils-1.01/supportutils.changes new/supportutils-1.01/supportutils.changes --- old/supportutils-1.01/supportutils.changes 2008-10-23 17:47:55.000000000 +0200 +++ new/supportutils-1.01/supportutils.changes 2008-10-24 02:33:30.000000000 +0200 @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Thu Oct 23 16:54:35 MDT 2008 - jrecord@novell.com + +-fixed plugin directory security (bnc#438338) +-fixed conf_file reference (bnc#438317) + +------------------------------------------------------------------- Fri Oct 17 14:38:25 MDT 2008 - jrecord@novell.com -added plugin skipped (bnc#436655) diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/supportutils-1.01/supportutils.spec new/supportutils-1.01/supportutils.spec --- old/supportutils-1.01/supportutils.spec 2008-10-23 17:47:55.000000000 +0200 +++ new/supportutils-1.01/supportutils.spec 2008-10-24 02:33:30.000000000 +0200 @@ -1,5 +1,5 @@ # -# spec file for package supportutils (Version 1.01.19) +# spec file for package supportutils (Version 1.01.20) # # Copyright (C) 2008 Novell, Inc. # This file and all modifications and additions to the pristine @@ -18,7 +18,7 @@ Group: System/Management Autoreqprov: on Version: 1.01 -Release: 19 +Release: 20 Source: %{name}-%{version}.tar.gz Summary: Support Troubleshooting Tools BuildRoot: %{_tmppath}/%{name}-%{version}-build ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... -- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org