Hello community, here is the log from the commit of package dmxviewer checked in at Thu Oct 16 01:21:05 CEST 2008. -------- --- dmxviewer/dmxviewer.changes 2008-09-02 22:55:50.000000000 +0200 +++ /d/STABLE/dmxviewer/dmxviewer.changes 2008-10-15 17:56:24.000000000 +0200 @@ -1,0 +2,6 @@ +Wed Oct 15 11:45:55 EDT 2008 - davidr@novell.com + +- Fix bad window title name when using -direct option. +- Don't prevent XDND support from working properly. + +------------------------------------------------------------------- calling whatdependson for head-i586 New: ---- dmxviewer.diff ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ dmxviewer.spec ++++++ --- /var/tmp/diff_new_pack.M10396/_old 2008-10-16 01:20:52.000000000 +0200 +++ /var/tmp/diff_new_pack.M10396/_new 2008-10-16 01:20:52.000000000 +0200 @@ -23,10 +23,11 @@ Requires: openssh Summary: DMX viewer Version: 0.1.5 -Release: 2 +Release: 3 License: X11/MIT Group: System/X11/Utilities Source: %{name}-%{version}.tar.bz2 +Patch: dmxviewer.diff BuildRoot: %{_tmppath}/%{name}-%{version}-build %description @@ -36,6 +37,7 @@ %prep %setup +%patch -p1 %build autoreconf -f -i @@ -54,5 +56,8 @@ %{_bindir}/dmxviewer %changelog +* Wed Oct 15 2008 davidr@novell.com +- Fix bad window title name when using -direct option. +- Don't prevent XDND support from working properly. * Tue Sep 02 2008 hfiguiere@suse.de - Initial release. ++++++ dmxviewer.diff ++++++ diff --git a/src/dmxviewer.c b/src/dmxviewer.c index 250543d..84e2959 100644 --- a/src/dmxviewer.c +++ b/src/dmxviewer.c @@ -58,10 +58,11 @@ main (int argc, char **argv) xcb_auth_info_t *auth; xcb_screen_t *s; xcb_generic_event_t *e; - xcb_intern_atom_cookie_t dmx_name = { 0 }; + xcb_intern_atom_cookie_t xdnd_proxy = { 0 }; + xcb_intern_atom_cookie_t dmx_root = { 0 }; xcb_intern_atom_cookie_t wm_state = { 0 }; xcb_intern_atom_cookie_t wm_state_fullscreen = { 0 }; - xcb_intern_atom_reply_t *dmx_name_rep; + xcb_intern_atom_reply_t *dmx_atom_rep; uint32_t mask; uint32_t values[2]; char *dmx_displayname = NULL; @@ -78,6 +79,7 @@ main (int argc, char **argv) char *ssh_tunnel = "-oForwardX11=yes"; char *ssh_trusted = "-oForwardX11Trusted=yes"; char connect_command[1024]; + char title[1024]; char *viewonly = ""; char *name = NULL; char *display; @@ -265,10 +267,15 @@ main (int argc, char **argv) XCB_EVENT_MASK_SUBSTRUCTURE_NOTIFY | XCB_EVENT_MASK_STRUCTURE_NOTIFY; - dmx_name = xcb_intern_atom (c, + xdnd_proxy = xcb_intern_atom (c, + 0, + strlen ("XdndProxy"), + "XdndProxy"); + + dmx_root = xcb_intern_atom (c, 0, - strlen ("DMX_NAME"), - "DMX_NAME"); + strlen ("DMX_ROOT"), + "DMX_ROOT"); if (fullscreen) { @@ -428,37 +435,46 @@ main (int argc, char **argv) xcb_disconnect (c); return 1; } + + sprintf (title, "%s:%d", dmx_host, dmx_display); + + xcb_change_property (c, + XCB_PROP_MODE_REPLACE, + w, + WM_NAME, + STRING, + 8, + strlen (title), + title); - dmx_name_rep = xcb_intern_atom_reply (c, dmx_name, NULL); - if (dmx_name_rep) + dmx_atom_rep = xcb_intern_atom_reply (c, xdnd_proxy, NULL); + if (dmx_atom_rep) { - xcb_get_property_reply_t *prop_rep; - - prop_rep = - xcb_get_property_reply (c, - xcb_get_property (c, - 0, - w, - dmx_name_rep->atom, - STRING, - 0, - 1024), - NULL); - if (prop_rep) - { - xcb_change_property (c, - XCB_PROP_MODE_REPLACE, - w, - WM_NAME, - STRING, - 8, - xcb_get_property_value_length (prop_rep), - xcb_get_property_value (prop_rep)); - - free (prop_rep); - } + xcb_change_property (c, + XCB_PROP_MODE_REPLACE, + w, + dmx_atom_rep->atom, + WINDOW, + 32, + 1, + &root); + + free (dmx_atom_rep); + } - free (dmx_name_rep); + dmx_atom_rep = xcb_intern_atom_reply (c, dmx_root, NULL); + if (dmx_atom_rep) + { + xcb_change_property (c, + XCB_PROP_MODE_REPLACE, + w, + dmx_atom_rep->atom, + WINDOW, + 32, + 1, + &root); + + free (dmx_atom_rep); } if (fullscreen) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... -- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org