Hello community, here is the log from the commit of package wavemon checked in at Thu Oct 9 20:03:52 CEST 2008. -------- --- wavemon/wavemon.changes 2007-04-05 09:56:17.000000000 +0200 +++ /mounts/work_src_done/STABLE/wavemon/wavemon.changes 2008-10-08 16:20:56.912035000 +0200 @@ -1,0 +2,5 @@ +Wed Oct 8 16:18:06 CEST 2008 - lmuelle@suse.de + +- Fix ordered comparison of pointer with integer zero; (bnc#433389). + +------------------------------------------------------------------- calling whatdependson for head-i586 New: ---- pointer-comparison.diff ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ wavemon.spec ++++++ --- /var/tmp/diff_new_pack.N26821/_old 2008-10-09 20:03:44.000000000 +0200 +++ /var/tmp/diff_new_pack.N26821/_new 2008-10-09 20:03:44.000000000 +0200 @@ -1,29 +1,38 @@ # # spec file for package wavemon (Version 0.4.0b) # -# Copyright (c) 2007 SUSE LINUX Products GmbH, Nuernberg, Germany. -# This file and all modifications and additions to the pristine -# package are under the same license as the package itself. +# Copyright (c) 2008 SUSE LINUX Products GmbH, Nuernberg, Germany. # +# All modifications and additions to the file contributed by third parties +# remain the property of their copyright owners, unless otherwise agreed +# upon. The license for this file, and modifications and additions to the +# file, is the same license as for the pristine package itself (unless the +# license for the pristine package is not an Open Source License, in which +# case the license is the MIT License). An "Open Source License" is a +# license that conforms to the Open Source Definition (Version 1.9) +# published by the Open Source Initiative. + # Please submit bugfixes or comments via http://bugs.opensuse.org/ # # norootforbuild + Name: wavemon BuildRequires: ncurses-devel Version: 0.4.0b -Release: 179 -License: GNU General Public License (GPL) +Release: 273 +License: GPL v2 or later Group: Productivity/Networking/Diagnostic -URL: http://www.wavemage.com/projects.html -Autoreqprov: on +Url: http://www.wavemage.com/projects.html +AutoReqProv: on Summary: ncurses-based monitoring application for wireless network devices Source: http://www.wavemage.com/%{name}-%{version}.tar.bz2 Patch: wavemon.c.diff Patch1: wavemon-optflags.diff Patch2: wavemon-fixes.diff Patch3: wavemon-include.diff +Patch4: pointer-comparison.diff BuildRoot: %{_tmppath}/%{name}-%{version}-build %description @@ -46,6 +55,7 @@ %patch1 -p1 %patch2 -p1 %patch3 -p1 +%patch4 -p1 %build %{?suse_update_config:%{suse_update_config -f}} @@ -77,16 +87,18 @@ %{_datadir}/man/man5/wavemonrc.5.gz %changelog -* Thu Apr 05 2007 - ssommer@suse.de +* Wed Oct 08 2008 lmuelle@suse.de +- Fix ordered comparison of pointer with integer zero; (bnc#433389). +* Thu Apr 05 2007 ssommer@suse.de - added ncurses-devel to BuildRequires - fixed includes for newer kernel headers -* Sat Nov 11 2006 - aj@suse.de +* Sat Nov 11 2006 aj@suse.de - Fix permissions on man pages. -* Wed Jan 25 2006 - mls@suse.de +* Wed Jan 25 2006 mls@suse.de - converted neededforbuild to BuildRequires -* Mon Oct 31 2005 - dmueller@suse.de +* Mon Oct 31 2005 dmueller@suse.de - don't build as root -* Sun Feb 06 2005 - meissner@suse.de +* Mon Feb 07 2005 meissner@suse.de - truly use rpm_opt_flags, fixed warnings and gcc4 compile problems. -* Thu Apr 17 2003 - lmuelle@suse.de +* Thu Apr 17 2003 lmuelle@suse.de - inital SuSE RPM ++++++ pointer-comparison.diff ++++++ Author: Lars Mueller <lmuelle at suse dot de> Subject: ordered comparison of pointer with integer zero Bugzilla: bnc 433389 Fixed upstream: no Reported upstream: no Index: wavemon-0.4.0b/conf.c =================================================================== --- wavemon-0.4.0b.orig/conf.c +++ wavemon-0.4.0b/conf.c @@ -517,7 +517,7 @@ void write_cf() } } - if ((fd = fopen(cfname, "w")) < 0) fatal_error("cannot open %s", cfname); + if ((fd = fopen(cfname, "w")) == NULL) fatal_error("cannot open %s", cfname); ll_reset(cfld); while ((lp = ll_getall(cfld))) fputs(lp, fd); fclose(fd); Index: wavemon-0.4.0b/iw_if.c =================================================================== --- wavemon-0.4.0b.orig/iw_if.c +++ wavemon-0.4.0b/iw_if.c @@ -134,7 +134,7 @@ void low_signal() * get console... no permissions? okay, take stdout * instead and pray */ - if ((fd = open("/dev/console", O_WRONLY)) < 0) fd = 1; + if ((fd = open("/dev/console", O_WRONLY)) == NULL) fd = 1; if (ioctl(fd, KIOCSOUND, 1491) >= 0) { usleep(50000); @@ -394,7 +394,7 @@ int iw_getstat(char *ifname, struct iw_s static float avg_signal = 0, avg_noise = 0; char *lp; - if ((fd = fopen("/proc/net/wireless", "r")) < 0) fatal_error("cannot open /proc/net/wireless"); + if ((fd = fopen("/proc/net/wireless", "r")) == NULL) fatal_error("cannot open /proc/net/wireless"); while (fgets(tmp, 0x100, fd)) { lp = tmp + strspn(tmp, " "); Index: wavemon-0.4.0b/net_if.c =================================================================== --- wavemon-0.4.0b.orig/net_if.c +++ wavemon-0.4.0b/net_if.c @@ -61,7 +61,7 @@ void if_getstat(char *ifname, struct if_ unsigned long d; char *lp; - if ((fd = fopen("/proc/net/dev", "r")) < 0) { + if ((fd = fopen("/proc/net/dev", "r")) == NULL) { fprintf(stderr, "fatal error: cannot open /proc/net/dev\n"); exit(-1); } ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... -- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org