commit compartm

Hello community, here is the log from the commit of package compartm checked in at Fri Sep 5 22:17:01 CEST 2008. -------- --- compartm/compartm.changes 2008-04-29 18:50:48.000000000 +0200 +++ compartm/compartm.changes 2008-09-03 17:13:01.000000000 +0200 @@ -1,0 +2,13 @@ +Wed Sep 3 17:11:49 CEST 2008 - draht@suse.de + +- arg from va_start(arg, format) can only be used once. Use + va_copy(). + +------------------------------------------------------------------- +Wed Sep 3 16:46:34 CEST 2008 - draht@suse.de + +- remove the precompiled binary from the tarball. +- extern char **environ should be NULL terminated, "" is not NULL. + Cause for weird crashes in malloc(), getpwuid() and others. + +------------------------------------------------------------------- New: ---- compartment-1.1-envp.dif compartment-1.1-va_copy.dif ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ compartm.spec ++++++ --- /var/tmp/diff_new_pack.xp8081/_old 2008-09-05 22:16:32.000000000 +0200 +++ /var/tmp/diff_new_pack.xp8081/_new 2008-09-05 22:16:32.000000000 +0200 @@ -2,9 +2,16 @@ # spec file for package compartm (Version 1.1) # # Copyright (c) 2008 SUSE LINUX Products GmbH, Nuernberg, Germany. -# This file and all modifications and additions to the pristine -# package are under the same license as the package itself. # +# All modifications and additions to the file contributed by third parties +# remain the property of their copyright owners, unless otherwise agreed +# upon. The license for this file, and modifications and additions to the +# file, is the same license as for the pristine package itself (unless the +# license for the pristine package is not an Open Source License, in which +# case the license is the MIT License). An "Open Source License" is a +# license that conforms to the Open Source Definition (Version 1.9) +# published by the Open Source Initiative. + # Please submit bugfixes or comments via http://bugs.opensuse.org/ # @@ -12,7 +19,7 @@ Name: compartm Version: 1.1 -Release: 409 +Release: 436 License: GPL v2 or later Group: Productivity/Security AutoReqProv: on @@ -23,6 +30,8 @@ Patch2: compartment-%version-nochown.patch Patch3: compartment-%version-format.dif Patch4: compartment-%version-newcaps.dif +Patch5: compartment-%version-envp.dif +Patch6: compartment-%version-va_copy.dif BuildRoot: %{_tmppath}/%{name}-%{version}-build %description @@ -46,6 +55,8 @@ %patch2 %patch3 %patch4 +%patch5 +%patch6 %build make @@ -66,6 +77,13 @@ /usr/sbin/compartment %changelog +* Wed Sep 03 2008 draht@suse.de +- arg from va_start(arg, format) can only be used once. Use + va_copy(). +* Wed Sep 03 2008 draht@suse.de +- remove the precompiled binary from the tarball. +- extern char **environ should be NULL terminated, "" is not NULL. + Cause for weird crashes in malloc(), getpwuid() and others. * Tue Apr 29 2008 mt@suse.de - Updated cap no/name array to reflect current capabilities - Fixed to use correct printf format for a size_t type ++++++ compartment-1.1-envp.dif ++++++ diff -rU 10 ../compartment-1.1.orig/compartment.c ./compartment.c --- ../compartment-1.1.orig/compartment.c 2008-09-03 16:43:48.000000000 +0200 +++ ./compartment.c 2008-09-03 16:44:52.000000000 +0200 @@ -36,21 +36,21 @@ #include #include #include #define PROGRAM_NAME "SuSE secure compartment" #define VERSION "v1.1" #define AUTHOR "Marc Heuse " #define POINTER "http://www.suse.de/~marc" #define LOGBUF 5000 -char *_env[] = { "HOME=/", "COMPARTMENT=YES", "PATH=/bin:/usr/bin:/", "" }; +char *_env[] = { "HOME=/", "COMPARTMENT=YES", "PATH=/bin:/usr/bin:/", NULL }; #ifndef CAP_TO_MASK #define CAP_TO_MASK(x) (1 << ((x) & 31)) #endif int cap_set_no[] = { CAP_CHOWN,CAP_DAC_OVERRIDE,CAP_DAC_READ_SEARCH,CAP_FOWNER,CAP_FSETID, CAP_KILL,CAP_SETGID,CAP_SETUID,CAP_SETPCAP,CAP_LINUX_IMMUTABLE, CAP_NET_BIND_SERVICE,CAP_NET_BROADCAST,CAP_NET_ADMIN,CAP_NET_RAW, CAP_IPC_LOCK,CAP_IPC_OWNER,CAP_SYS_MODULE,CAP_SYS_RAWIO,CAP_SYS_CHROOT, CAP_SYS_PTRACE,CAP_SYS_PACCT,CAP_SYS_ADMIN,CAP_SYS_BOOT,CAP_SYS_NICE, ++++++ compartment-1.1.tar.gz ++++++ Files old/compartment-1.1/compartment and new/compartment-1.1/compartment differ ++++++ compartment-1.1-va_copy.dif ++++++ diff -rU 10 ../compartment-1.1.orig/compartment.c ./compartment.c --- ../compartment-1.1.orig/compartment.c 2008-09-03 16:43:48.000000000 +0200 +++ ./compartment.c 2008-09-05 11:19:57.000000000 +0200 @@ -93,29 +93,31 @@ "files to another user than root if you use capabilties. Read the README file!\n" "\nKnown capset names: none"); tmp = 0; while(strlen(cap_set_names[tmp])>0) fprintf(stderr," %s",cap_set_names[tmp++]); fprintf(stderr, " (see linux/capability.h for more information)\n"); exit(-1); } void print_msg(const char *format, ...) { - va_list arg; + va_list arg, arg_copy; char *log; if (quiet == 0) { log = malloc(LOGBUF); va_start(arg, format); + va_copy(arg_copy, arg); vfprintf(stderr, format, arg); - vsnprintf(log, LOGBUF, format, arg); + vsnprintf(log, LOGBUF, format, arg_copy); syslog(LOG_NOTICE, log); va_end(arg); + va_end(arg_copy); free(log); } } void my_secure() { char file[10] = "/dev/null"; int mode = O_RDWR; alarm(0); if (verbose) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org