Hello community, here is the log from the commit of package qtcurve-kde4 checked in at Mon May 5 01:03:20 CEST 2008. -------- --- KDE/qtcurve-kde4/qtcurve-kde4.changes 2008-04-28 11:32:24.000000000 +0200 +++ /mounts/work_src_done/STABLE/qtcurve-kde4/qtcurve-kde4.changes 2008-05-02 23:12:55.000000000 +0200 @@ -1,0 +2,5 @@ +Fri May 2 23:12:41 CEST 2008 - dmueller@suse.de + +- fix crash on destructing progressbars (bnc#384177) + +------------------------------------------------------------------- New: ---- progressbar-leak.diff ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ qtcurve-kde4.spec ++++++ --- /var/tmp/diff_new_pack.C28157/_old 2008-05-05 01:03:16.000000000 +0200 +++ /var/tmp/diff_new_pack.C28157/_new 2008-05-05 01:03:16.000000000 +0200 @@ -18,10 +18,11 @@ Group: System/GUI/KDE Summary: QtCurve style for KDE 4 Version: 0.59.0 -Release: 3 +Release: 7 BuildRoot: %{_tmppath}/%{name}-%{version}-build Source0: QtCurve-KDE4-%{version}.tar.bz2 Patch0: buffer-overflow-fix.diff +Patch1: progressbar-leak.diff %description This is the QtCurve style for KDE 4. QtCurve is available for both @@ -36,6 +37,7 @@ %prep %setup -q -n QtCurve-KDE4-%{version} %patch0 +%patch1 %build %cmake_kde4 -d build @@ -61,6 +63,8 @@ %_kde_share_dir/apps/color-schemes/QtCurve.colors %changelog +* Sat May 03 2008 dmueller@suse.de +- fix crash on destructing progressbars (bnc#384177) * Mon Apr 28 2008 dmueller@suse.de - add buffer overflow fix here as well * Thu Apr 24 2008 stbinner@suse.de ++++++ progressbar-leak.diff ++++++ --- style/qtcurve.cpp +++ style/qtcurve.cpp @@ -1184,9 +1184,11 @@ itsHoverWidget=NULL; } - if(bar && !itsProgressBars.isEmpty()) + // if called from ::Destroy, the qobject_cast above already + // failed, so we have to chech on object + if(object && !itsProgressBars.isEmpty()) { - itsProgressBars.removeAll(bar); + itsProgressBars.removeAll((QProgressBar*)object); if (itsProgressBars.isEmpty()) { killTimer(itsProgressBarAnimateTimer); ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org