Hello community,
here is the log from the commit of package pam_cifs
checked in at Thu Apr 3 10:54:27 CEST 2008.
--------
--- pam_cifs/pam_cifs.changes 2008-01-15 15:11:24.000000000 +0100
+++ /mounts/work_src_done/STABLE/pam_cifs/pam_cifs.changes 2008-04-03 10:24:19.942140000 +0200
@@ -1,0 +2,6 @@
+Thu Apr 3 10:21:00 CEST 2008 - mc@suse.de
+
+- update to version 0.5.5
+- some build fixes from upstream
+
+-------------------------------------------------------------------
Old:
----
pam_cifs-0.5.1-cflags.patch
pam-cifs-0.5.4.tar.bz2
New:
----
pam-cifs-0.5.5.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ pam_cifs.spec ++++++
--- /var/tmp/diff_new_pack.p10432/_old 2008-04-03 10:54:15.000000000 +0200
+++ /var/tmp/diff_new_pack.p10432/_new 2008-04-03 10:54:15.000000000 +0200
@@ -1,5 +1,5 @@
#
-# spec file for package pam_cifs (Version 0.5.4)
+# spec file for package pam_cifs (Version 0.5.5)
#
# Copyright (c) 2008 SUSE LINUX Products GmbH, Nuernberg, Germany.
# This file and all modifications and additions to the pristine
@@ -10,17 +10,17 @@
# norootforbuild
+
Name: pam_cifs
BuildRequires: openldap2-devel pam-devel
License: GPL v2 or later
Group: Productivity/Security
AutoReqProv: on
-Version: 0.5.4
+Version: 0.5.5
Release: 1
Summary: PAM module for mount/umount CIFS shares
Url: http://sourceforge.net/projects/pam-cifs
Source: pam-cifs-%{version}.tar.bz2
-Patch0: pam_cifs-0.5.1-cflags.patch
BuildRoot: %{_tmppath}/%{name}-%{version}-build
Requires: pam
@@ -38,7 +38,6 @@
%prep
%setup -q -n pam-cifs
-%patch0
%build
make OPTFLAGS="$RPM_OPT_FLAGS"
@@ -60,6 +59,9 @@
%attr(555,root,root)/%{_sbindir}/cifsumountd
%changelog
+* Thu Apr 03 2008 mc@suse.de
+- update to version 0.5.5
+- some build fixes from upstream
* Tue Jan 15 2008 lmuelle@suse.de
- update to version 0.5.4
- minor fix in pam_open_sesion
++++++ pam-cifs-0.5.4.tar.bz2 -> pam-cifs-0.5.5.tar.bz2 ++++++
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/pam-cifs/ChangeLog new/pam-cifs/ChangeLog
--- old/pam-cifs/ChangeLog 2007-09-12 20:16:26.000000000 +0200
+++ new/pam-cifs/ChangeLog 2008-01-15 21:41:52.000000000 +0100
@@ -1,3 +1,10 @@
+* Head
+** Makefile OPTFLAGS
+ Thanks to Lars Mueller, SuSe GmbH
+
+* Version 0.54
+** fixed memory leak
+
* Version 0.53
** annoying bug in makefile
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/pam-cifs/debian/cifsumount.init new/pam-cifs/debian/cifsumount.init
--- old/pam-cifs/debian/cifsumount.init 2007-09-18 21:37:15.000000000 +0200
+++ new/pam-cifs/debian/cifsumount.init 2007-10-30 19:00:16.000000000 +0100
@@ -1,6 +1,6 @@
#! /bin/sh
#
-# $Id: cifsumount.init,v 1.2 2007/09/18 19:37:15 wimalopaan Exp $
+# $Id: cifsumount.init,v 1.3 2007/10/30 18:00:16 wimalopaan Exp $
#
### BEGIN INIT INFO
@@ -15,8 +15,8 @@
set -e
-NAME=cifsumountd
-DAEMON=/usr/sbin/$NAME
+NAME=cifsumount
+DAEMON=/usr/sbin/${NAME}d
PIDFILE=/var/run/$NAME.pid
DESC="cifsumountd"
DAEMON_START=1
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/pam-cifs/ldap.c new/pam-cifs/ldap.c
--- old/pam-cifs/ldap.c 2007-09-21 22:03:06.000000000 +0200
+++ new/pam-cifs/ldap.c 2008-01-15 21:39:33.000000000 +0100
@@ -1,5 +1,5 @@
/*
- * $Header: /cvsroot/pam-cifs/pam-cifs/ldap.c,v 1.5 2007/09/21 20:03:06 wimalopaan Exp $
+ * $Header: /cvsroot/pam-cifs/pam-cifs/ldap.c,v 1.6 2008/01/15 20:39:33 wimalopaan Exp $
*
* pam_cifs - Linux-PAM module for mount/umount CIFS shares
* Copyright (C) 2005 Wilhelm Meier (meier@informatik.fh-kl.de)
@@ -29,6 +29,7 @@
#include "pam_ldap.h"
#include
+#include
extern struct options pam_cifs_options;
@@ -55,7 +56,7 @@
char* ldap_source(pam_handle_t* pamh, const char* user, const char* attribute) {
int opt_value;
- pam_ldap_session_t *pam_ldap_session;
+ pam_ldap_session_t *pam_ldap_session = NULL;
char filter[PATH_MAX];
char *base;
@@ -158,6 +159,7 @@
}
else {
slog("using pam_ldap_connection\n");
+ assert(pam_ldap_session != NULL);
snprintf(filter, PATH_MAX, "(&(ObjectClass=%s)(%s=%s))",
pam_cifs_options.ldapobjectclass,
pam_ldap_session->conf->userattr, user);
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/pam-cifs/Makefile new/pam-cifs/Makefile
--- old/pam-cifs/Makefile 2007-09-12 15:01:54.000000000 +0200
+++ new/pam-cifs/Makefile 2008-01-15 21:48:28.000000000 +0100
@@ -1,4 +1,4 @@
-# $Header: /cvsroot/pam-cifs/pam-cifs/Makefile,v 1.19 2007/09/12 13:01:54 wimalopaan Exp $
+# $Header: /cvsroot/pam-cifs/pam-cifs/Makefile,v 1.21 2008/01/15 20:48:28 wimalopaan Exp $
#
# pam_cifs - Linux-PAM module for mount/umount CIFS shares
#
@@ -20,7 +20,8 @@
#
CC=gcc
-CFLAGS += -g -Wall -pedantic -std=c99 -fPIC
+OPTFLAGS = -O2
+CFLAGS += $(OPTFLAGS) -g -Wall -pedantic -std=c99 -fPIC -fno-strict-aliasing
CFLAGS += -DDEFAULT_PATH_PREFIX='"/Home"'
CFLAGS += -DDEFAULT_PATH_SUFFIX='""'
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/pam-cifs/mount.cifs.c new/pam-cifs/mount.cifs.c
--- old/pam-cifs/mount.cifs.c 2007-09-09 12:10:19.000000000 +0200
+++ new/pam-cifs/mount.cifs.c 2008-01-15 21:46:27.000000000 +0100
@@ -662,7 +662,7 @@
char * ipaddress_string = NULL;
struct hostent * host_entry;
struct in_addr server_ipaddr;
- int rc;
+ int rc = 0;
if(length > 1023) {
printf("mount error: UNC name too long");
@@ -1078,7 +1078,7 @@
memset(mountpassword,0,64);
}
//
- // this is uses for pam-cifs
+ // this is used for pam-cifs
//
return -errno;
} else {
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/pam-cifs/pam_cifs.c new/pam-cifs/pam_cifs.c
--- old/pam-cifs/pam_cifs.c 2007-08-23 13:31:33.000000000 +0200
+++ new/pam-cifs/pam_cifs.c 2007-12-16 00:09:24.000000000 +0100
@@ -1,5 +1,5 @@
/*
- * $Header: /cvsroot/pam-cifs/pam-cifs/pam_cifs.c,v 1.5 2007/08/23 11:31:33 wimalopaan Exp $
+ * $Header: /cvsroot/pam-cifs/pam-cifs/pam_cifs.c,v 1.6 2007/12/15 23:09:24 wimalopaan Exp $
*
* pam_cifs - Linux-PAM module for mount/umount CIFS shares
* Copyright (C) 2005 Wilhelm Meier (meier@informatik.fh-kl.de)
@@ -24,6 +24,12 @@
extern struct options pam_cifs_options;
+void pam_cifs_pamh_cleanup(pam_handle_t *pamh, void* data, int pam_end_status) {
+ if (data != NULL) {
+ free(data);
+ }
+}
+
PAM_EXTERN
int pam_sm_authenticate(pam_handle_t *pamh,int flags,int argc ,const char **argv) {
// this function does not do any authentication itself. The only
@@ -90,10 +96,9 @@
slog("setting authtok: %s\n", pam_strerror(pamh, retval));
return retval;
}
- // since we use strdup() we have to free it in the
- // open_session section
+ // cleanup needed
if ((retval = pam_set_data(pamh, PAM_CIFS_AUTHTOK,
- strdup(resp[0].resp), NULL)) != PAM_SUCCESS) {
+ strdup(resp[0].resp), pam_cifs_pamh_cleanup)) != PAM_SUCCESS) {
slog("pam_set_item: %s\n", pam_strerror(pamh, retval));
return retval;
}
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/pam-cifs/pam_sm_open_session.c new/pam-cifs/pam_sm_open_session.c
--- old/pam-cifs/pam_sm_open_session.c 2007-09-25 14:04:41.000000000 +0200
+++ new/pam-cifs/pam_sm_open_session.c 2007-12-16 00:09:07.000000000 +0100
@@ -1,5 +1,5 @@
/*
- * $Header: /cvsroot/pam-cifs/pam-cifs/pam_sm_open_session.c,v 1.16 2007/09/25 12:04:41 wimalopaan Exp $
+ * $Header: /cvsroot/pam-cifs/pam-cifs/pam_sm_open_session.c,v 1.17 2007/12/15 23:09:07 wimalopaan Exp $
*
* pam_cifs - Linux-PAM module for mount/umount CIFS shares
* Copyright (C) 2005 Wilhelm Meier (meier@informatik.fh-kl.de)
@@ -26,7 +26,7 @@
extern struct options pam_cifs_options;
static struct sigaction nsa, osa;
-static int needtofreeauthtok = 0;
+//static int needtofreeauthtok = 0;
static char *authtok=NULL;
#ifdef NO_PAM_MODULE
@@ -51,9 +51,6 @@
if (sigaction(SIGPIPE, &osa, NULL) < 0) {
slog("sigaction: %s", strerror(errno));
}
- if (needtofreeauthtok > 0) {
- free(authtok);
- }
}
PAM_EXTERN
@@ -127,7 +124,6 @@
return cleanup(PAM_CRED_INSUFFICIENT);
}
slog("... got local\n");
- needtofreeauthtok = 1;
}
#endif
if (authtok == NULL) {
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/pam-cifs/TODO new/pam-cifs/TODO
--- old/pam-cifs/TODO 2007-09-18 11:15:59.000000000 +0200
+++ new/pam-cifs/TODO 2007-09-26 16:57:29.000000000 +0200
@@ -3,13 +3,13 @@
* make pam-cifs.so and cifsumountd use the same config
(perhaps transfer the config from pam_cifs to cifsumountd)
+* if multiple pam_cifs-instances are used let cifsumountd catch them all
+
* make sure pam_ldap and pam_cifs work together (over the pam_stack: pam_cifs actally uses the
ldap connection of pam_ldap)
* evaluate errors from mount.cifs
-* multiple tries to mount if error
-
* pam-conversation with error-message if something is wrong
* make use of ldaps
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Remember to have fun...
---------------------------------------------------------------------
To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org
For additional commands, e-mail: opensuse-commit+help@opensuse.org