Hello community, here is the log from the commit of package perl-DBI checked in at Wed Mar 26 14:06:27 CET 2008. -------- --- perl-DBI/perl-DBI.changes 2008-03-24 16:42:28.000000000 +0100 +++ /mounts/work_src_done/STABLE/perl-DBI/perl-DBI.changes 2008-03-26 13:37:40.000000000 +0100 @@ -1,0 +2,7 @@ +Wed Mar 26 13:28:43 CET 2008 - anicka@suse.cz + +- update to 1.604 + * Fixed fetchall_arrayref with $max_rows argument broken + in 1.603 + +------------------------------------------------------------------- Old: ---- DBI-1.603.tar.bz2 perl-DBI-1.603-dbis.diff New: ---- DBI-1.604.tar.bz2 perl-DBI-1.604-dbis.diff ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ perl-DBI.spec ++++++ --- /var/tmp/diff_new_pack.E10911/_old 2008-03-26 13:49:11.000000000 +0100 +++ /var/tmp/diff_new_pack.E10911/_new 2008-03-26 13:49:11.000000000 +0100 @@ -1,5 +1,5 @@ # -# spec file for package perl-DBI (Version 1.603) +# spec file for package perl-DBI (Version 1.604) # # Copyright (c) 2008 SUSE LINUX Products GmbH, Nuernberg, Germany. # This file and all modifications and additions to the pristine @@ -13,7 +13,7 @@ Name: perl-DBI BuildRequires: perl-Curses -Version: 1.603 +Version: 1.604 Release: 1 Requires: perl = %{perl_version} Requires: perl-PlRPC @@ -73,6 +73,10 @@ /var/adm/perl-modules/%{name} %changelog +* Wed Mar 26 2008 anicka@suse.cz +- update to 1.604 + * Fixed fetchall_arrayref with $max_rows argument broken + in 1.603 * Mon Mar 24 2008 anicka@suse.cz - update to 1.603 * Fixed pure-perl fetchall_arrayref with $max_rows argument ++++++ DBI-1.603.tar.bz2 -> DBI-1.604.tar.bz2 ++++++ diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/DBI-1.603/Changes new/DBI-1.604/Changes --- old/DBI-1.603/Changes 2008-03-22 00:54:47.000000000 +0100 +++ new/DBI-1.604/Changes 2008-03-24 15:06:50.000000000 +0100 @@ -2,7 +2,7 @@ DBI::Changes - List of significant changes to the DBI -(As of $Date: 2008-03-13 14:54:58 +0000 (Thu, 13 Mar 2008) $ $Revision: 10918 $) +(As of $Date: 2008-03-24 14:06:48 +0000 (Mon, 24 Mar 2008) $ $Revision: 10994 $) =cut @@ -40,6 +40,12 @@ Call method on transport failure so transport can cleanup/reset if it wants Gofer: gearman - need to disable coallesing for non-idempotent requests +=head2 Changes in DBI 1.604 (svn rev 10994) 24th March 2008 + + Fixed fetchall_arrayref with $max_rows argument broken in 1.603, + thanks to Greg Sabino Mullane. + Fixed a few harmless compiler warnings on cygwin. + =head2 Changes in DBI 1.603 Fixed pure-perl fetchall_arrayref with $max_rows argument diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/DBI-1.603/DBI.pm new/DBI-1.604/DBI.pm --- old/DBI-1.603/DBI.pm 2008-03-13 15:54:59.000000000 +0100 +++ new/DBI-1.604/DBI.pm 2008-03-24 15:06:50.000000000 +0100 @@ -1,4 +1,4 @@ -# $Id: DBI.pm 10918 2008-03-13 14:54:58Z timbo $ +# $Id: DBI.pm 10994 2008-03-24 14:06:48Z timbo $ # vim: ts=8:sw=4 # # Copyright (c) 1994-2007 Tim Bunce Ireland @@ -9,7 +9,7 @@ require 5.006_00; BEGIN { -$DBI::VERSION = "1.603"; # ==> ALSO update the version in the pod text below! +$DBI::VERSION = "1.604"; # ==> ALSO update the version in the pod text below! } =head1 NAME @@ -121,8 +121,8 @@ =head2 NOTES -This is the DBI specification that corresponds to the DBI version 1.603 -($Revision: 10918 $). +This is the DBI specification that corresponds to the DBI version 1.604 +($Revision: 10994 $). The DBI is evolving at a steady pace, so it's good to check that you have the latest copy. @@ -1953,7 +1953,7 @@ # when batch fetching with $max_rows were very likely to try to # fetch the 'next batch' after the previous batch returned # <=$max_rows. So don't treat that as an error. - return undef if $max_rows and not $sth->{Active}; + return undef if $max_rows and not $sth->FETCH('Active'); my $mode = ref($slice) || 'ARRAY'; my @rows; diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/DBI-1.603/DBI.xs new/DBI-1.604/DBI.xs --- old/DBI-1.603/DBI.xs 2008-03-13 15:29:10.000000000 +0100 +++ new/DBI-1.604/DBI.xs 2008-03-24 14:44:38.000000000 +0100 @@ -1,6 +1,6 @@ /* vim: ts=8:sw=4 * - * $Id: DBI.xs 10916 2008-03-13 14:29:07Z timbo $ + * $Id: DBI.xs 10993 2008-03-24 13:44:36Z timbo $ * * Copyright (c) 1994-2003 Tim Bunce Ireland. * @@ -228,15 +228,15 @@ (void)need_dbixs_cv; if (dbis_cv != DBISTATE_VERSION || dbis_cs != sizeof(*DBIS)) croak("DBI/DBD internal version mismatch (DBI is v%d/s%lu, DBD %s expected v%d/s%d) %s.\n", - DBISTATE_VERSION, sizeof(*DBIS), name, dbis_cv, dbis_cs, msg); + DBISTATE_VERSION, (long unsigned int)sizeof(*DBIS), name, dbis_cv, dbis_cs, msg); /* Catch structure size changes - We should probably force a recompile if the DBI */ /* runtime version is different from the build time. That would be harsh but safe. */ if (drc_s != sizeof(dbih_drc_t) || dbc_s != sizeof(dbih_dbc_t) || stc_s != sizeof(dbih_stc_t) || fdc_s != sizeof(dbih_fdc_t) ) - croak("%s (dr:%d/%lu, db:%d/%lu, st:%d/%lu, fd:%d/%lu), %s.\n", + croak("%s (dr:%d/%ld, db:%d/%ld, st:%d/%ld, fd:%d/%ld), %s.\n", "DBI/DBD internal structure mismatch", - drc_s, sizeof(dbih_drc_t), dbc_s, sizeof(dbih_dbc_t), - stc_s, sizeof(dbih_stc_t), fdc_s, sizeof(dbih_fdc_t), msg); + drc_s, (long)sizeof(dbih_drc_t), dbc_s, (long)sizeof(dbih_dbc_t), + stc_s, (long)sizeof(dbih_stc_t), fdc_s, (long)sizeof(dbih_fdc_t), msg); } static void diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/DBI-1.603/META.yml new/DBI-1.604/META.yml --- old/DBI-1.603/META.yml 2008-03-22 00:57:15.000000000 +0100 +++ new/DBI-1.604/META.yml 2008-03-24 15:09:11.000000000 +0100 @@ -1,6 +1,6 @@ --- #YAML:1.0 name: DBI -version: 1.603 +version: 1.604 abstract: Database independent interface for Perl license: ~ author: diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/DBI-1.603/t/10examp.t new/DBI-1.604/t/10examp.t --- old/DBI-1.603/t/10examp.t 2007-11-22 14:13:31.000000000 +0100 +++ new/DBI-1.604/t/10examp.t 2008-03-24 14:59:07.000000000 +0100 @@ -12,7 +12,7 @@ my $haveFileSpec = eval { require File::Spec }; require VMS::Filespec if $^O eq 'VMS'; -use Test::More tests => 205; +use Test::More tests => 208; # "globals" my ($r, $dbh); @@ -228,13 +228,18 @@ ok(keys %{$r->[0]} == 3); ok("@{$r->[0]}{qw(MODE SIZE NAME)}" eq "@row_a", "'@{$r->[0]}{qw(MODE SIZE NAME)}' ne '@row_a'"); -# use Data::Dumper; warn Dumper([\@row_a, $r]); - +print "rows()\n"; # assumes previous fetch fetched all rows $rows = $csr_b->rows; ok($rows > 0, "row count $rows"); ok($rows == @$r, "$rows vs ".@$r); ok($rows == $DBI::rows, "$rows vs $DBI::rows"); +print "fetchall_arrayref array slice and max rows\n"; +ok($csr_b->execute()); +$r = $csr_b->fetchall_arrayref([0], 1); +ok($r); +is_deeply($r, [[$row_a[0]]]); + # --- print "selectrow_array\n"; ++++++ perl-DBI-1.603-dbis.diff -> perl-DBI-1.604-dbis.diff ++++++ ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org