Hello community,
here is the log from the commit of package perl-Pod-Coverage
checked in at Tue Nov 20 14:59:20 CET 2007.
--------
--- perl-Pod-Coverage/perl-Pod-Coverage.changes 2006-10-20 13:38:20.000000000 +0200
+++ /mounts/work_src_done/STABLE/perl-Pod-Coverage/perl-Pod-Coverage.changes 2007-11-20 12:57:07.000000000 +0100
@@ -1,0 +2,7 @@
+Tue Nov 20 12:56:09 CET 2007 - pth@suse.de
+
+- Update to 0.19:
+ Don't use _CvGV to determine if a sub was imported, there's a handy
+ flag - GVf_IMPORTED_CV. Fixes 5.9.5 and future perls
+
+-------------------------------------------------------------------
Old:
----
Pod-Coverage-0.18.tar.bz2
New:
----
Pod-Coverage-0.19.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ perl-Pod-Coverage.spec ++++++
--- /var/tmp/diff_new_pack.Ot7285/_old 2007-11-20 14:59:07.000000000 +0100
+++ /var/tmp/diff_new_pack.Ot7285/_new 2007-11-20 14:59:07.000000000 +0100
@@ -1,7 +1,7 @@
#
-# spec file for package perl-Pod-Coverage (Version 0.18)
+# spec file for package perl-Pod-Coverage (Version 0.19)
#
-# Copyright (c) 2006 SUSE LINUX Products GmbH, Nuernberg, Germany.
+# Copyright (c) 2007 SUSE LINUX Products GmbH, Nuernberg, Germany.
# This file and all modifications and additions to the pristine
# package are under the same license as the package itself.
#
@@ -12,13 +12,13 @@
Name: perl-Pod-Coverage
BuildRequires: perl-Devel-Symdump perl-Module-Info perl-Pod-Escapes perl-Pod-Simple perl-Test-Pod perl-YAML
-URL: http://search.cpan.org/~rclamp/Pod-Coverage
-License: Artistic License, GNU General Public License (GPL) - all versions
-Group: Development/Languages/Perl
+Url: http://search.cpan.org/~rclamp/Pod-Coverage
+License: Artistic License; GPL v2 or later
+Group: Development/Libraries/Perl
Requires: perl-Devel-Symdump, perl = %{perl_version}
-Autoreqprov: on
-Summary: Check if the documentation of a module is comprehensive.
-Version: 0.18
+AutoReqProv: on
+Summary: Check if the documentation of a module is comprehensive
+Version: 0.19
Release: 1
Source: Pod-Coverage-%{version}.tar.bz2
BuildRoot: %{_tmppath}/%{name}-%{version}-build
@@ -50,6 +50,8 @@
%build
perl Makefile.PL
make
+
+%check
make test
# ---------------------------------------------------------------------------
@@ -75,7 +77,10 @@
%doc %{_mandir}/man3/*.3pm.gz
/var/adm/perl-modules/%{name}
%{_bindir}/pod_cover
-
-%changelog -n perl-Pod-Coverage
+%changelog
+* Tue Nov 20 2007 - pth@suse.de
+- Update to 0.19:
+ Don't use _CvGV to determine if a sub was imported, there's a handy
+ flag - GVf_IMPORTED_CV. Fixes 5.9.5 and future perls
* Fri Oct 20 2006 - pth@suse.de
- Initial package
++++++ Pod-Coverage-0.18.tar.bz2 -> Pod-Coverage-0.19.tar.bz2 ++++++
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/Pod-Coverage-0.18/Changes new/Pod-Coverage-0.19/Changes
--- old/Pod-Coverage-0.18/Changes 2006-08-04 15:45:58.000000000 +0200
+++ new/Pod-Coverage-0.19/Changes 2007-09-13 17:22:40.000000000 +0200
@@ -1,3 +1,9 @@
+0.19 Thursday 13th September, 2007
+ Don't use _CvGV to determine if a sub was imported, there's a handy
+ flag - GVf_IMPORTED_CV. Fixes 5.9.5 and future perls
+ (solution by Nicholas Clark)
+
+
0.18 Friday 4th August, 2006
Rewrite _CvGV in terms of B::CV - no xs dependency anymore
(suggested by Tim Bunce)
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/Pod-Coverage-0.18/lib/Pod/Coverage.pm new/Pod-Coverage-0.19/lib/Pod/Coverage.pm
--- old/Pod-Coverage-0.18/lib/Pod/Coverage.pm 2006-08-04 15:45:58.000000000 +0200
+++ new/Pod-Coverage-0.19/lib/Pod/Coverage.pm 2007-09-13 17:22:40.000000000 +0200
@@ -5,10 +5,10 @@
use B;
use Pod::Find qw(pod_where);
-BEGIN { defined &TRACE_ALL or eval 'sub TRACE_ALL () { 0 }' };
+BEGIN { defined &TRACE_ALL or eval 'sub TRACE_ALL () { 0 }' }
use vars qw/ $VERSION /;
-$VERSION = '0.18';
+$VERSION = '0.19';
=head1 NAME
@@ -123,12 +123,17 @@
qr/^( MODIFY | FETCH )_( REF | SCALAR | ARRAY | HASH | CODE |
GLOB | FORMAT | IO)_ATTRIBUTES $/x,
qr/^CLONE(_SKIP)?$/,
- ];
+ ];
push @$private, @{ $args{also_private} || [] };
- my $trustme = $args{trustme} || [];
+ my $trustme = $args{trustme} || [];
my $nonwhitespace = $args{nonwhitespace} || undef;
- my $self = bless { @_, private => $private, trustme => $trustme, nonwhitespace => $nonwhitespace }, $class;
+ my $self = bless {
+ @_,
+ private => $private,
+ trustme => $trustme,
+ nonwhitespace => $nonwhitespace
+ }, $class;
}
=item $object->coverage
@@ -137,22 +142,21 @@
=cut
-
sub coverage {
my $self = shift;
my $package = $self->{package};
- my $pods = $self->_get_pods;
+ my $pods = $self->_get_pods;
return unless $pods;
my %symbols = map { $_ => 0 } $self->_get_syms($package);
print "tying shoelaces\n" if TRACE_ALL;
- for my $pod ( @$pods ) {
+ for my $pod (@$pods) {
$symbols{$pod} = 1 if exists $symbols{$pod};
}
- foreach my $sym (keys %symbols) {
+ foreach my $sym ( keys %symbols ) {
$symbols{$sym} = 1 if $self->_trustme_check($sym);
}
@@ -164,8 +168,8 @@
print Data::Dumper::Dumper($self);
}
- my $symbols = scalar keys %symbols;
- my $documented = scalar grep { $_ } values %symbols;
+ my $symbols = scalar keys %symbols;
+ my $documented = scalar grep {$_} values %symbols;
unless ($symbols) {
$self->{why_unrated} = "no public symbols defined";
return;
@@ -183,10 +187,9 @@
sub why_unrated {
my $self = shift;
- $self->{why_unrated}
+ $self->{why_unrated};
}
-
=item $object->naked/$object->uncovered
Returns a list of uncovered routines, will implicitly call coverage if
@@ -226,19 +229,19 @@
return unless @_;
# one argument - just a package
- scalar @_ == 1 and unshift @_, 'package';
+ scalar @_ == 1 and unshift @_, 'package';
# we were called with arguments
my $pc = $self->new(@_);
my $rating = $pc->coverage;
- $rating = 'unrated ('. $pc->why_unrated .')'
- unless defined $rating;
+ $rating = 'unrated (' . $pc->why_unrated . ')'
+ unless defined $rating;
print $pc->{package}, " has a $self rating of $rating\n";
my @looky_here = $pc->naked;
if ( @looky_here > 1 ) {
- print "The following are uncovered: ", join(", ", sort @looky_here), "\n";
- }
- elsif (@looky_here) {
+ print "The following are uncovered: ", join( ", ", sort @looky_here ),
+ "\n";
+ } elsif (@looky_here) {
print "'$looky_here[0]' is uncovered\n";
}
}
@@ -306,10 +309,14 @@
my @symbols;
for my $sym ( $syms->functions ) {
+
# see if said method wasn't just imported from elsewhere
- my $owner = $self->_CvGV( \&{ $sym } );
- $owner =~ s/^\*(.*)::.*?$/$1/;
- next if $owner ne $self->{package};
+ my $glob = do { no strict 'refs'; \*{$sym} };
+ my $o = B::svref_2object($glob);
+
+ # in 5.005 this flag is not exposed via B, though it exists
+ my $imported_cv = eval { B::GVf_IMPORTED_CV() } || 0x80;
+ next if $o->GvFLAGS & $imported_cv;
# check if it's on the whitelist
$sym =~ s/$self->{package}:://;
@@ -350,7 +357,6 @@
return $pod->{identifiers} || [];
}
-
=item _private_check($symbol)
return true if the symbol should be considered private
@@ -359,7 +365,7 @@
sub _private_check {
my $self = shift;
- my $sym = shift;
+ my $sym = shift;
return grep { $sym =~ /$_/ } @{ $self->{private} };
}
@@ -370,14 +376,15 @@
=cut
sub _trustme_check {
- my($self, $sym) = @_;
+ my ( $self, $sym ) = @_;
return grep { $sym =~ /$_/ } @{ $self->{trustme} };
}
sub _CvGV {
my $self = shift;
- my $cv = shift;
- my $b_cv = B::svref_2object( $cv );
+ my $cv = shift;
+ my $b_cv = B::svref_2object($cv);
+
# perl 5.6.2's B doesn't have an object_2svref. in 5.8 you can
# just do this:
# return *{ $b_cv->GV->object_2svref };
@@ -386,46 +393,52 @@
return *{ $b_cv->GV->STASH->NAME . "::" . $b_cv->GV->NAME };
}
-
package Pod::Coverage::Extractor;
use Pod::Parser;
use base 'Pod::Parser';
use constant debug => 0;
+
# extract subnames from a pod stream
sub command {
my $self = shift;
- my ($command, $text, $line_num) = @_;
- if ($command eq 'item' || $command =~ /^head(?:2|3|4)/) {
+ my ( $command, $text, $line_num ) = @_;
+ if ( $command eq 'item' || $command =~ /^head(?:2|3|4)/ ) {
+
# take a closer look
- my @pods = ($text =~ /\s*([^\s\|,\/]+)/g);
+ my @pods = ( $text =~ /\s*([^\s\|,\/]+)/g );
$self->{recent} = [];
foreach my $pod (@pods) {
print "Considering: '$pod'\n" if debug;
# it's dressed up like a method cal
- $pod =~ /-E<\s*gt\s*>(.*)/ and $pod = $1;
- $pod =~ /->(.*)/ and $pod = $1;
+ $pod =~ /-E<\s*gt\s*>(.*)/ and $pod = $1;
+ $pod =~ /->(.*)/ and $pod = $1;
+
# it's used as a (bare) fully qualified name
$pod =~ /\w+(?:::\w+)*::(\w+)/ and $pod = $1;
+
# it's wrapped in a pod style B<>
$pod =~ s/[A-Z]//g;
+
# has arguments, or a semicolon
- $pod =~ /(\w+)\s*[;\(]/ and $pod = $1;
+ $pod =~ /(\w+)\s*[;\(]/ and $pod = $1;
print "Adding: '$pod'\n" if debug;
- push @{$self->{$self->{nonwhitespace} ? "recent" : "identifiers"}}, $pod;
+ push @{ $self->{ $self->{nonwhitespace}
+ ? "recent"
+ : "identifiers" } }, $pod;
}
}
}
sub textblock {
my $self = shift;
- my ($text, $line_num) = shift;
- if ($self->{nonwhitespace} and $text =~ /\S/ and $self->{recent}) {
- push @{$self->{identifiers}}, @{$self->{recent}};
+ my ( $text, $line_num ) = shift;
+ if ( $self->{nonwhitespace} and $text =~ /\S/ and $self->{recent} ) {
+ push @{ $self->{identifiers} }, @{ $self->{recent} };
$self->{recent} = [];
}
}
@@ -466,7 +479,7 @@
=head1 COPYRIGHT
-Copyright (c) 2001, 2003, 2004, 2006 Richard Clamp, Michael
+Copyright (c) 2001, 2003, 2004, 2006, 2007 Richard Clamp, Michael
Stevens. All rights reserved. This program is free software; you can
redistribute it and/or modify it under the same terms as Perl itself.
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/Pod-Coverage-0.18/Makefile.PL new/Pod-Coverage-0.19/Makefile.PL
--- old/Pod-Coverage-0.18/Makefile.PL 2006-08-04 15:45:58.000000000 +0200
+++ new/Pod-Coverage-0.19/Makefile.PL 2007-09-13 17:22:40.000000000 +0200
@@ -2,18 +2,18 @@
use ExtUtils::MakeMaker;
WriteMakefile
(
- 'NAME' => 'Pod::Coverage',
- 'VERSION_FROM' => 'lib/Pod/Coverage.pm',
- 'PREREQ_PM' => {
- 'Devel::Symdump' => '2.01',
- 'Pod::Find' => '0.21',
- 'Pod::Parser' => '1.13',
- 'Test::More' => '0'
- },
+ 'PL_FILES' => {},
'INSTALLDIRS' => 'site',
+ 'NAME' => 'Pod::Coverage',
'EXE_FILES' => [
'bin/pod_cover'
],
- 'PL_FILES' => {}
+ 'VERSION_FROM' => 'lib/Pod/Coverage.pm',
+ 'PREREQ_PM' => {
+ 'Test::More' => 0,
+ 'Pod::Parser' => '1.13',
+ 'Devel::Symdump' => '2.01',
+ 'Pod::Find' => '0.21'
+ }
)
;
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/Pod-Coverage-0.18/META.yml new/Pod-Coverage-0.19/META.yml
--- old/Pod-Coverage-0.18/META.yml 2006-08-04 15:45:58.000000000 +0200
+++ new/Pod-Coverage-0.19/META.yml 2007-09-13 17:22:40.000000000 +0200
@@ -1,9 +1,14 @@
---
name: Pod-Coverage
-version: 0.18
-author: ~
+version: 0.19
+author:
+ - 'Richard Clamp