Hello community, here is the log from the commit of package dx checked in at Mon Aug 13 00:11:52 CEST 2007. -------- --- dx/dx.changes 2007-08-06 18:49:28.000000000 +0200 +++ /mounts/work_src_done/STABLE/dx/dx.changes 2007-08-12 10:18:22.000000000 +0200 @@ -1,0 +2,7 @@ +Sat Aug 11 00:20:48 CEST 2007 - meissner@suse.de + +- fixed 3 array overflows (index 3 instead of 2), + and one misplaced ) causing undefined behaviour. +- build with ImageMagick too + +------------------------------------------------------------------- New: ---- dx-4.4.4-array-overflow.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ dx.spec ++++++ --- /var/tmp/diff_new_pack.zi4094/_old 2007-08-13 00:11:30.000000000 +0200 +++ /var/tmp/diff_new_pack.zi4094/_new 2007-08-13 00:11:30.000000000 +0200 @@ -12,13 +12,13 @@ Name: dx %define samplesversion 4.4.0 -BuildRequires: bison flex freeglut-devel freetype2-devel gcc-c++ libexpat0 libpng-devel libtiff-devel openmotif openmotif-devel tcsh update-desktop-files +BuildRequires: ImageMagick-devel bison flex freeglut-devel freetype2-devel gcc-c++ libexpat0 libpng-devel libtiff-devel openmotif openmotif-devel tcsh update-desktop-files %if %suse_version > 1000 BuildRequires: libdrm-devel %endif BuildRequires: fdupes Version: 4.4.4 -Release: 78 +Release: 81 Summary: IBM Open Visualization Data Explorer License: IBM Public License Group: Productivity/Graphics/Visualization/Other @@ -38,6 +38,7 @@ Patch7: dx-%{version}-undefined_code.patch Patch8: dx-%{version}-manpage.patch Patch9: dx.linux-sys.patch +Patch10: dx-%{version}-array-overflow.patch Patch20: dxsamples-%{samplesversion}-java.patch Patch21: dxsamples-%{samplesversion}-DESTDIR.patch Patch22: dxsamples-%{samplesversion}-rights.patch @@ -98,6 +99,11 @@ Group: Productivity/Graphics/Visualization/Other Requires: %{name} = %{version} Autoreqprov: on +Requires: glibc-devel libtiff-devel libjpeg-devel fontconfig-devel openmotif-devel +Requires: libpng-devel zlib-devel libexpat-devel freetype2-devel +Requires: xorg-x11-libXp-devel Mesa-devel xorg-x11-libXmu-devel xorg-x11-libXext-devel +Requires: xorg-x11-libXt-devel xorg-x11-libX11-devel xorg-x11-libxcb-devel xorg-x11-libXau-devel xorg-x11-libSM-devel +Requires: xorg-x11-devel xorg-x11-libXpm-devel xorg-x11-libXrender-devel xorg-x11-libICE-devel %description devel This package contains header C files, static libraries and source code @@ -121,6 +127,7 @@ %patch7 %patch8 %patch9 -p1 +%patch10 # samples cd ../dxsamples-%{samplesversion} %patch20 @@ -241,6 +248,10 @@ /opt/dx/samples/*/*/*/*.c %changelog +* Sat Aug 11 2007 - meissner@suse.de +- fixed 3 array overflows (index 3 instead of 2), + and one misplaced ) causing undefined behaviour. +- build with ImageMagick too * Mon Aug 06 2007 - olh@suse.de - remove inclusion of linux/sys.h fix prep section for quilt setup -v *.spec ++++++ dx-4.4.4-array-overflow.patch ++++++ --- src/exec/dxmods/genimp_io.c +++ src/exec/dxmods/genimp_io.c @@ -1624,7 +1624,7 @@ if (_dxd_gi_header.type==SKIP_MARKER && strstr(str,_dxd_gi_header.marker)){ if (sets_read == num_sets && - _dxd_gi_header.marker[strlen(_dxd_gi_header.marker-1)]=='\n') + _dxd_gi_header.marker[strlen(_dxd_gi_header.marker)-1]=='\n') _dxd_gi_header.type = SKIP_NOTHING; else *read_header=1; --- src/exec/libdx/lbcamera.c +++ src/exec/libdx/lbcamera.c @@ -28,9 +28,9 @@ { Matrix t; - t.A[0][0] = p[ 0]; t.A[0][1] = p[ 1]; t.A[0][3] = p[ 2]; - t.A[1][0] = p[ 4]; t.A[1][1] = p[ 5]; t.A[1][3] = p[ 6]; - t.A[2][0] = p[ 8]; t.A[2][1] = p[ 9]; t.A[2][3] = p[10]; + t.A[0][0] = p[ 0]; t.A[0][1] = p[ 1]; t.A[0][2] = p[ 2]; + t.A[1][0] = p[ 4]; t.A[1][1] = p[ 5]; t.A[1][2] = p[ 6]; + t.A[2][0] = p[ 8]; t.A[2][1] = p[ 9]; t.A[2][2] = p[10]; t.b[0] = p[12]; t.b[1] = p[13]; t.b[2] = p[14]; c->m = c->rot = t; ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org