Hello community, here is the log from the commit of package suck checked in at Fri Feb 16 07:29:30 CET 2007. -------- --- suck/suck.changes 2006-01-25 21:41:52.000000000 +0100 +++ /mounts/work_src_done/STABLE/suck/suck.changes 2007-02-15 16:12:45.000000000 +0100 @@ -1,0 +2,6 @@ +Wed Feb 14 18:58:39 CET 2007 - mvaner@suse.cz + +- Replaced dangerous gets with fgets, bug #223615 + - fgets.patch + +------------------------------------------------------------------- New: ---- suck-4.3.0-fgets.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ suck.spec ++++++ --- /var/tmp/diff_new_pack.Sn6301/_old 2007-02-16 07:28:48.000000000 +0100 +++ /var/tmp/diff_new_pack.Sn6301/_new 2007-02-16 07:28:48.000000000 +0100 @@ -1,28 +1,29 @@ # # spec file for package suck (Version 4.3.0) # -# Copyright (c) 2006 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2007 SUSE LINUX Products GmbH, Nuernberg, Germany. # This file and all modifications and additions to the pristine # package are under the same license as the package itself. # -# Please submit bugfixes or comments via http://bugs.opensuse.org +# Please submit bugfixes or comments via http://bugs.opensuse.org/ # # norootforbuild Name: suck BuildRequires: inn openssl-devel -License: distributable +License: Public Domain, Freeware Group: Productivity/Networking/News/Utilities Autoreqprov: on Version: 4.3.0 -Release: 531 +Release: 571 URL: http://www.sucknews.org Summary: Reading News Offline Source: suck-%{version}.tar.bz2 Patch: suck-%{version}.dif Patch1: suck-%{version}-ia64.patch Patch2: suck-%{version}-thrperl.dif +Patch3: suck-%{version}-fgets.patch BuildRoot: %{_tmppath}/%{name}-%{version}-build %description @@ -43,6 +44,7 @@ %patch %patch1 %patch2 +%patch3 %build CFLAGS="-Wall $RPM_OPT_FLAGS -pipe -fno-strict-aliasing" LDFLAGS=' ' ./configure --prefix=/usr @@ -64,6 +66,9 @@ %doc %{_mandir}/man1/* %changelog -n suck +* Wed Feb 14 2007 - mvaner@suse.cz +- Replaced dangerous gets with fgets, bug #223615 + - fgets.patch * Wed Jan 25 2006 - mls@suse.de - converted neededforbuild to BuildRequires * Sun Jan 15 2006 - schwab@suse.de @@ -82,10 +87,10 @@ - Fixed linkage of dynamic perl library * Fri Nov 23 2001 - nadvornik@suse.cz - update to 4.3.0: -- SSL support -- rpost: added the -i option to ignore the 201 readonly code + - SSL support + - rpost: added the -i option to ignore the 201 readonly code and try to post anyway -- suck: added the -bP option to post articles to the local server + - suck: added the -bP option to post articles to the local server every x number of articles, instead of waiting until all articles are downloaded. * Mon May 21 2001 - nadvornik@suse.cz ++++++ suck-4.3.0-fgets.patch ++++++ --- lpost.c +++ lpost.c @@ -13,7 +13,8 @@ int main(int argc,char *argv[]) { FILE *pfp=NULL; - char line[1024]; + const int max_len = 1024; + char line[max_len]; int count=0,verbose=0, retval=0; size_t len; @@ -21,7 +22,7 @@ verbose=1; } - while(gets(line) != NULL && retval == 0) { + while(fgets(line, max_len, stdin) != NULL && retval == 0) { len=strlen(line); if (pfp == NULL) { if (verbose != 0) { @@ -45,7 +46,6 @@ } else { (void) fputs(line, pfp); - (void) putc('\n', pfp); } } /* end while */ exit(retval); ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org