Hello community, here is the log from the commit of package evolution-data-server checked in at Fri Jun 16 12:43:56 CEST 2006. -------- --- GNOME/evolution-data-server/evolution-data-server.changes 2006-06-15 15:38:23.000000000 +0200 +++ evolution-data-server/evolution-data-server.changes 2006-06-16 12:18:45.000000000 +0200 @@ -1,0 +2,8 @@ +Fri Jun 16 08:16:15 CEST 2006 - vvaradhan@novell.com + +- Fixes (bnc) + 183819 - Evolution crashed while closing in offline mode + 182310 - Evolution crashed when going offline + 183816 - Evolution crashed when swtiched from online to offline... + +------------------------------------------------------------------ @@ -6,0 +15 @@ + @@ -10,0 +20 @@ + New: ---- bnc-183819-evo-crashed-closing-offline.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ evolution-data-server.spec ++++++ --- /var/tmp/diff_new_pack.z5tFkh/_old 2006-06-16 12:43:26.000000000 +0200 +++ /var/tmp/diff_new_pack.z5tFkh/_new 2006-06-16 12:43:26.000000000 +0200 @@ -18,7 +18,7 @@ Autoreqprov: on Summary: Evolution Data Server Version: 1.6.0 -Release: 61 +Release: 62 Source: ftp://ftp.gnome.org/pub/gnome/sources/evolution-data-server/1.6/%{name}-%{version}.tar.bz2 #Patch3: evolution-data-server-gcc4.patch Patch5: evolution-data-server-configure.patch @@ -97,6 +97,7 @@ Patch76: bnc-179350.patch Patch77: bnc-170052-eds-crash.patch Patch78: email-appears-twice.patch +Patch79: bnc-183819-evo-crashed-closing-offline.patch Url: http://www.gnome.org BuildRoot: %{_tmppath}/%{name}-%{version}-build Requires: libsoup >= 2.2.6 mozilla-nss @@ -204,6 +205,7 @@ %patch75 %patch77 %patch78 +%patch79 %build rename no nb po/no.* @@ -254,6 +256,11 @@ %{prefix}/share/gtk-doc/html/* %changelog -n evolution-data-server +* Fri Jun 16 2006 - vvaradhan@novell.com +- Fixes (bnc) + 183819 - Evolution crashed while closing in offline mode + 182310 - Evolution crashed when going offline + 183816 - Evolution crashed when swtiched from online to offline... * Thu Jun 15 2006 - psankar@novell.com - Added the fix to display the email address only once for the gw accounts ++++++ bnc-183819-evo-crashed-closing-offline.patch ++++++ --- camel/providers/groupwise/camel-groupwise-folder.c.orig 2006-06-16 01:25:47.000000000 +0530 +++ camel/providers/groupwise/camel-groupwise-folder.c 2006-06-16 10:52:22.000000000 +0530 @@ -795,16 +795,27 @@ update_update (CamelSession *session, Ca struct _folder_update_msg *m = (struct _folder_update_msg *)msg; EGwConnectionStatus status; CamelException *ex = NULL; + CamelGroupwiseStore *gw_store = CAMEL_GROUPWISE_STORE (m->folder->parent_store); GList *item_list, *items_full_list = NULL, *last_element=NULL; int cursor = 0; const char *position = E_GW_CURSOR_POSITION_END; gboolean done; + /* Hold the connect_lock. + In case if user went offline, don't do anything. + m->cnc would have become invalid, as the store disconnect unrefs it. + */ + CAMEL_SERVICE_LOCK (gw_store, connect_lock); + if (((CamelOfflineStore *) gw_store)->state == CAMEL_OFFLINE_STORE_NETWORK_UNAVAIL || + ((CamelService *)gw_store)->status == CAMEL_SERVICE_DISCONNECTED) { + goto end1; + } + status = e_gw_connection_create_cursor (m->cnc, m->container_id, "id", NULL, &cursor); if (status != E_GW_CONNECTION_STATUS_OK) { g_warning ("ERROR update update\n"); - return ; + goto end1; } done = FALSE; @@ -816,7 +827,7 @@ update_update (CamelSession *session, Ca if (status != E_GW_CONNECTION_STATUS_OK) { g_warning ("ERROR update update\n"); e_gw_connection_destroy_cursor (m->cnc, m->container_id, cursor); - return; + goto end1; } if (!item_list || g_list_length (item_list) == 0) @@ -839,6 +850,7 @@ update_update (CamelSession *session, Ca } e_gw_connection_destroy_cursor (m->cnc, m->container_id, cursor); + CAMEL_SERVICE_UNLOCK (gw_store, connect_lock); /* Take out only the first part in the list until the @ since it is guaranteed to be unique only until that symbol */ @@ -860,6 +872,11 @@ update_update (CamelSession *session, Ca g_print ("\nNumber of items in the folder: %d \n", g_list_length(items_full_list)); gw_update_all_items (m->folder, items_full_list, ex); + + return; + end1: + CAMEL_SERVICE_UNLOCK (gw_store, connect_lock); + return; } static void ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-commit-unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit-help@opensuse.org