Hello community, here is the log from the commit of package gnome-utils checked in at Tue May 2 11:32:27 CEST 2006. -------- --- GNOME/gnome-utils/gnome-utils.changes 2006-03-31 22:20:09.000000000 +0200 +++ STABLE/gnome-utils/gnome-utils.changes 2006-05-01 21:21:46.000000000 +0200 @@ -1,0 +2,5 @@ +Mon May 1 21:21:05 CEST 2006 - jpr@suse.de + +- Fix off-by-one error (#168760) + +------------------------------------------------------------------- New: ---- gnome-utils-dict-read.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gnome-utils.spec ++++++ --- /var/tmp/diff_new_pack.QiGNmj/_old 2006-05-02 11:31:57.000000000 +0200 +++ /var/tmp/diff_new_pack.QiGNmj/_new 2006-05-02 11:31:57.000000000 +0200 @@ -20,7 +20,7 @@ Obsoletes: gnome-utils2 Autoreqprov: on Version: 2.12.2 -Release: 22 +Release: 30 Summary: Basic Utilities for the GNOME 2.x Desktop Source: ftp://ftp.gnome.org/pub/gnome/sources/gnome-utils/2.11/%{name}-%{version}.tar.bz2 Source1: gnome-screenshot.desktop @@ -29,6 +29,7 @@ Patch21: gnome-utils-strict-aliasing.patch Patch22: gnome-utils-logview-findbar-return.patch Patch23: gnome-utils-screenshot-abspath.patch +Patch24: gnome-utils-dict-read.patch URL: http://www.gnome.org BuildRoot: %{_tmppath}/%{name}-%{version}-build PreReq: filesystem gconf2 /usr/bin/touch @@ -121,6 +122,7 @@ %patch21 %patch22 %patch23 +%patch24 gnome-patch-translation-update %build @@ -202,6 +204,8 @@ %{prefix}/share/pixmaps %changelog -n gnome-utils +* Mon May 01 2006 - jpr@suse.de +- Fix off-by-one error (#168760) * Fri Mar 31 2006 - danw@suse.de - DTRT if the user types an absolute path into the filename entry. [#162460] ++++++ gnome-utils-dict-read.patch ++++++ --- gdictsrc/dict.c +++ gdictsrc/dict.c @@ -149,7 +149,10 @@ if (context->write_ptr > context->read_ptr) memmove (context->read_buf, context->read_ptr, context->write_ptr - context->read_ptr); - context->write_ptr -= context->read_ptr - context->read_buf; + if (context->read_ptr > context->write_ptr) + context->write_ptr = context->read_buf; + else + context->write_ptr -= context->read_ptr - context->read_buf; context->read_ptr = context->read_buf; res = g_io_channel_read (context->channel, context->write_ptr, @@ -188,7 +191,10 @@ if (!context->channel) return NULL; while (1) { - end_ptr = strchr (context->read_ptr, '\r'); + end_ptr = NULL; + + if (context->read_ptr <= context->write_ptr) + end_ptr = strchr (context->read_ptr, '\r'); if (end_ptr == NULL || end_ptr > context->write_ptr) { if (cycle_buffer (context)) return NULL; ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun...