Hello community, here is the log from the commit of package evolution-data-server checked in at Tue Apr 18 01:55:23 CEST 2006. -------- --- GNOME/evolution-data-server/evolution-data-server.changes 2006-04-07 09:06:26.000000000 +0200 +++ STABLE/evolution-data-server/evolution-data-server.changes 2006-04-16 21:24:24.000000000 +0200 @@ -1,0 +2,14 @@ +Sun Apr 16 20:35:22 CEST 2006 - vvaradhan@novell.com + +- Fixes (bnc) + 152070 evolution-data-server-1.6 crash - Devashish + 160915 Evolution crashed when clicked on 'Goto' date in + calendar view - Chenthill + 163982 While saving appointment system hanged with 126 + error popups - Chenthill + 164140 EDS Crashed when starting 'evolution --offline' - Devashish + 164367 GW: Attachment to appointments/meetings throws 'Unknown Error' + - Chenthill + 164676 evolution-data-server stuck in tight loop - Devashish + +------------------------------------------------------------------- New: ---- bnc-152070-eds-crash.patch bnc-160915-evolution-crash-clickng-goto-cal-view.patch bnc-163982-system-hang-with-126-error-popups.patch bnc-164140-eds-crash-evolution--offline.patch bnc-164367-gw-attachments-appts-throw-error.patch bnc-164676-eds-stuck-tight-loop.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ evolution-data-server.spec ++++++ --- /var/tmp/diff_new_pack.vbYZaN/_old 2006-04-18 01:49:15.000000000 +0200 +++ /var/tmp/diff_new_pack.vbYZaN/_new 2006-04-18 01:49:15.000000000 +0200 @@ -18,7 +18,7 @@ Autoreqprov: on Summary: Evolution Data Server Version: 1.6.0 -Release: 16 +Release: 20 Source: ftp://ftp.gnome.org/pub/gnome/sources/evolution-data-server/1.6/%{name}-%{version}.tar.bz2 #Patch3: evolution-data-server-gcc4.patch Patch5: evolution-data-server-configure.patch @@ -57,6 +57,12 @@ Patch36: bnc-161290-eds-crashed-forwarding-mail.patch Patch37: bnc-162005-e-d-s-crash-deleting-recur-appt.patch Patch38: bnc-163664-eds-crashes-on-invalid-utf8-contacts.patch +Patch39: bnc-160915-evolution-crash-clickng-goto-cal-view.patch +Patch40: bnc-164367-gw-attachments-appts-throw-error.patch +Patch41: bnc-163982-system-hang-with-126-error-popups.patch +Patch42: bnc-164676-eds-stuck-tight-loop.patch +Patch43: bnc-152070-eds-crash.patch +Patch44: bnc-164140-eds-crash-evolution--offline.patch Url: http://www.gnome.org BuildRoot: %{_tmppath}/%{name}-%{version}-build Requires: libsoup >= 2.2.6 mozilla-nss @@ -125,6 +131,12 @@ %patch36 %patch37 %patch38 +%patch39 +%patch40 +%patch41 +%patch42 +%patch43 +%patch44 %build rename no nb po/no.* @@ -174,6 +186,17 @@ %{prefix}/share/gtk-doc/html/* %changelog -n evolution-data-server +* Sun Apr 16 2006 - vvaradhan@novell.com +- Fixes (bnc) + 152070 evolution-data-server-1.6 crash - Devashish + 160915 Evolution crashed when clicked on 'Goto' date in + calendar view - Chenthill + 163982 While saving appointment system hanged with 126 + error popups - Chenthill + 164140 EDS Crashed when starting 'evolution --offline' - Devashish + 164367 GW: Attachment to appointments/meetings throws 'Unknown Error' +- Chenthill + 164676 evolution-data-server stuck in tight loop - Devashish * Fri Apr 07 2006 - vvaradhan@novell.com - Fixes (bnc) 163664 E-D-S crashes if a contact has invalid UTF-8 - Federico ++++++ bnc-152070-eds-crash.patch ++++++ Index: addressbook/backends/groupwise/e-book-backend-groupwise.c =================================================================== RCS file: /cvs/gnome/evolution-data-server/addressbook/backends/groupwise/e-book-backend-groupwise.c,v retrieving revision 1.74 diff -u -p -r1.74 e-book-backend-groupwise.c --- addressbook/backends/groupwise/e-book-backend-groupwise.c 10 Apr 2006 11:02:36 -0000 1.74 +++ addressbook/backends/groupwise/e-book-backend-groupwise.c 16 Apr 2006 07:30:20 -0000 @@ -2334,6 +2334,11 @@ find_book_view (EBookBackendGroupwise *e return NULL; EIterator *iter = e_list_get_iterator (views); EDataBookView *rv = NULL; + + if (!iter) { + g_object_unref (views); + return NULL; + } if (e_iterator_is_valid (iter)) { /* just always use the first book view */ ++++++ bnc-160915-evolution-crash-clickng-goto-cal-view.patch ++++++ Index: calendar/libecal/e-cal.c =================================================================== RCS file: /cvs/gnome/evolution-data-server/calendar/libecal/e-cal.c,v retrieving revision 1.125 diff -u -p -r1.125 e-cal.c --- calendar/libecal/e-cal.c 4 Mar 2006 10:29:07 -0000 1.125 +++ calendar/libecal/e-cal.c 11 Apr 2006 13:29:57 -0000 @@ -3528,7 +3528,7 @@ process_detached_instances (GList *insta ci->end = cid->end; processed = TRUE; - } else { + } else if (instance_recur_id.datetime.value && recur_id.datetime.value){ cmp = icaltime_compare (*instance_recur_id.datetime.value, *recur_id.datetime.value); if ((recur_id.type == E_CAL_COMPONENT_RANGE_THISPRIOR && cmp <= 0) || ++++++ bnc-163982-system-hang-with-126-error-popups.patch ++++++ Index: calendar/backends/file/e-cal-backend-file.c =================================================================== RCS file: /cvs/gnome/evolution-data-server/calendar/backends/file/e-cal-backend-file.c,v retrieving revision 1.73 diff -u -p -r1.73 e-cal-backend-file.c --- calendar/backends/file/e-cal-backend-file.c 23 Mar 2006 09:21:09 -0000 1.73 +++ calendar/backends/file/e-cal-backend-file.c 11 Apr 2006 12:48:32 -0000 @@ -129,6 +129,7 @@ save_file_when_idle (gpointer user_data) GnomeVFSFileSize out; gchar *tmp, *backup_uristr; char *buf; + char *error = NULL; ECalBackendFile *cbfile = user_data; priv = cbfile->priv; @@ -201,12 +202,14 @@ save_file_when_idle (gpointer user_data) g_mutex_unlock (priv->idle_save_mutex); e_cal_backend_notify_error (E_CAL_BACKEND (cbfile), _("Can't save calendar data: Malformed URI.")); - return TRUE; + return FALSE; error: g_mutex_unlock (priv->idle_save_mutex); - e_cal_backend_notify_error (E_CAL_BACKEND (cbfile), gnome_vfs_result_to_string (result)); - return TRUE; + error = g_strconcat (_("Can't save calendar data: "), gnome_vfs_result_to_string (result), NULL); + e_cal_backend_notify_error (E_CAL_BACKEND (cbfile), error); + g_free (error); + return FALSE; } static void @@ -515,8 +518,6 @@ add_component (ECalBackendFile *cbfile, g_assert (icalcomp != NULL); icalcomponent_add_component (priv->icalcomp, icalcomp); - - save (cbfile); } } ++++++ bnc-164140-eds-crash-evolution--offline.patch ++++++ Index: addressbook/backends/file/e-book-backend-file.c =================================================================== RCS file: /cvs/gnome/evolution-data-server/addressbook/backends/file/e-book-backend-file.c,v retrieving revision 1.41 diff -u -p -r1.41 e-book-backend-file.c --- addressbook/backends/file/e-book-backend-file.c 16 Jan 2006 16:36:14 -0000 1.41 +++ addressbook/backends/file/e-book-backend-file.c 11 Apr 2006 11:25:19 -0000 @@ -516,6 +516,8 @@ book_view_thread (gpointer data) { EDataBookView *book_view = data; FileBackendSearchClosure *closure = get_closure (book_view); + if (!closure) + return; EBookBackendFile *bf = closure->bf; const char *query; DB *db; @@ -652,6 +654,9 @@ e_book_backend_file_stop_book_view (EBoo { FileBackendSearchClosure *closure = get_closure (book_view); gboolean need_join = FALSE; + + if (!closure) + return; d(printf ("stopping query\n")); g_mutex_lock (closure->mutex); ++++++ bnc-164367-gw-attachments-appts-throw-error.patch ++++++ Index: calendar/backends/groupwise/e-cal-backend-groupwise-utils.c =================================================================== RCS file: /cvs/gnome/evolution-data-server/calendar/backends/groupwise/e-cal-backend-groupwise-utils.c,v retrieving revision 1.73 diff -u -p -r1.73 e-cal-backend-groupwise-utils.c --- calendar/backends/groupwise/e-cal-backend-groupwise-utils.c 9 Dec 2005 11:21:49 -0000 1.73 +++ calendar/backends/groupwise/e-cal-backend-groupwise-utils.c 11 Apr 2006 09:12:09 -0000 @@ -300,9 +300,10 @@ e_cal_backend_groupwise_set_attachments_ /* FIXME the member does not follow the naming convention. * Should be fixed in e-gw-item*/ attach_item->contentType = g_strdup (gnome_vfs_get_mime_type (attach_filename_full)); - g_free (attach_filename_full); attach_item->name = g_strdup (filename + strlen(uid) + 1); + g_free (attach_filename_full); + /* do a base64 encoding so it can be embedded in a soap * message */ encoded_data = soup_base64_encode (file_contents, file_len); ++++++ bnc-164676-eds-stuck-tight-loop.patch ++++++ --- addressbook/backends/groupwise/e-book-backend-groupwise.c.orig 2006-04-16 20:19:03.086611569 +0200 +++ addressbook/backends/groupwise/e-book-backend-groupwise.c 2006-04-16 20:24:43.271873993 +0200 @@ -2814,8 +2814,41 @@ update_address_book_deltas (EBookBackend printf("sequence differs but no changes found !!!\n"); break; } - printf("add_list size:%d\n", g_list_length(add_list)); - printf("delete_list size:%d\n", g_list_length(delete_list)); + if (enable_debug) { + printf("add_list size:%d\n", g_list_length(add_list)); + printf("delete_list size:%d\n", g_list_length(delete_list)); + } + + for (; delete_list != NULL; delete_list = g_list_next(delete_list)) { + const char *id; + + /* deleted from the server */ + contact = e_contact_new (); + fill_contact_from_gw_item (contact, + E_GW_ITEM (delete_list->data), + ebgw->priv->categories_by_id); + if (enable_debug) + printf("contact email:%s, contact name:%s\n", (char *) e_contact_get(contact, E_CONTACT_EMAIL_1), (char *) e_contact_get(contact, E_CONTACT_GIVEN_NAME)); + e_contact_set (contact, + E_CONTACT_BOOK_URI, + priv->original_uri); + id = e_contact_get_const (contact, E_CONTACT_UID); + + if (e_book_backend_cache_check_contact (ebgw->priv->cache, id)) { + contact_num++; + + if (book_view) { + status_msg = g_strdup_printf (_("Updating contacts cache (%d)... "), + contact_num); + book_view_notify_status (book_view, status_msg); + g_free (status_msg); + } + e_book_backend_cache_remove_contact (ebgw->priv->cache, id); + e_book_backend_summary_remove_contact (ebgw->priv->summary, id); + } + g_object_unref(contact); + g_object_unref (delete_list->data); + } for (; add_list != NULL; add_list = g_list_next(add_list)) { const char *id; @@ -2851,34 +2884,6 @@ update_address_book_deltas (EBookBackend g_object_unref (add_list->data); } - for (; delete_list != NULL; delete_list = g_list_next(delete_list)) { - const char *id; - - /* deleted from the server */ - contact = e_contact_new (); - fill_contact_from_gw_item (contact, - E_GW_ITEM (delete_list->data), - ebgw->priv->categories_by_id); - e_contact_set (contact, - E_CONTACT_BOOK_URI, - priv->original_uri); - id = e_contact_get_const (contact, E_CONTACT_UID); - - if (e_book_backend_cache_check_contact (ebgw->priv->cache, id)) { - contact_num++; - - if (book_view) { - status_msg = g_strdup_printf (_("Updating contacts cache (%d)... "), - contact_num); - book_view_notify_status (book_view, status_msg); - g_free (status_msg); - } - e_book_backend_cache_remove_contact (ebgw->priv->cache, id); - e_book_backend_summary_remove_contact (ebgw->priv->summary, id); - } - g_object_unref(contact); - g_object_unref (delete_list->data); - } cache_last_sequence += contact_num; } --- servers/groupwise/e-gw-connection.c.orig 2006-04-16 20:19:30.383515263 +0200 +++ servers/groupwise/e-gw-connection.c 2006-04-16 20:19:40.699856797 +0200 @@ -764,7 +764,7 @@ e_gw_connection_get_items_delta (EGwConn SoupSoapMessage *msg; SoupSoapResponse *response; EGwConnectionStatus status; - SoupSoapParameter *param, *subparam; + SoupSoapParameter *param, *subparam, *subsubparam; g_return_val_if_fail (E_IS_GW_CONNECTION (cnc), E_GW_CONNECTION_STATUS_INVALID_OBJECT); @@ -819,11 +819,11 @@ e_gw_connection_get_items_delta (EGwConn item = e_gw_item_new_from_soap_parameter (cnc->priv->user_email, container, subparam); - subparam = soup_soap_parameter_get_first_child_by_name(subparam, "sync"); - if (subparam) { + subsubparam = soup_soap_parameter_get_first_child_by_name(subparam, "sync"); + if (subsubparam) { char *value; - value = soup_soap_parameter_get_string_value (subparam); + value = soup_soap_parameter_get_string_value (subsubparam); if (!strcmp (value, "add") || !strcmp (value, "update")) { *add_list = g_list_append (*add_list, item); } else if (!strcmp (value, "delete")) { ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun...