Hello community, here is the log from the commit of package amarok checked in at Mon Apr 10 20:02:04 CEST 2006. -------- --- KDE/amarok/amarok.changes 2006-04-08 02:06:40.000000000 +0200 +++ STABLE/amarok/amarok.changes 2006-04-10 18:32:43.000000000 +0200 @@ -1,0 +2,5 @@ +Mon Apr 10 18:32:29 CEST 2006 - dmueller@suse.de + +- fix memory leak in helix wrapper (#163481) + +------------------------------------------------------------------- ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ amarok.spec ++++++ --- /var/tmp/diff_new_pack.yrEMpK/_old 2006-04-10 20:01:38.000000000 +0200 +++ /var/tmp/diff_new_pack.yrEMpK/_new 2006-04-10 20:01:38.000000000 +0200 @@ -19,7 +19,7 @@ Group: Productivity/Multimedia/Sound/Players Summary: Media Player for KDE Version: 1.3.8 -Release: 22 +Release: 24 BuildRoot: %{_tmppath}/%{name}-%{version}-build %define rversion 1.3.8 %define mversion 0.5 @@ -344,6 +344,8 @@ /opt/kde3/bin/amarok_libvisual %changelog -n amarok +* Mon Apr 10 2006 - dmueller@suse.de +- fix memory leak in helix wrapper (#163481) * Wed Apr 05 2006 - dmueller@suse.de - fix memory leak in helix engine (#163481) * Tue Apr 04 2006 - stbinner@suse.de ++++++ amarok-helix-helper.cpp ++++++ --- KDE/amarok/amarok-helix-helper.cpp 2006-03-09 21:18:20.000000000 +0100 +++ STABLE/amarok/amarok-helix-helper.cpp 2006-04-10 18:19:34.000000000 +0200 @@ -15,8 +15,6 @@ int retval; fd_set rfds; - //ofstream log( "/tmp/helix-helper.log" ); Security: use mkstemp!!! - while ( true ) { FD_ZERO(&rfds); FD_SET(0, &rfds); @@ -26,14 +24,14 @@ retval = select (1, &rfds, NULL, NULL, &tv); - if (retval >= 0 && numPlayers) + if (retval >= 0 && numPlayers) { player.dispatch(); + player.clearScopeQ(); + } if(retval == 1) { if(cin.eof()) exit(0); getline(cin, in); - - //log << in << endl << flush; } else continue; ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun...