Mailinglist Archive: opensuse-buildservice (88 mails)

< Previous Next >
Re: [opensuse-buildservice] Re: bs_srcserver seems stuck at a specific lastnotification number
On Wed, 20 Jun 2018 10:46:35 +0200
Stefan Seyfried <stefan.seyfried@xxxxxxxxxxxxxx> wrote:

Hi all,

JFTR: this is OBS-2.8.4 still, but I think the issue is present in 2.9

On 19.06.2018 17:31, Stefan Seyfried wrote:
Hi,

I was investigating why my OBS server has a considerable amount of
CPU load all the time. It's bs_srcserver that occupies one CPU
almost entirely. Investigating, it looks like it is processing
the /srv/obs/events/lastnotifications over and over again.

I have no real idea how this all plays together, and what I have to
do to get this into a sane state again.

(has nothing to do with schedulers, architectures etc...)

I seem to have similar problems with Packman's PMBS:

pmbs:/srv/obs/events # egrep 3635610 lastnotifications
3635610|SRCSRV_COMMIT|1484696363|comment%3D- Update to version
17.0.1:%0A * deps/libff: Fix VP8/VP9/webm alpha support%0A *
rtmp-services: Increase video bitrate limit for YouTube%0A *
obs-outputs: fix build error on freebsd%0A * Update translations from
Crowdin%0A * [CI] Use prebuilt deps so we can build on 10.9%0A * CI:
Build more features into FFMPEG deps%0A * CI: Update browser plugin
ref and build scripts.%0A * CI: Fix zip permission issue on CEF plist
files%0A * obs-x264: ignore opencl param%0A * enc-amf: Update to
1.4.3.8%0A * CI: Ability to make packages on travis%0A * CI: actually
call packagesbuild from the right place �%9F%98%91%0A * cmake: Remove
unnecessary find_package calls%0A * libobs: Fix scale filtering bug
when duplicating scenes%0A * win-capture: Don't use FindWindow for
game capture keepalive%0A * CI: Install Packages and use the full
version%0A * Revert "win-capture: Use FindWindowEx to traverse window
list"%0A * obs-filters.c: Fix color correction filter OpenGL crash%0A
* obs-filters.c: Fix color correction filter saturation%0A * Update
translations from Crowdin%0A * UI: Fix bug with uncopied profile
import/export files%0A * win-capture: Fix game capture size bug when
rehooking%0A * libobs: Add func to enum active and inactive child
tree%0A * libobs: Enumerate full tree when adding active child%0A *
libobs: Add callback for enumerating all scene children%0A * obs-x264:
Allow opencl through much longer alias%0A * libobs: Update to version
17.0.1|files%3DAdded:%0A obs-studio-17.0.1.tar.xz%0A%0ADeleted:%0A
obs-studio-0.17.0.tar.xz%0A%0AModified:%0A _service%0A
_servicedata%0A obs-studio.changes%0A
obs-studio.spec%0A%0A|package%3Dobs-studio|project%3Dhome:<REDACTED>:branches:Multimedia|rev%3D2|user%3D<REDACTED>

Notice the "�%9F%98%91", a hexdump excerpt is here:

00000270 69 6c 64 20 66 72 6f 6d 20 74 68 65 20 72 69 67 |ild from the rig|
00000280 68 74 20 70 6c 61 63 65 20 f0 25 39 46 25 39 38 |ht place .%9F%98|
00000290 25 39 31 25 30 41 20 20 2a 20 63 6d 61 6b 65 3a |%91%0A * cmake:|


So a user managed to sneak in an invalid character 0xC2 into a
comment and this breaks OBS.

Looks like that in my case also.

:
Maybe more input checking is needed to prevent this.

I second this!

Thank you Stefan, for pointing this out!


Greetings,

Stefan
--
Stefan Botter zu Hause
Bremen
< Previous Next >
Follow Ups