[opensuse-buildservice] Re: [PATCH] [testsuite] corrected two testcases with ACL

That broke it: 1) Failure: test_get_projectlist_with_hidden_project(SourceControllerTest) [/test/functional/source_controller_test.rb:20]: expected to not match <"\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n</directory>\n">. And please speak about the correct access kind. The ACL implementation is not touched at all since a long time. It is the same ACL implementation for write and read access. On Monday 23 August 2010 14:13:56 OBS build-service wrote:

From: Martin Mohring

--- src/api/test/functional/source_controller_test.rb | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/api/test/functional/source_controller_test.rb b/src/api/test/functional/source_controller_test.rb index 1603f89..1086554 100644 --- a/src/api/test/functional/source_controller_test.rb +++ b/src/api/test/functional/source_controller_test.rb @@ -13,11 +13,11 @@ class SourceControllerTest < ActionController::IntegrationTest :children => { :only => { :tag => "entry" } } end

- def test_get_projectlist_read_acces_forbidden_project + def test_get_projectlist_with_hidden_project prepare_request_with_user "tom", "thunder" get "/source" assert_response :success - assert_no_match /entry name="HiddenProject"/, @response.body if $ENABLE_BROKEN_TEST + assert_no_match /entry name="HiddenProject"/, @response.body #retry with maintainer ActionController::IntegrationTest::reset_auth prepare_request_with_user "adrian", "so_alone" @@ -26,12 +26,12 @@ class SourceControllerTest < ActionController::IntegrationTest assert_match /entry name="HiddenProject"/, @response.body end

- def test_get_projectlist_with_hidden_project + def test_get_projectlist_with_privacy_protected_project # visible, but no sources prepare_request_with_user "tom", "thunder" get "/source" assert_response :success - assert_match /entry name="ViewprotectedProject"/, @response.body if $ENABLE_BROKEN_TEST + assert_match /entry name="ViewprotectedProject"/, @response.body #retry with maintainer ActionController::IntegrationTest::reset_auth prepare_request_with_user "adrian", "so_alone"

-- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org