Am Dienstag, 18. Mai 2010, 10:52:49 schrieb brook.hong@nokia.com:
For the new request types "set_bugowner" and "add_role", the server side is implemented by editing project meta file directly. When running command as --- osc maintainer hello_test -a somebody -r bugowner, no request was generated.
Right, but this works only, if you have write access there aka you are already maintainer. The requests are to set you with a role in projects, where you don't have write access (yet). bye adrian
I'm wondering if it is sensible to cover these functions in this command.
---------------- Best Regards, Brook Hong
-----Original Message----- From: ext Adrian Schröter [mailto:adrian@suse.de] Sent: Tuesday, May 18, 2010 3:06 PM To: opensuse-buildservice@opensuse.org Cc: Hong Brook (Nokia-D/Beijing) Subject: Re: [opensuse-buildservice] Working on Fate#309351: osc multiple package submit request
Am Dienstag, 18. Mai 2010, 08:56:18 schrieb brook.hong@nokia.com:
Looks good to me. Except that the new request types "set_bugowner" and "add_role" are still missing ;) Ok, I'll add code support for these soon.
great :)
And I think we need to fix some other places in osc to support
request in actions better, esp when
showing a request. Currently you do not see the entire truth when doing "osc rq show" to a request with multiple actions
That's true, will fix.
also great :)
Another thing what comes to my mind is that we should be able to cleanup existing code and use your new functions to have one place to create submit request xml for example.
This would have the downside that OBS 1.0 servers can't parse the new request xml anymore (1.5 and later can), but I think this is acceptable with release of OBS 2.0 soon. Then how about keeping the old commands for compatibility?
I am a bit unsure here. Actually I would suggest that we freeze current osc (and build) packages in openSUSE:Tools:1.7 project and cleanup code in new osc instead.
Removed code is best code, because it is bug free and easy to read ;)
Marcus, any opinion ?
My user name at www.gitorious.org is brookhong.
I have added you there now, but please wait for a comment from Marcus Hüwe about your patch before pushing.
thanks adrian
--
Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de
-- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org