Am Dienstag, 11. Mai 2010, 08:10:46 schrieb brook.hong@nokia.com:
Hi,
1. An accepted request can be revoked
hm, that should maybe not be possible. Only someone with admin rights can do this (and you used Admin as I see below).
, a declined request can be revoked or accepted. That means the status of a request can be changed in any direction. Is it reasonable?
I think the declined -> accepted is reasonable. In case the submitter has discussed it afterwards and the receiver agreed to take it, because his decline reason is not an issue for whatever reasons. Looking at the code, it should actually not be possible to do direct switched from accepted to declined and vice versa. Also not for an Admin. I need to debug that later. (But possible via setting it back to new for example as intermediate state). This was implemented to make mistakes harder (like trying to accept some request twice).
2. Personal branch is deleted by accepting a handled request (either revoked/declined or revoked). Please see the below log, accepting a revoked/accepted request causes my branch 'home:Admin:branches:hello_test' to be deleted.
That should not happen indeed. But I fail to see how this can happen just by looking at the code. The entire code path for cleanup is below a "accepted" check. bye adrian
bash:~> osc list deleted hello_test home:Admin openSUSE:11.2 bash:~> osc request show -d 24 Request #24:
submit: home:Admin:branches:hello_test/hello_people(r1)(cleanup) -> hello_test/hello_people
Message: dummy submit
State: accepted 2010-05-12T13:55:29 Admin Comment: ok
History: accepted 2010-05-12T13:54:52 Admin accepted 2010-05-12T13:52:01 Admin revoked 2010-05-12T13:41:27 Admin revoked 2010-05-12T13:41:26 Admin revoked 2010-05-12T13:41:25 Admin revoked 2010-05-12T13:40:32 Admin revoked 2010-05-12T13:40:31 Admin revoked 2010-05-12T13:40:29 Admin revoked 2010-05-12T13:37:56 Admin revoked 2010-05-12T13:37:55 Admin revoked 2010-05-12T13:37:53 Admin new 2010-05-12T11:32:17 Admin
Server returned an error: HTTP Error 404: Not Found Diff not possible unknown package 'hello_people' in project 'home:Admin:branches:hello_test' bash:~> osc branch hello_test hello_people -m "ok" A working copy of the branched package can be checked out with:
osc co home:Admin:branches:hello_test/hello_people bash:~> osc list deleted hello_test home:Admin home:Admin:branches:hello_test openSUSE:11.2 bash:~> osc request accept -m ok 24 <status code="ok" />
bash:~> osc list deleted hello_test home:Admin openSUSE:11.2
---------------- Best Regards, Brook Hong
-- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org