Mailinglist Archive: opensuse-buildservice (213 mails)

< Previous Next >
Re: [opensuse-buildservice] rpmlint and {non-,}executable-crontab-file
  • From: Ludwig Nussel <ludwig.nussel@xxxxxxx>
  • Date: Tue, 2 Jun 2009 10:41:20 +0200
  • Message-id: <200906021041.20835.ludwig.nussel@xxxxxxx>
Christian wrote:
If I remove executable bits rpmlint complains about
"non-executable-crontab-file"
and vice-versa.

Could we please fix that.

Did you actually read the rpmlint message?

entreon.noarch: W: non-executable-script /etc/cron.d/centstorage 0644
centreon.noarch: W: non-executable-script /etc/cron.d/centreon 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed. If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

remove the #!/bin/sh in those files and the warning will disappear.

Also a glance at the spec file shows several issues not covered by any
automatic check:

194 echo $pre_version > /tmp/rpm_%{name}

Don't use world writeable directories for such hacks!

212 %{__cat} >> /etc/sudoers << EOF

*shudder* don't touch that file!

240 sed -i -e "s,@FQDN@,$(hostname -f)," -e "s,@ALIAS@,$(hostname -s), ...

This will cause DNS lookups during install. If at all use the value from
/etc/HOSTNAME instead.

cu
Ludwig

--
(o_ Ludwig Nussel
//\
V_/_ http://www.suse.de/
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg)
--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx

< Previous Next >
List Navigation
Follow Ups
References