Mailinglist Archive: opensuse-buildservice (249 mails)

< Previous Next >
[opensuse-buildservice] [Patch] support setting of different _target_arch
  • From: "Jan-Simon Möller" <dl9pf@xxxxxx>
  • Date: Thu, 30 Apr 2009 17:28:54 +0200
  • Message-id: <200904301728.55719.dl9pf@xxxxxx>
Hi !

In preparation to my GSoC project (openSUSE@arm) I'd like to propose this patch
of Build.pm for inclusion into the Build Service code.

===================================================================
--- Build.pm (Revision 7227)
+++ Build.pm (Arbeitskopie)
@@ -216,6 +216,9 @@
$config->{'patterntype'} = [ @l ];
} elsif ($l0 eq 'release:') {
$config->{'release'} = $l[0];
+ } elsif ($l0 eq 'changetargetarch:') {
+ @macros = grep {$_ !~ /^%define _target_cpu/ } @macros;
+ push @macros, "%define _target_cpu @l";
} elsif ($l0 !~ /^[#%]/) {
warn("unknown keyword in config: $l0\n");
}


Reasoning:
Some lines above in Build.pm %_target_arch gets set to the scheduler arch
(scheduler name).
In ARM world this is a bit more complicated - e.g. there's armv5tel, armv5tejl,
armv5tevl .

This is no problem in debian world IIRC as we see so far in Mer.
Unfortunately rpmbuild needs to know the right value (armv5tel instead of
armv5el).
It would be bad to use now different schedulers only for tel/tejl/tevl and so
on.

So with my patch we can use still the armv5el scheduler and differ through
"changetargetarch:" the _target_cpu where needed.

Best,
Jan-Simon



Index: Build.pm
===================================================================
--- Build.pm (Revision 7227)
+++ Build.pm (Arbeitskopie)
@@ -216,6 +216,9 @@
$config->{'patterntype'} = [ @l ];
} elsif ($l0 eq 'release:') {
$config->{'release'} = $l[0];
+ } elsif ($l0 eq 'changetargetarch:') {
+ @macros = grep {$_ !~ /^%define _target_cpu/ } @macros;
+ push @macros, "%define _target_cpu @l";
} elsif ($l0 !~ /^[#%]/) {
warn("unknown keyword in config: $l0\n");
}
< Previous Next >
This Thread
  • No further messages