Mailinglist Archive: opensuse-buildservice (239 mails)

< Previous Next >
[opensuse-buildservice] RFC: small patch for "osc commit" with big effect
  • From: Peter Poeml <poeml@xxxxxxx>
  • Date: Tue, 20 May 2008 15:04:06 +0200
  • Message-id: <20080520130406.GS5228@xxxxxxx>
Hi,

Index: osc/commandline.py
===================================================================
--- osc/commandline.py (revision 4001)
+++ osc/commandline.py (working copy)
@@ -1029,6 +1029,9 @@
${cmd_usage}
${cmd_option_list}
"""
+ if not opts.message and not opts.file:
+ sys.stderr.write('You didn\'t specify a commit message.\n'
+ 'In the future, this will be mandatory.\n')
msg = ''
if opts.message:
msg = opts.message



Later, giving a commit message (-m / -F) will be enforced.

What do people think about this? I think it is good, and I know some
that agree, and I haven't seen anyone disagreeing yet.

We can also make the messages mandatory right away, depending on what
you think...

Thanks,
Peter
--
"WARNING: This bug is visible to non-employees. Please be respectful!"

SUSE LINUX Products GmbH
Research & Development
< Previous Next >