Mailinglist Archive: opensuse-bugs (4655 mails)

< Previous Next >
[Bug 1042760] Added CMake files to AqBanking and Gwenhywfar
  • From: bugzilla_noreply@xxxxxxxxxx
  • Date: Sat, 17 Jun 2017 12:59:31 +0000
  • Message-id: <bug-1042760-21960-z04GrbQtoZ@http.bugzilla.opensuse.org/>
http://bugzilla.opensuse.org/show_bug.cgi?id=1042760
http://bugzilla.opensuse.org/show_bug.cgi?id=1042760#c11

--- Comment #11 from Wolfgang Bauer <wbauer@xxxxxx> ---
(In reply to Joachim Langenbach from comment #10)
I have tested it today and it seems to work.

Great!

But I noticed a possible mistake in the patch just now:
+// following the gnucash code, aqbnkaing prior 5.2 does support
+// identical functions, but per transaction type (sepa, debitnote, ...).
+// Therefore I disabled debug output before aqbanking 5.2
+#ifdef AQBANKING_VERSION_GREATER_5_2_0
qDebug() << "SetTransaction: " << AB_Job_SetTransaction(abJob,
abTransaction);
+#endif

Disabling this "debug output" also disables the call to
AB_Job_SetTransaction().

Is this intended? Might this not cause problems?

gnucash has this in gnc_ab_get_trans_job():
#ifdef AQBANKING_VERSION_GREATER_5_2_0
AB_Job_SetTransaction(job, ab_trans);
#else
switch (trans_type)
{
case SINGLE_DEBITNOTE:
AB_JobSingleDebitNote_SetTransaction(job, ab_trans);
break;
case SINGLE_INTERNAL_TRANSFER:
AB_JobInternalTransfer_SetTransaction(job, ab_trans);
break;
case SEPA_TRANSFER:
AB_JobSepaTransfer_SetTransaction(job, ab_trans);
break;
case SEPA_DEBITNOTE:
AB_JobSepaDebitNote_SetTransaction(job, ab_trans);
break;
case SINGLE_TRANSFER:
default:
AB_JobSingleTransfer_SetTransaction(job, ab_trans);
break;
};
#endif
(https://code.gnucash.org/docs/MASTER/group__AqBanking.html#ga4f0bc157ef6c46cf875e0c2d8cae59ad)

So I suppose the patch should call AB_JobSingleTransfer_SetTransaction(abJob,
abTransaction) or AB_JobSepaTransfer_SetTransaction(abjob, abTransaction) if
aqbanking <= 5.2.0? (see
https://build.opensuse.org/package/rdiff/home:wolfi323:branches:KDE:Extra/kmymoney?opackage=kmymoney&oproject=KDE%3AExtra&rev=5
)

I saw that you mentioned a problem with sending Sepa transfers on the kmymoney
mailinglist. That may very well be the reason...

I did that change in the package here, maybe you could try it?
http://download.opensuse.org/repositories/home:/wolfi323:/branches:/KDE:/Extra/

--
You are receiving this mail because:
You are on the CC list for the bug.
< Previous Next >
References