https://bugzilla.novell.com/show_bug.cgi?id=672491
https://bugzilla.novell.com/show_bug.cgi?id=672491#c26
Stanislav Brabec changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |ASSIGNED
InfoProvider|sbrabec@novell.com |
--- Comment #26 from Stanislav Brabec 2011-03-15 17:05:27 CET ---
I just looked at cdrtools-2.01(released Sep 8 2004 by Joerg Schilling). It
contains following header:
* Copyright 1998-2002 by Heiko Eissfeldt
* Copyright 2002 by Joerg Schilling
*
* This file contains protected intellectual property.
*
* reed-solomon encoder / decoder for compact discs.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2, or (at your option)
* any later version.
So it seems to be the implementation legally usable with any GPL code. As it
was released by Joerg, I expect that the GPL clause there is correct and legal.
Then I looked into cdrtools-3.01a03. The new code is released under CDDL. It
contains a lot of added code, but the code in question is very similar. I see
formatting changes and several small fixes (one or two lines change).
Comparing with vcdimager-0.7.23 (released Jul 11 2005 by Rocky Bernstein), file
sector.c and included files, last modified Oct 25, 2004, the code looks a bit
similar to the cdrtools-2.01. I don't have the original code of the first
implementation, but I guess that it may be just that one.
In particular:
build_address(): ported to libcdio.
Equal implementation, very minor changes: build_edc(), encode_L2_Q(),
encode_L2_P()
Different implementation: do_encode_L2()
Unique in sector.c: _vcd_make_mode2() _vcd_make_raw_mode2() (probably
vcdimager-specific)
sector.c contains following header:
Copyright (C) 2000 Herbert Valerio Riedel
(C) 1998 Heiko Eissfeldt
portions used & Chris Smith
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
Comparing with cdrkit-1.1.11 (released Oct 18 2010 by Steve McIntyre):
Comparing with cdrtools-2.01, I see no single line of a real code change. I
just see formatting and declaration changes (macro __PR added, register
declarations, width of particular integers). The only important change there is
removal of "or (at your option) any later version" from the GPL sentence. They
apparently just took old the GPL version of this code.
Fixes from CDDL licensed libedc seems to not be imported to any of these two
projects.
Note:
Guessing from the discussion above, use of CDDL licensed code inside
vcdimager/cdrkit would be possible if vcdimager/cdrkit developers write an
additional permission to link their GPL code with a non-GPL code (we did the
same with openssl) either externally (changing vcdimager license to
GPL+permission) or internally (changing vcdimager license to GPL+permission
combined with CDDL (with permission, if needed))
Another possibility would be just took the GPL version of libedc and replace
files inside vcdimager with those files.
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.