http://bugzilla.novell.com/show_bug.cgi?id=543472 Summary: festival-1.96-121.11: possible missing call to fclose Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package festival-1.96-121.11 source code file speech_tools/main/pitchmark_main.cc function save_ogi_bin local variable fp. I notice the following code if (fwrite(d, pm.num_frames(), sizeof(int), fp) != 1) { fclose(fp); return misc_write_error; } delete d; return write_ok; so the file only gets closed on failure. Suggest add call to fclose on success, just before the return write_ok line. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.