http://bugzilla.novell.com/show_bug.cgi?id=515559 Summary: nss-ldapd-0.6.8-1.6: possible off by one error Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just tried to compile factory package nss-ldapd-0.6.8-1.6 The compiler said passwd.c:347:11: warning: array subscript is above array bounds The source code is for (numuids=0;(numuids<=MAXUIDS_PER_ENTRY)&&(tmpvalues[numuids]!=NULL);numuids++) { uids[numuids]=(uid_t)strtol(tmpvalues[numuids],&tmp,0); so numuids can have the value MAXUIDS_PER_ENTRY. But uid_t uids[MAXUIDS_PER_ENTRY]; Hence the compiler complain. Suggest code rework. Maybe for (numuids=0;(numuids < MAXUIDS_PER_ENTRY)&&(tmpvalues[numuids]!=NULL);numuids++) would be enough. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.