https://bugzilla.novell.com/show_bug.cgi?id=300340#c14
Thomas Renninger changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |coolo@novell.com
--- Comment #14 from Thomas Renninger 2007-08-24 02:54:37 MST ---
This is a real [sb]ad situation.
I am not sure whether we should really backport this change.
Some things I found in patch from comment #9:
1) don't do this change:
- if (ibm_thinkpad_ec_found && experimental) {
+ if (thinkpad_id.ec_model) {
it seems to be thermal related and unrelated to the brightness stuff.
Only change the ec_found variable to the newly declared one and still
add the && experimental
2) don't add those:
+ u16 input_device_registered:1;
+ u16 platform_drv_registered:1;
+ u16 platform_drv_attrs_registered:1;
the first is unused, the latter two come from another patch, which should
also go in (done that already, it's a real short fix)
3) Free strings allocated with kstrdup in newly added init in module exit
func:
+ kfree(thinkpad_id.bios_version_str);
+ kfree(thinkpad_id.ec_version_str);
+ kfree(thinkpad_id.model_str);
I am really unsure whether we should take the risk. If we take it, it should be
added soon.
I'll post my reworked patch. I am also off for holidays -> someone else need to
comit this, Pavel or Andi? -> better give this another review before...
We should add some project manager to get an approval for this -> adding coolo
for now.
Coolo: how important is brightness control on Lenovos?
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.