Mailinglist Archive: opensuse-bugs (8114 mails)

< Previous Next >
[Bug 246573] “-fd” option doesn't work in xterm
  • From: bugzilla_noreply@xxxxxxxxxx
  • Date: Tue, 20 Feb 2007 05:07:37 -0700 (MST)
  • Message-id: <20070220120737.50C5FF8F@xxxxxxxxxxxxxxxxxxxxxx>
https://bugzilla.novell.com/show_bug.cgi?id=246573





------- Comment #35 from mfabian@xxxxxxxxxx 2007-02-20 05:07 MST -------
I had an idea to improve the patch (improved version attached is to
comment #34):

Adding "face_name" again to the pattern if it is already there doesn't
hurt of course, but it doesn't have any advantage either. So why not
add something to the pattern which is a nice fallback? I got this
idea because the code for the single width font does exactly that, it
adds "monospace", i.e. when the font specified with "-fa foo" doesn't
exist, "monospace" is used as a fallback, which is usually good.

So why not do that for the double width font as well? When one is
running in a CJK locale, "monospace" will expand to a good monospace
font for the CJK locale, i.e. with that improved patch one can omit
the "-fd" option and it will still work nicely as long as one is
running in a CJK locale.

I can see a slight disadvantage though:

If running in a non-CJK locale, for example en_US.UTF-8,

xterm -fa courier

will open an extra font because of the "-fd monospace" default if the
result of "fc-match monospace" happens to be different from the font
given behind "-fa" (I can see that in the strace).

Opening this extra font is usually completely useless in that case
because "fc-match monospace" usually doesn't expand to a CJK monospace
font unless one is running in a CJK locale.

But that is probably not a valid reason against using "monospace" as
the default for "-fd" because this looks like another bug to me: If
the font which is going to be opened for double width does not support
double width at all, it would be nice not to open it because it is
useless anyway (If the user specified such a font with "-fd" on the
command line, maybe one should even print a warning). There seems to
be code in xterm to check that (function is_double_width_font_xft()),
maybe this code is not yet perfect.


--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

< Previous Next >
References