https://bugzilla.novell.com/show_bug.cgi?id=236139 ------- Comment #3 from andreas.hanke@gmx-topmail.de 2007-01-18 10:12 MST ------- The thing about %makeinstall is a bit complex. Upstream %makeinstall is "make install prefix=%buildroot%_prefix bindir=%buildroot%_bindir libdir=%buildroot%_libdir" etc... It will for sure result in broken files (.la files, in particular) which have the value of %buildroot encoded somewhere. On SUSE systems, %makeinstall is therefore re-defined to do "make install DESTDIR=%buildroot". This means that for SUSE, it's safe. But the spec file becomes non-portable because it won't work correctly on other systems. See also: http://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0... If you're building for SUSE only, it's just a matter of personal preference (I don't like it, but it doesn't break anything). But if you're using the spec files to build packages for other distros in the BS, please don't use it, it will produce broken packages. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.