https://bugzilla.novell.com/show_bug.cgi?id=183735 ------- Comment #26 from sh@novell.com 2006-09-20 05:42 MST ------- The Zypp::PoolItemStatus contains a flag "isNeeded". This is what should be evaluated here (but is not accessible to the UI). AFAICS this is not exactly what y2-ncurses does here - it only suppresses displaying patches that are already installed: bool PackageSelector::checkPatch( ZyppPatch patchPtr, ZyppSel selectable, string filter ) { ... if ( filter == "all" || ( filter == "installed" && selectable->status() == S_KeepInstalled ) // FIXME Is filter installable correct? There was a method installable() before. Condition was: // ( patchPtr->installable() && patchPtr->getSelectable()->status() != PMSelectable::S_KeepInstalled ) || ( filter == "installable" && ( selectable->status() != S_KeepInstalled ) ) || ( filter == "new" && ( selectable->status() == S_Install || selectable->status() == S_NoInst ) ) || ( filter == "security" && patchPtr->category() == "security" ) || ( filter == "recommended" && patchPtr->category() == "recommended" ) || ( filter == "optional" && patchPtr->category() == "optional" ) || ( filter == "YaST2" && patchPtr->category() == "yast" ) ) ... } But this is not the intent of what is needed here. We want to display those patches that make sense for the user to install - i.e., those for which he has any package installed. If you don't have OOo installed, you don't want to get or even see any OOo patch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.