[obs-commits] [openSUSE/open-build-service] 2958d8: [api] Use pundit authorization API attribute contr...

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 2958d80e78dadfc0d63fa284f5fb4a9afebd9333 https://github.com/openSUSE/open-build-service/commit/2958d80e78dadfc0d63fa2... Author: Björn Geuken Date: 2017-03-08 (Wed, 08 Mar 2017) Changed paths: M src/api/app/controllers/attribute_controller.rb Log Message: ----------- [api] Use pundit authorization API attribute controller (POST requests) Commit: 64b5a04886f274377ddc4aed08974f7b36bc8b03 https://github.com/openSUSE/open-build-service/commit/64b5a04886f274377ddc4a... Author: Manuel Schnitzer Date: 2017-03-08 (Wed, 08 Mar 2017) Changed paths: A src/api/app/policies/attrib_type_policy.rb Log Message: ----------- [api] Introduce attrib type pundit policy Commit: e1b9417bb8b0055b1b482fad778fbd9fbfabecd3 https://github.com/openSUSE/open-build-service/commit/e1b9417bb8b0055b1b482f... Author: Manuel Schnitzer Date: 2017-03-08 (Wed, 08 Mar 2017) Changed paths: M src/api/app/controllers/application_controller.rb Log Message: ----------- [api] Change pundit exception message It gives the user more information about what causes the exception. Commit: 39f911d103478aab75fab778d0ff4f14ff4a6cc7 https://github.com/openSUSE/open-build-service/commit/39f911d103478aab75fab7... Author: Manuel Schnitzer Date: 2017-03-08 (Wed, 08 Mar 2017) Changed paths: M src/api/test/functional/attributes_test.rb Log Message: ----------- [ci] Fix attribute test Before we tested for the deletion of non-existant attribute. Now we're testing if the user is allowed to delete existing attribute types. Commit: de3cdc0a3c7001a4d14d61aba949a50663e38bdb https://github.com/openSUSE/open-build-service/commit/de3cdc0a3c7001a4d14d61... Author: Manuel Schnitzer Date: 2017-03-08 (Wed, 08 Mar 2017) Changed paths: M src/api/app/controllers/attribute_controller.rb M src/api/app/models/attrib.rb A src/api/spec/models/attrib_spec.rb Log Message: ----------- [api] Use better way to set container object for attributes Before we had this logic in our controller. This code should belong to the model and cleans up the controller. Commit: e651467912c472beb238161f1a286849651e336e https://github.com/openSUSE/open-build-service/commit/e651467912c472beb23816... Author: Manuel Schnitzer Date: 2017-03-08 (Wed, 08 Mar 2017) Changed paths: M src/api/app/controllers/attribute_controller.rb Log Message: ----------- [api] Validate Attrib before permission check This commits brings back the old API behaviour. The old API was validating the attribute and its values before running the permission checks. To make this possible we have to process all attribute values first and validate the attribute. Commit: 7c9560dafda1708caff6a7e7c534637b149d188f https://github.com/openSUSE/open-build-service/commit/7c9560dafda1708caff6a7... Author: Björn Geuken Date: 2017-03-08 (Wed, 08 Mar 2017) Changed paths: M src/api/test/functional/issue_controller_test.rb Log Message: ----------- [ci] Fix test IssueControllerTest#test_get_issue_for_linked_packages In our test environment only fred, king and Admin are allowed to add the Issue Attribute to a project. Because of that the test failure was correct and we had to adopt our test suite by: * Verifying that users that lack permissions are not allowed to add Attributes to a project * Users that are permitted via role permissions are allowed to add an Attribute Commit: 7a85a3fdaff99c68fcd034af115304d14f104f4e https://github.com/openSUSE/open-build-service/commit/7a85a3fdaff99c68fcd034... Author: Manuel Schnitzer Date: 2017-03-08 (Wed, 08 Mar 2017) Changed paths: M src/api/test/functional/maintenance_test.rb Log Message: ----------- [ci] Fix test failure in API test (maintenance_test.rb) The old test was not correct and the user never had the correct permissions. So we needed to fix the old test case and tested for the correct response code (:forbidden). Commit: 912d01aa82b8be7fa41879f2ed85e30d5a8f3278 https://github.com/openSUSE/open-build-service/commit/912d01aa82b8be7fa41879... Author: Björn Geuken Date: 2017-03-08 (Wed, 08 Mar 2017) Changed paths: M src/api/test/functional/maintenance_test.rb Log Message: ----------- [ci] Allow maintenance_coord user to change EmbargoDate Commit: dfd5b2d6d27bce1ca4ecff37e32bc36c7b492fa8 https://github.com/openSUSE/open-build-service/commit/dfd5b2d6d27bce1ca4ecff... Author: Björn Geuken Date: 2017-03-08 (Wed, 08 Mar 2017) Changed paths: M src/api/test/functional/maintenance_test.rb Log Message: ----------- [ci] Group embargo date related tests together * Group setting embargo date and testing it together * Add iand update comments to help understanding the code Commit: 18917f6a171cc0366da991f066265f82879239de https://github.com/openSUSE/open-build-service/commit/18917f6a171cc0366da991... Author: Manuel Schnitzer Date: 2017-03-08 (Wed, 08 Mar 2017) Changed paths: M src/api/test/functional/source_controller_test.rb Log Message: ----------- [ci] Fix broken test in functional/source_controller_test.rb The test passed before but since the new implementation of the Attrib policy, it responds with a 403 permission denied error (which makes sense because the user 'adrian' doesn't have any permission to change that attribute) Commit: e85743c6ab0e0035f6de45a9a48449c6aedd0ce2 https://github.com/openSUSE/open-build-service/commit/e85743c6ab0e0035f6de45... Author: Björn Geuken Date: 2017-03-08 (Wed, 08 Mar 2017) Changed paths: M src/api/test/unit/code_quality_test.rb Log Message: ----------- [ci] Update code quality test Remove methods that became less complex from blacklist Commit: 8cb06cbf2833fe68c6198425fbc0673d89559d9f https://github.com/openSUSE/open-build-service/commit/8cb06cbf2833fe68c61984... Author: Henne Vogelsang Date: 2017-03-08 (Wed, 08 Mar 2017) Changed paths: M src/api/app/controllers/application_controller.rb M src/api/app/controllers/attribute_controller.rb M src/api/app/models/attrib.rb A src/api/app/policies/attrib_type_policy.rb A src/api/spec/models/attrib_spec.rb M src/api/test/functional/attributes_test.rb M src/api/test/functional/issue_controller_test.rb M src/api/test/functional/maintenance_test.rb M src/api/test/functional/source_controller_test.rb M src/api/test/unit/code_quality_test.rb Log Message: ----------- Merge pull request #2778 from bgeuken/pundit_2017-03-02 Introduce Pundit authorization to Attrib-API Compare: https://github.com/openSUSE/open-build-service/compare/b8e933ed1905...8cb06c...