Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 2e48728e1542f5fe3f614cedf3239a86b9e1135e
https://github.com/openSUSE/open-build-service/commit/2e48728e1542f5fe3f614c...
Author: Ana María Martínez Gómez
Date: 2016-10-19 (Wed, 19 Oct 2016)
Changed paths:
M src/api/app/models/bs_request_permission_check.rb
Log Message:
-----------
Solve bug due to operator precedence
Solve the bug that @mdeniz pointed out in https://github.com/openSUSE/open-build-service/pull/2241 cause for having misinterpreted the operator precedence. `&&` has higher precedence than `=` which has higher precendence than `and`.
So here (https://github.com/openSUSE/open-build-service/pull/2241/files#diff-ad86da52...) it was written like that:
ignoreLock = opts[:force] and [:set_bugowner].include? action.action_type
but it should be any of the next equivalent lines:
ignoreLock = (opts[:force] and [:set_bugowner].include? action.action_type)
ignoreLock = opts[:force] && [:set_bugowner].include? action.action_type
It was not needed to use include? neither.
Commit: 4b26f74d18d907b192beb994a0a8aaab52d37f14
https://github.com/openSUSE/open-build-service/commit/4b26f74d18d907b192beb9...
Author: Björn Geuken
Date: 2016-10-19 (Wed, 19 Oct 2016)
Changed paths:
M src/api/app/models/bs_request_permission_check.rb
Log Message:
-----------
Merge pull request #2245 from Ana06/bug
Solve bug due to operator precedence
Compare: https://github.com/openSUSE/open-build-service/compare/1994c8932dc9...4b26f7...
