Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 1a432481e5d9d3e1e1a02d49c2a3f2d754b93512
https://github.com/openSUSE/open-build-service/commit/1a432481e5d9d3e1e1a02d...
Author: Viktar Basharymau
Date: 2015-09-27 (Sun, 27 Sep 2015)
Changed paths:
M src/api/app/models/user.rb
Log Message:
-----------
Simplify fetching of titles of old globalroles
This commit also makes it faster
Commit: 0d98b7fd0931dde9fc5bacfd9e892b69f18c67eb
https://github.com/openSUSE/open-build-service/commit/0d98b7fd0931dde9fc5bac...
Author: Viktar Basharymau
Date: 2015-09-27 (Sun, 27 Sep 2015)
Changed paths:
M src/api/app/models/user.rb
Log Message:
-----------
Simplify `{add_to,remove_from}_globalroles` assignments
Commit: d28fe6ccfd668da6b9c0dbc328c0297c483a3451
https://github.com/openSUSE/open-build-service/commit/d28fe6ccfd668da6b9c0db...
Author: Viktar Basharymau
Date: 2015-09-27 (Sun, 27 Sep 2015)
Changed paths:
M src/api/app/models/user.rb
Log Message:
-----------
Fix N+1 query when deleting role_users in User#update_globalroles
Commit: 15120ef81f75dd28a41c57b70541279d3603fce8
https://github.com/openSUSE/open-build-service/commit/15120ef81f75dd28a41c57...
Author: Viktar Basharymau
Date: 2015-09-27 (Sun, 27 Sep 2015)
Changed paths:
M src/api/app/models/user.rb
Log Message:
-----------
Fix N+1 query when adding role_users in User#update_globalroles
Commit: 424c93d18d0ac768abbd81a39d4c6c1348e7fe40
https://github.com/openSUSE/open-build-service/commit/424c93d18d0ac768abbd81...
Author: Viktar Basharymau
Date: 2015-09-27 (Sun, 27 Sep 2015)
Changed paths:
M src/api/app/models/user.rb
Log Message:
-----------
Move variable assignments closer to their use site
Commit: f5195ffacc3455a9fc90a786ba2000529ae949f3
https://github.com/openSUSE/open-build-service/commit/f5195ffacc3455a9fc90a7...
Author: Viktar Basharymau
Date: 2015-09-27 (Sun, 27 Sep 2015)
Changed paths:
M src/api/app/models/user.rb
Log Message:
-----------
Extract remove_globalroles method
Also remove explaining comment since method name
clearly explains what is going on.
Commit: 7f64a3e218e63222c0ed452e117eb0fafe65e458
https://github.com/openSUSE/open-build-service/commit/7f64a3e218e63222c0ed45...
Author: Viktar Basharymau
Date: 2015-09-27 (Sun, 27 Sep 2015)
Changed paths:
M src/api/app/models/user.rb
Log Message:
-----------
Extract add_globalroles method
Also remove explaining comment since method name
clearly explains what is going on.
Commit: 6246342e074a4fd1aac458d01a3e928d28714ce4
https://github.com/openSUSE/open-build-service/commit/6246342e074a4fd1aac458...
Author: Viktar Basharymau
Date: 2015-09-27 (Sun, 27 Sep 2015)
Changed paths:
M src/api/app/models/user.rb
Log Message:
-----------
Inline remove_from_globalroles and add_to_globalroles
These variables add nothing to redability
Commit: 069a64c8ae3c6fe8d1b0ef09569c42206ab37bc2
https://github.com/openSUSE/open-build-service/commit/069a64c8ae3c6fe8d1b0ef...
Author: Björn Geuken
Date: 2015-10-04 (Sun, 04 Oct 2015)
Changed paths:
M src/api/app/models/user.rb
Log Message:
-----------
Merge pull request #1176 from DNNX/update_globalroles
Refactor `User#update_globalroles` method
Compare: https://github.com/openSUSE/open-build-service/compare/4431cbbe0169...069a64...