On Thu, Jun 29, 2017 at 02:39:56PM +0200, Christian Boltz wrote:
The SR to security:logging:elma probably makes sense - I'll do that in the next days.
Do I need to follow the link chain (which would mean to ask Andrew to do the SR), or can I send the SR directly to security:logging:elma without breaking the linked packages in between?
Do it directly, we couldn't care less about andrew's fork or about the :devel repo
Let me try a summary answer ;-)
I took the package from Andrew's home repo because it was clearly the best updated I could get. I only did a minor version update which means I only touched the version number in the spec. For everything else, please blame the previous packagers ;-)
As already mentioned elsewhere, elasticsearch 1.x is EOL (but MediaWiki 1.27.x unfortunately still requires this version), so I'd prefer not to waste time on this package ;-)
For newer elasticsearch versions, there are already separate packages, so improvements in the 1.x package won't improve the newer packages automatically.
That said - if you still think I should spend time on this package and/ or answer your comments in detail, please tell me ;-)
At least the useradd/groupadd commands should be fixed, as removing the user is a security issue. Imagine the case where the user gets removed, and there are still files owned by that user. A new user takes over this userid and owns those files now.
The commented out Requires and Conflicts basically mean differences to the package in server:php:applications (which I used as a base, but it was too different from my needs to just use it).
You still don't need comments, osc rdiff can provide you this.
- mediawiki gets installed in /usr/share/mediawiki-1_27, how are you handling it in production? copying it somewhere or using it from there directly?
Does salt/profile/wiki/docroot.sls answer your question? ;-)
TL;DR: the document root is in /srv/www/$wiki/public/, and I let salt create symlinks to /usr/share/mediawiki_1_27/ there.
Nice, I like it!
--
Theo Chatzimichos