[zypp-devel] selecting patches by issue
Patches now have bugzilla and security metadata. I already added support for displaying them in the user interface. However I am thinking on zypper now. An user may want to say zypper "install the fix for bugzlla 3223". We have 2 ways to implement this, and I would like to hear your feedback: - use the current metadata to search for the issue and mark packages for install. This will need some "look" code in each application. - Use the solver, and during parsing inject something like provides:fix(bugzilla:23444) when filling the repodata. Then applications could inject a requires in the solver fix(bugzilla:23444) and just solve. I dont't know the consequences of this. - Any other idea? Duncan -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
Duncan Mac-Vicar Prett napsal(a):
Patches now have bugzilla and security metadata. I already added support for displaying them in the user interface. However I am thinking on zypper now.
An user may want to say zypper "install the fix for bugzlla 3223".
We have 2 ways to implement this, and I would like to hear your feedback:
- use the current metadata to search for the issue and mark packages for install. This will need some "look" code in each application.
Add to libzypp method which can install/uninstall query. something like in locks (addLock(query)) so install(query). frontend only fill query and send that want install result of it. So "look" code can be really short. Pepa
- Use the solver, and during parsing inject something like provides:fix(bugzilla:23444) when filling the repodata. Then applications could inject a requires in the solver fix(bugzilla:23444) and just solve. I dont't know the consequences of this. - Any other idea?
Duncan
-- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
josef reidiner wrote:
Add to libzypp method which can install/uninstall query. something like in locks (addLock(query)) so install(query). frontend only fill query and send that want install result of it. So "look" code can be really short.
I think this is a really good idea. Duncan -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
On Mon, Apr 14, 2008 at 02:04:55PM +0200, josef reidiner wrote:
Duncan Mac-Vicar Prett napsal(a):
Patches now have bugzilla and security metadata. I already added support for displaying them in the user interface. However I am thinking on zypper now. An user may want to say zypper "install the fix for bugzlla 3223". We have 2 ways to implement this, and I would like to hear your feedback: - use the current metadata to search for the issue and mark packages for install. This will need some "look" code in each application.
Add to libzypp method which can install/uninstall query. something like in locks (addLock(query)) so install(query). frontend only fill query and send that want install result of it. So "look" code can be really short.
"Uninstall all packages with careless maintainers" ;-) zypper rm `zypper se --search-descriptions teh` zypper in -t patch `zypper se -d -t patch BNC#38810` Well OK, we would need to remove the formatting from the search output...
Pepa
- Use the solver, and during parsing inject something like provides:fix(bugzilla:23444) when filling the repodata. Then applications could inject a requires in the solver fix(bugzilla:23444) and just solve. I dont't know the consequences of this.
It is cleaner than having to search the free form description. Now that I think of it, having the patch metadata in a form different from Provides seems wrong, because that only forces you to write new code for what is served by Provides better. -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
Hi, On Mon, 14 Apr 2008, Martin Vidner wrote:
- Use the solver, and during parsing inject something like provides:fix(bugzilla:23444) when filling the repodata. Then applications could inject a requires in the solver fix(bugzilla:23444) and just solve. I dont't know the consequences of this.
It is cleaner than having to search the free form description. Now that I think of it, having the patch metadata in a form different from Provides seems wrong, because that only forces you to write new code for what is served by Provides better.
I disagree. A provides is (at best) something which another entity can require. A provide should not be misused to ease searching. You can equally well define an fixed format for other random data, e.g. we could have attributes 'patch:fixes = "bnc#12345"', if we absolutely must. Ciao, Michael. -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
Hi, On Mon, 14 Apr 2008, Duncan Mac-Vicar Prett wrote:
An user may want to say zypper "install the fix for bugzlla 3223".
We have 2 ways to implement this, and I would like to hear your feedback:
- use the current metadata to search for the issue and mark packages for install. This will need some "look" code in each application.
It will simply require a query.
- Use the solver, and during parsing inject something like provides:fix(bugzilla:23444) when filling the repodata. Then applications could inject a requires in the solver fix(bugzilla:23444) and just solve. I dont't know the consequences of this.
I don't think this would be a good idea. Ciao, Michael. -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
On Mon, Apr 14, 2008 at 02:18:23PM +0200, Michael Matz wrote:
On Mon, 14 Apr 2008, Duncan Mac-Vicar Prett wrote:
- Use the solver, and during parsing inject something like provides:fix(bugzilla:23444) when filling the repodata. Then applications could inject a requires in the solver fix(bugzilla:23444) and just solve. I dont't know the consequences of this.
I don't think this would be a good idea.
Why? Because of flooding the solver with unnecessary data? We do that all the time with autoprovides don't we? -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
On Mon, Apr 14, 2008 at 02:58:18PM +0200, Martin Vidner wrote:
On Mon, Apr 14, 2008 at 02:18:23PM +0200, Michael Matz wrote:
On Mon, 14 Apr 2008, Duncan Mac-Vicar Prett wrote:
- Use the solver, and during parsing inject something like provides:fix(bugzilla:23444) when filling the repodata. Then applications could inject a requires in the solver fix(bugzilla:23444) and just solve. I dont't know the consequences of this.
I don't think this would be a good idea.
Why? Because of flooding the solver with unnecessary data? We do that all the time with autoprovides don't we?
I'm also against it because I think the user should be able to read the contraindications and description of the patch. So magically installing some patch doesn't sound like the way to go. M. -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
Hi, On Mon, 14 Apr 2008, Martin Vidner wrote:
On Mon, Apr 14, 2008 at 02:18:23PM +0200, Michael Matz wrote:
On Mon, 14 Apr 2008, Duncan Mac-Vicar Prett wrote:
- Use the solver, and during parsing inject something like provides:fix(bugzilla:23444) when filling the repodata. Then applications could inject a requires in the solver fix(bugzilla:23444) and just solve. I dont't know the consequences of this.
I don't think this would be a good idea.
Why?
Conceptual inelegance always hints at some real problem hiding :)
Because of flooding the solver with unnecessary data?
For instance. And because it is no provide :) I also would fear that, should we implement this as provides, someone goes and thinks it would be a good idea to add heaps and heaps of such virtual provides also to normal packages, whenever they fix some bug. Then there's the problem how to _really_ model this as provides in the solver sense. E.g. what if a bugfix needs two packages? Making them both provide fix(bla) would still require only one of them to be fulfilled. No, I don't think we should try to force this piece of information into the solver corset. Make it easily searchable (we have that already), and expose this to the user.
We do that all the time with autoprovides don't we?
In a way, yes. But we shouldn't follow bad examples, should we? Ciao, Michael. -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
* Duncan Mac-Vicar Prett
Patches now have bugzilla and security metadata. I already added support for displaying them in the user interface. However I am thinking on zypper now.
An user may want to say zypper "install the fix for bugzlla 3223".
We have 2 ways to implement this, and I would like to hear your feedback:
- use the current metadata to search for the issue and mark packages for install. This will need some "look" code in each application.
This seems the right implementation, esp. when this information is properly provided in the <references> list.
- Use the solver, and during parsing inject something like provides:fix(bugzilla:23444) when filling the repodata.
Although this looks nice, I fear it won't scale to other bugzillas or other bug reporting tools resp. ids (i.e. CVEs). Klaus -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
participants (6)
-
Duncan Mac-Vicar Prett -
josef reidiner -
Klaus Kaempf -
Martin Vidner -
Michael Matz -
Michael Schroeder