[zypp-devel] messages and scripts
mlandres@svn.opensuse.org wrote:
Modified: trunk/libzypp/zypp/sat/SolvAttr.cc URL: http://svn.opensuse.org/viewcvs/zypp/trunk/libzypp/zypp/sat/SolvAttr.cc?rev=10414&r1=10413&r2=10414&view=diff ============================================================================== --- trunk/libzypp/zypp/sat/SolvAttr.cc (original) +++ trunk/libzypp/zypp/sat/SolvAttr.cc Thu Jun 19 18:28:41 2008 @@ -73,7 +73,8 @@ - const SolvAttr SolvAttr::message ( UPDATE_MESSAGE ); +#warning fix if UPDATE_MESSAGE is ported to satsolver + const SolvAttr SolvAttr::message ( "update:message" /*UPDATE_MESSAGE*/ );
I adapted zypper and wanted to test the messages, but i couldn't figure out where/how to put them in the metadata. So i guess this means they are not read at all in sat solver yet? (and do they belong to updateinfo.xml? they're not in rnc anywhere, only in the old patch.rnc). Scripts work fine, just one question: seems the current implementation only uses OUTPUT in the progress callback. If it were to use also PING, what would be the way to determine what kind of progress reporting from the script to use? cheers, jano -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
On Fri, Jun 20, Jan Kupec wrote:
mlandres@svn.opensuse.org wrote:
Modified: trunk/libzypp/zypp/sat/SolvAttr.cc URL: http://svn.opensuse.org/viewcvs/zypp/trunk/libzypp/zypp/sat/SolvAttr.cc?rev=10414&r1=10413&r2=10414&view=diff ============================================================================== --- trunk/libzypp/zypp/sat/SolvAttr.cc (original) +++ trunk/libzypp/zypp/sat/SolvAttr.cc Thu Jun 19 18:28:41 2008 @@ -73,7 +73,8 @@ - const SolvAttr SolvAttr::message ( UPDATE_MESSAGE ); +#warning fix if UPDATE_MESSAGE is ported to satsolver + const SolvAttr SolvAttr::message ( "update:message" /*UPDATE_MESSAGE*/ );
I adapted zypper and wanted to test the messages, but i couldn't figure out where/how to put them in the metadata. So i guess this means they are not read at all in sat solver yet? (and do they belong to updateinfo.xml? they're not in rnc anywhere, only in the old patch.rnc).
Looks like not all libzypp/satsolver changes from the 11.0 branch were also appplied to trunk. We have to check what's still missing ;( In 11.0 messages are parsed from updateinfo.xml into the solvfile. Similar to description: <message>some message</message> <description>This version upgrade blablabla...</description>
Scripts work fine, just one question: seems the current implementation only uses OUTPUT in the progress callback. If it were to use also PING, what would be the way to determine what kind of progress reporting from the script to use?
Progress is reported whenever the script writes a line to stdout/stderr. If the script is quiet for 5 minutes, you don't get progress report for 5 minutes. A user request to abort execution is provided via the progress reports return value. Thus no report ==> no abort So waiting for scrip output needs to be non-blocking, and we will then send a PING in case there is no output for x seconds. This may or may not trigger some visible gimmick in the application. The main purpose is to get back a pending abort request. So report will be a mixture of output and pings. -- cu, Michael Andres +------------------------------------------------------------------+ Key fingerprint = 2DFA 5D73 18B1 E7EF A862 27AC 3FB8 9E3A 27C6 B0E4 +------------------------------------------------------------------+ Michael Andres YaST Development ma@novell.com SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) Maxfeldstrasse 5, D-90409 Nuernberg, Germany, ++49 (0)911 - 740 53-0 +------------------------------------------------------------------+ -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
participants (2)
-
Jan Kupec
-
Michael Andres