[zypp-devel] Re: [zypp-commit] r10066 - in /trunk/sat-solver: package/libsatsolver.changes src/solvable.c
On Tue, May 13, 2008 at 10:24:57AM -0000, dmacvicar@svn.opensuse.org wrote:
Author: dmacvicar Date: Tue May 13 12:24:57 2008 New Revision: 10066
URL: http://svn.opensuse.org/viewcvs/zypp?rev=10066&view=rev Log: a boolean is not a num attribute set to 1, but just a existing void attribute. (bnc#388818)
Then could we please get rid of the solvable_lookup_bool function? Michael. -- Michael Schroeder mls@suse.de SUSE LINUX Products GmbH, GF Markus Rex, HRB 16746 AG Nuernberg main(_){while(_=~getchar())putchar(~_-1/(~(_|32)/13*2-11)*13);} -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
Michael Schroeder wrote:
On Tue, May 13, 2008 at 10:24:57AM -0000, dmacvicar@svn.opensuse.org wrote:
Author: dmacvicar Date: Tue May 13 12:24:57 2008 New Revision: 10066
URL: http://svn.opensuse.org/viewcvs/zypp?rev=10066&view=rev Log: a boolean is not a num attribute set to 1, but just a existing void attribute. (bnc#388818)
Then could we please get rid of the solvable_lookup_bool function?
Michael.
I would do the opposite, add repodata_set_bool so we don't expose the implementation on how we store bools. Also makes code readable, as repodata_set_void in tools/ is not readable, because it is a trick, not an intention. Duncan -- To unsubscribe, e-mail: zypp-devel+unsubscribe@opensuse.org For additional commands, e-mail: zypp-devel+help@opensuse.org
participants (2)
-
Duncan Mac-Vicar Prett -
Michael Schroeder