Hi, about a week ago I removed usaging libxcrypt from yast2-core. I also removed the Buildrequires in all YaST packages but did not make new packages due to time limitations. Now libxcrypt was dropped in Factory. Please check whether that makes your packages fail and if so create new ones for the buildservice. ciao Arvin -- Arvin Schnell, <aschnell@suse.de> Senior Software Engineer, Research & Development SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstraße 5 90409 Nürnberg Germany -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Dne Po 26. března 2012 14:17:09, Arvin Schnell napsal(a):
Hi,
about a week ago I removed usaging libxcrypt from yast2-core. I also removed the Buildrequires in all YaST packages but did not make new packages due to time limitations.
Now libxcrypt was dropped in Factory. Please check whether that makes your packages fail and if so create new ones for the buildservice.
Not really related, but still: some packages currently do not build because of failing testsuites. This is (at least partly) because of Gabi's change in FileUtils::Exists which now returns true only when .target.stat returns non- empty map. Some of our testuites rely on default (nil) value of .target.stat and expect FileUtils::Exists to return true. So please check as well if this is not a case for your modules. Jiri -- Jiri Suchomel SUSE LINUX, s.r.o. e-mail: jsuchome@suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Praha 9, Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On 03/26/2012 02:40 PM, Jiri Suchomel wrote:
Dne Po 26. března 2012 14:17:09, Arvin Schnell napsal(a): Not really related, but still: some packages currently do not build because of failing testsuites. This is (at least partly) because of Gabi's change in FileUtils::Exists which now returns true only when .target.stat returns non- empty map. Some of our testuites rely on default (nil) value of .target.stat and expect FileUtils::Exists to return true. So please check as well if this is not a case for your modules.
Modules that do not build (fail or are unresolvable) can be found here: http://bit.ly/GQNSaK Bye Lukas -- Lukas Ocilka, Appliances Department SUSE LINUX s.r.o., Praha -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On 03/26/2012 02:40 PM, Jiri Suchomel wrote:
Dne Po 26. března 2012 14:17:09, Arvin Schnell napsal(a): Not really related, but still: some packages currently do not build because of failing testsuites. This is (at least partly) because of Gabi's change in FileUtils::Exists which now returns true only when .target.stat returns non- empty map. Some of our testuites rely on default (nil) value of .target.stat and expect FileUtils::Exists to return true. So please check as well if this is not a case for your modules. I have reverted my change in FileUtils::Exists(). It's unnessary to check the return of SCR::Read(.target.stat, target) for != nil because it will never return nil but an empty map if the file doesn't exist (should have had a closer look before doing the change). I have submitted yast2-2.22.5 to Factory (request id 111523) and with it
Am 26.03.2012 14:45, schrieb Lukas Ocilka: the testsuites of affected modules should run again. Greetings Gabi
Modules that do not build (fail or are unresolvable) can be found here:
Bye Lukas
-- Gabriele Mohr SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstr. 5 Tel: +49 911 740 53 362 90409 Nürnberg Email: gs@suse.de ----------------------------------------------------------------- -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Dne St 28. března 2012 12:31:13, Gabriele Mohr napsal(a):
Am 26.03.2012 14:45, schrieb Lukas Ocilka:
On 03/26/2012 02:40 PM, Jiri Suchomel wrote:
Dne Po 26. března 2012 14:17:09, Arvin Schnell napsal(a): Not really related, but still: some packages currently do not build because of failing testsuites. This is (at least partly) because of Gabi's change in FileUtils::Exists which now returns true only when .target.stat returns non- empty map. Some of our testuites rely on default (nil) value of .target.stat and expect FileUtils::Exists to return true. So please check as well if this is not a case for your modules.
I have reverted my change in FileUtils::Exists(). It's unnessary to check the return of SCR::Read(.target.stat, target) for != nil because it will never return nil but an empty map if the file doesn't exist (should have had a closer look before doing the change). I have submitted yast2-2.22.5 to Factory (request id 111523) and with it the testsuites of affected modules should run again.
Greetings Gabi
Ouch! And I've already adapted my testsuites to your changes... j -- Jiri Suchomel SUSE LINUX, s.r.o. e-mail: jsuchome@suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Praha 9, Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On Wed, Mar 28, 2012 at 01:53:20PM +0200, Jiri Suchomel wrote:
Dne St 28. března 2012 12:31:13, Gabriele Mohr napsal(a):
Am 26.03.2012 14:45, schrieb Lukas Ocilka:
On 03/26/2012 02:40 PM, Jiri Suchomel wrote:
Dne Po 26. března 2012 14:17:09, Arvin Schnell napsal(a): Not really related, but still: some packages currently do not build because of failing testsuites. This is (at least partly) because of Gabi's change in FileUtils::Exists which now returns true only when .target.stat returns non- empty map. Some of our testuites rely on default (nil) value of .target.stat and expect FileUtils::Exists to return true. So please check as well if this is not a case for your modules.
I have reverted my change in FileUtils::Exists(). It's unnessary to check the return of SCR::Read(.target.stat, target) for != nil because it will never return nil but an empty map if the file doesn't exist (should have had a closer look before doing the change). I have submitted yast2-2.22.5 to Factory (request id 111523) and with it the testsuites of affected modules should run again.
Greetings Gabi
Ouch! And I've already adapted my testsuites to your changes...
If you instruct the testsuite SCR to return a useful map for .target.stat instead of nil your adaptions do not hurt and seem to be the right approach anymay. The problem with Fileutils::Exists was that its behaviour has changed when SCR::Read(.target.stat, ...) returns nil, which it never does for the real SCR. But it happens with the fake testsuite SCR unless the return value for .target.stat is specified. Regards, Arvin -- Arvin Schnell, <aschnell@suse.de> Senior Software Engineer, Research & Development SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstraße 5 90409 Nürnberg Germany -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
participants (4)
-
Arvin Schnell -
Gabriele Mohr -
Jiri Suchomel -
Lukas Ocilka