[yast-devel] Re: [yast-commit] r66467 - in /branches/SuSE-Code-11-SP2-Branch/product-creator: VERSION package/yast2-product-creator.changes src/Kiwi.ycp
Dne 17.10.2011 14:04, jsuchome@svn2.opensuse.org napsal(a):
+ ret_path = sformat ("%1/config%2.xml", + Directory::tmpdir, + mergestring (splitstring (xsl_file, "/ ."), "-"));
Um, why is there "/ ." -> "-" change? Looks strange, could you add a comment so it's clear why the change is needed? -- Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 lslezak@suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Dne St 19. října 2011 07:58:07 Ladislav Slezak napsal(a):
Dne 17.10.2011 14:04, jsuchome@svn2.opensuse.org napsal(a):
+ ret_path = sformat ("%1/config%2.xml", + Directory::tmpdir, + mergestring (splitstring (xsl_file, "/ ."), "-"));
Um, why is there "/ ." -> "-" change? Looks strange, could you add a comment so it's clear why the change is needed?
Because the resulting string is used for creating the file name. I think it should be visible frm the code. Jiri -- Jiri Suchomel SUSE LINUX, s.r.o. e-mail: jsuchome@suse.cz Lihovarská 1060/12 tel: +420 284 028 960 190 00 Praha 9, Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Dne 19.10.2011 10:41, Jiri Suchomel napsal(a):
Dne St 19. října 2011 07:58:07 Ladislav Slezak napsal(a):
Dne 17.10.2011 14:04, jsuchome@svn2.opensuse.org napsal(a):
+ ret_path = sformat ("%1/config%2.xml", + Directory::tmpdir, + mergestring (splitstring (xsl_file, "/ ."), "-"));
Um, why is there "/ ." -> "-" change? Looks strange, could you add a comment so it's clear why the change is needed?
Because the resulting string is used for creating the file name. I think it should be visible frm the code.
Yeah, you are right, I misunderstood that... -- Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 lslezak@suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
participants (2)
-
Jiri Suchomel -
Ladislav Slezak