[yast-devel] Rakefile in all yast modules
Hi, after few initial set of pull requests that add Rakefile and go thrue review, I see that it is very ineefective to create pull request to each module. So my plan is to do it massive for each module and add it globally to jenkins. Example pull request can be seen in [1], [2] or [3]. If you do not have any objections I will do it tomorrow during lunch. Josef [1] https://github.com/yast/yast-yast2/pull/114 [2] https://github.com/yast/yast-core/pull/53 [3] https://github.com/yast/yast-apparmor/pull/4 -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Dne 7.10.2013 17:15, Josef Reidinger napsal(a):
If you do not have any objections I will do it tomorrow during lunch.
I see configuration like this in the pull requests: Packaging.configuration do |conf| conf.skip_license_check << /testsuite/ #skip all testsuites conf.skip_license_check << /scr\/doc\/scr-arch.sda/ #skip binary file conf.skip_license_check << /.*/ #skip all temporary, as there is too much failures end Didn't we agree that using packaging tasks is an implementation detail? Shouldn't there be a wrapper? -- David Majda SUSE developer -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On Tue, 08 Oct 2013 08:53:20 +0200 David Majda <dmajda@suse.cz> wrote:
Dne 7.10.2013 17:15, Josef Reidinger napsal(a):
If you do not have any objections I will do it tomorrow during lunch.
I see configuration like this in the pull requests:
Packaging.configuration do |conf| conf.skip_license_check << /testsuite/ #skip all testsuites conf.skip_license_check << /scr\/doc\/scr-arch.sda/ #skip binary file conf.skip_license_check << /.*/ #skip all temporary, as there is too much failures end
Didn't we agree that using packaging tasks is an implementation detail? Shouldn't there be a wrapper?
Well, I can create a wrapper, but me it is more intuitive to use directly Packaging configuration or I can do something like module Yast Packaging = ::Packaging end if it suits better for you. And I plan to have strict backward compatibility in packaging tasks, so it should not be problem from changes perspective as I am author of packaging tasks. Josef -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Dne 8.10.2013 09:07, Josef Reidinger napsal(a):
Well, I can create a wrapper, but me it is more intuitive to use directly Packaging configuration
For me, as a first time/occasional user it is intuitive that require "yast/rake" is followed by Yast Rake task(s) configuration, not configuration of some "Packaging" module, which I never heard of. Whatever thechnical solution that allows that is fine with me. For example, with YARD, the configuration looks like this (example taken from the docs): require "yard" YARD::Rake::YardocTask.new do |t| t.files = ['lib/**/*.rb', OTHER_PATHS] # optional t.options = ['--any', '--extra', '--opts'] # optional end With RSpec, it looks like this (again, example taken from the docs): require 'rspec/core/rake_task' RSpec::Core::RakeTask.new(:spec) do |t| t.fail_on_error = false end Both configurations start with the name of the main module of given library. I would expect the same from YaST. (In both cases, the tasks are also created expliticly, not implicitly, but I am not sure how important that is.)
And I plan to have strict backward compatibility in packaging tasks, so it should not be problem from changes perspective as I am author of packaging tasks.
That's a non-issue for me. -- David Majda SUSE developer -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On Tue, 08 Oct 2013 09:34:37 +0200 David Majda <dmajda@suse.cz> wrote:
Dne 8.10.2013 09:07, Josef Reidinger napsal(a):
Well, I can create a wrapper, but me it is more intuitive to use directly Packaging configuration
For me, as a first time/occasional user it is intuitive that
require "yast/rake"
is followed by Yast Rake task(s) configuration, not configuration of some "Packaging" module, which I never heard of. Whatever thechnical solution that allows that is fine with me.
For example, with YARD, the configuration looks like this (example taken from the docs):
require "yard"
YARD::Rake::YardocTask.new do |t| t.files = ['lib/**/*.rb', OTHER_PATHS] # optional t.options = ['--any', '--extra', '--opts'] # optional end
With RSpec, it looks like this (again, example taken from the docs):
require 'rspec/core/rake_task'
RSpec::Core::RakeTask.new(:spec) do |t| t.fail_on_error = false end
Both configurations start with the name of the main module of given library. I would expect the same from YaST. (In both cases, the tasks are also created expliticly, not implicitly, but I am not sure how important that is.)
And I plan to have strict backward compatibility in packaging tasks, so it should not be problem from changes perspective as I am author of packaging tasks.
That's a non-issue for me.
We agreed in person that I add to yast/rake accessor to configuration in form Yast::Rake.configuration do |conf| ... end and modify all Rakefiles that lives now in yast package. So plan is not changed unless something speak up. Josef -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Hi, I finish today adding Rakefile to all reasonable modules and setting hudson to use it. You can see result at [1]. If you miss some modules, then you may find it in next email, where I write all modules that is not dropped ( in sense that doesn't have only one readme ) but is not in Yast:Head. There is still few failing ones, the most interesting reason is ruby coding issue that I plan to work on. Josef [1] http://ci.opensuse.org/view/Yast/ -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On 10/08/2013 05:24 PM, Josef Reidinger wrote:
Hi, I finish today adding Rakefile to all reasonable modules and setting hudson to use it. You can see result at [1].
Looks good :) Thanks a million! Lukas -- Lukas Ocilka, Cloud & Systems Management Department SUSE LINUX s.r.o., Praha -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On Tue, Oct 08, 2013 at 05:24:49PM +0200, Josef Reidinger wrote:
There is still few failing ones, the most interesting reason is ruby coding issue that I plan to work on.
Y U have issue with coding ruby? ... Ah! That is, a problem with character encoding, like: rake aborted! invalid byte sequence in US-ASCII Tasks: TOP => osc:commit => osc:build => package => check:syntax in http://ci.opensuse.org/view/Yast/job/yast-users-master/3/console Anyway, thanks! -- Martin Vidner, Cloud & Systems Management Team http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu
On Tue, 8 Oct 2013 17:24:49 +0200 Josef Reidinger <jreidinger@suse.cz> wrote:
Hi, I finish today adding Rakefile to all reasonable modules and setting hudson to use it. You can see result at [1]. If you miss some modules, then you may find it in next email, where I write all modules that is not dropped ( in sense that doesn't have only one readme ) but is not in Yast:Head. There is still few failing ones, the most interesting reason is ruby coding issue that I plan to work on.
Josef
Hi, after today fixing there is only few failing modules. Remaining problem is cmake based modules (currently only one[1]), rspec related failures ( email about possible solutions already sent ) and yast2 problem with binaries in sbin instead of sbin where pr is pending [2]. Josef [1] http://ci.opensuse.org/view/Yast/job/yast-control-center-master/lastFailedBu... [2] https://github.com/yast/yast-yast2/pull/115 -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
participants (4)
-
David Majda -
Josef Reidinger -
Lukas Ocilka -
Martin Vidner