V Thu, 4 Jul 2019 11:51:35 +1000 William Brown <wbrown@suse.de> napsáno:

Hey there,

I'd appreciate a review and advice on the following PR for yast-auth-server:

https://github.com/yast/yast-auth-server/pull/52

Thanks!

— Sincerely,

William Brown

Senior Software Engineer, 389 Directory Server SUSE Labs

Hi William, I reviewed pr and approved. Written also some hints how to improve a bit code. But my general suggestion is to enable rubocop in auth-server as style there is very inconsistent with rest of yast and also coding style inside module itself looks inconsistent for me. If you need any help with rubocop just contact me. And to answer question in pr. Yes, master will be in SLE15 SP2 and openSUSE 15.2. Josef -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org