[yast-devel] YaST in GIT and keyword expansion
Hi all, in SVN we used keyword expansion for expanding tags like $Id$ in file headers. The problem is that GIT does not support keyword expansion and it is not recommended anyway. The only way is to use custom scripts. See https://git.wiki.kernel.org/index.php/GitFaq#Does_git_have_keyword_expansion... I think we should just remove the obsoleted keywords, but what do you think about it? Should we create a custom script or remove the keywords? -- Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 lslezak@suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On 07/12/2012 10:10 AM, Ladislav Slezak wrote:
Hi all,
in SVN we used keyword expansion for expanding tags like $Id$ in file headers. The problem is that GIT does not support keyword expansion and it is not recommended anyway. The only way is to use custom scripts.
See https://git.wiki.kernel.org/index.php/GitFaq#Does_git_have_keyword_expansion...
I think we should just remove the obsoleted keywords, but what do you think about it? Should we create a custom script or remove the keywords?
Just an idea but would't using <https://github.com/kimmormh/git-rcs-keywords> help to keep the keywords Togan -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Dne 12.7.2012 10:38, Togan Muftuoglu napsal(a):
Just an idea but would't using <https://github.com/kimmormh/git-rcs-keywords> help to keep the keywords
Oh, thanks for the link, looks interesting. But the description contains this: "The mechanism used are filters. The smudge filter is run on checkout, and the clean filter is run on commit. The tags are only expanded on the local disk, not in the repository itself." We would have to globally agree on using it or not. I mean this could cause unnecessary changes when submitting created tarballs to OBS. Imagine developer A, who doesn't use keyword expansion, submits a package to OBS, developer B uses keyword expansion and submits a bugfix to OBS. The result is that the diff A->B contains expansions and might be much longer than necessary. This might be problematic when doing review for a maintenance release (online update) in OBS. For this reason I'd rather not use keywords at all, they can create a mess very easily and the advantage is negligible (if any). Any (other) opinions? -- Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 lslezak@suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On Thu, 12 Jul 2012 11:38:36 +0200 Ladislav Slezak <lslezak@suse.cz> wrote:
Dne 12.7.2012 10:38, Togan Muftuoglu napsal(a):
Just an idea but would't using <https://github.com/kimmormh/git-rcs-keywords> help to keep the keywords
Oh, thanks for the link, looks interesting.
But the description contains this:
"The mechanism used are filters. The smudge filter is run on checkout, and the clean filter is run on commit. The tags are only expanded on the local disk, not in the repository itself."
We would have to globally agree on using it or not. I mean this could cause unnecessary changes when submitting created tarballs to OBS.
Imagine developer A, who doesn't use keyword expansion, submits a package to OBS, developer B uses keyword expansion and submits a bugfix to OBS. The result is that the diff A->B contains expansions and might be much longer than necessary.
This might be problematic when doing review for a maintenance release (online update) in OBS.
For this reason I'd rather not use keywords at all, they can create a mess very easily and the advantage is negligible (if any).
Any (other) opinions?
I agree with riding of keywords. I found it annoying even in svn. If we use tags, I see no reason to use keywords in files. Josef
--
Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 lslezak@suse.com SUSE
-- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On 07/12/2012 01:21 PM, Josef Reidinger wrote:
For this reason I'd rather not use keywords at all, they can create a mess very easily and the advantage is negligible (if any).
Any (other) opinions?
I agree with riding of keywords. I found it annoying even in svn. If we use tags, I see no reason to use keywords in files.
Maybe someone who actually uses the keywords could tell us how useful they are for them. If we don't find anyone using the keywords or their usage is not needed that much, we can drop them easily. Lukas -- Lukas Ocilka, Appliances Department SUSE LINUX s.r.o., Praha -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
participants (4)
-
Josef Reidinger -
Ladislav Slezak -
Lukas Ocilka -
Togan Muftuoglu