[yast-devel] Pending Pull Requests
This email is automatic generated from yast CI node. It lists of pull requests that have no activity more then three working days. If your module is listed, please check all pull request, why they are not merged yet. Pending requests in repository yast-autoinstallation: - Fix install rules SLE 12 GA (27 days) https://github.com/yast/yast-autoinstallation/pull/190 - [Review] Request from 'schubi2' @ 'yast/yast-autoinstallation/review_160113_bug_955878_merged_with_sp1' (41 days) https://github.com/yast/yast-autoinstallation/pull/179 Pending requests in repository yast-bootloader: - [do not merge] partial usage of config files gem (20 days) https://github.com/yast/yast-bootloader/pull/280 Pending requests in repository yast-country: - Some changes in the tumbleweed mappings (bsc#942899 and bsc#942896) (29 days) https://github.com/yast/yast-country/pull/61 - Ensure ntp is installed (when Install Recommended Packages is off) (141 days) https://github.com/yast/yast-country/pull/55 Pending requests in repository yast-dhcp-server: - Fix "One or more selected network interfaces is not configured" (29 days) https://github.com/yast/yast-dhcp-server/pull/11 Pending requests in repository yast-installation: - Poc recover values (121 days) https://github.com/yast/yast-installation/pull/319 Pending requests in repository yast-live-installer: - Fix Symlink resolution (29 days) https://github.com/yast/yast-live-installer/pull/6 Pending requests in repository yast-snapper: - [DO NOT MERGE] Added snapshot Class with strategy pattern. (82 days) https://github.com/yast/yast-snapper/pull/40 - Cleanup and delete multiple snapshots at once (#bsc#956143). (84 days) https://github.com/yast/yast-snapper/pull/39 Pending requests in repository yast-storage: - Add option to disable swap creation (28 days) https://github.com/yast/yast-storage/pull/182 - Ported support for LVM proposal setting from SP1 to Master (5 days) https://github.com/yast/yast-storage/pull/177 - Propose /boot for encrypted root on PowerPC (64 days) https://github.com/yast/yast-storage/pull/155 Pending requests in repository yast-yast2: - Cleanup NetworkInterfaces.Read (20 days) https://github.com/yast/yast-yast2/pull/433 - Count test coverage more accurately (30 days) https://github.com/yast/yast-yast2/pull/426 Pending requests in repository yast-auth-server: - Drop ca mgm (35 days) https://github.com/yast/yast-auth-server/pull/21 Pending requests in repository yast.github.io: - Add some documentation about submit requests (89 days) https://github.com/yast/yast.github.io/pull/55 Pending requests in repository aytests-tests: - [do not merge] Installation rules (12 days) https://github.com/yast/aytests-tests/pull/12 -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Dne 25.2.2016 v 03:59 yast-ci@opensuse.org napsal(a):
Pending requests in repository yast-bootloader: - [do not merge] partial usage of config files gem (20 days) ^^^^^^^^^^^^ [...] Pending requests in repository yast-snapper: - [DO NOT MERGE] Added snapshot Class with strategy pattern. (82 days) ^^^^^^^^^^^^ [...] Pending requests in repository aytests-tests: - [do not merge] Installation rules (12 days) ^^^^^^^^^^^^
Um, maybe we should improve the pull request checker to ignore the pull requests which contain "do not merge" or "WIP" texts, usually these requests are proof of concepts or unfinished work. I personally skip these requests automatically and do not check them at all. On the other hand it makes sense to check such requests from time to time to avoid rotting branches and requests... What do you think about it? -- Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 lslezak@suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On Thu, 25 Feb 2016 17:13:30 +0100 Ladislav Slezak <lslezak@suse.cz> wrote:
Dne 25.2.2016 v 03:59 yast-ci@opensuse.org napsal(a):
Pending requests in repository yast-bootloader: - [do not merge] partial usage of config files gem (20 days) ^^^^^^^^^^^^ [...] Pending requests in repository yast-snapper: - [DO NOT MERGE] Added snapshot Class with strategy pattern. (82 days) ^^^^^^^^^^^^ [...] Pending requests in repository aytests-tests: - [do not merge] Installation rules (12 days) ^^^^^^^^^^^^
Um, maybe we should improve the pull request checker to ignore the pull requests which contain "do not merge" or "WIP" texts, usually these requests are proof of concepts or unfinished work.
I personally skip these requests automatically and do not check them at all.
On the other hand it makes sense to check such requests from time to time to avoid rotting branches and requests...
What do you think about it?
I am also considering it now as I usual round of pinging. And to be honest I think it make sense to also check such do not merge pull request otherwise it get lost quickly. Inactivi means also that noone do any commit to such branch for given time, so it is no merge and no update, which is wrong for me. For bootloader it indicate that I have vacation. For snapper I discuss it with Knut and for autoyast I try to get situation. So we can add more logic like more relaxed time for inactivity if such flag is there, but it make script more complex, so maybe it will be better to just keep it as it is. But this mails is for everyone, so if others agreed to change it, I can do it. Josef -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Dne 25.2.2016 v 17:32 Josef Reidinger napsal(a):
So we can add more logic like more relaxed time for inactivity if such flag is there, but it make script more complex, so maybe it will be better to just keep it as it is. But this mails is for everyone, so if others agreed to change it, I can do it.
We could check such PRs let's say only once a week (e.g. every Monday) to decrease the "spamming" a bit. But if that would make the script too complex I'm fine with the current state, so far there are just few "do not merge" requests in the report... -- Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 lslezak@suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
participants (3)
-
Josef Reidinger -
Ladislav Slezak -
yast-ci＠opensuse.org