[yast-devel] Re: [yast-commit] r66101 - /trunk/sound/sound/src/Joystick.ycp
On Tuesday 27 of September 2011 16:44:37 lslezak@svn2.opensuse.org wrote:
Author: lslezak Date: Tue Sep 27 16:44:36 2011 New Revision: 66101
URL: http://svn.opensuse.org/viewcvs/yast?rev=66101&view=rev Log: - use Service::Start()/Stop() instead of hardcoded scripts (systemd support)
Modified: trunk/sound/sound/src/Joystick.ycp
Modified: trunk/sound/sound/src/Joystick.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/sound/sound/src/Joystick.ycp?re v=66101&r1=66100&r2=66101&view=diff ========================================================================== ==== --- trunk/sound/sound/src/Joystick.ycp (original) +++ trunk/sound/sound/src/Joystick.ycp Tue Sep 27 16:44:36 2011 @@ -251,8 +251,7 @@ * Stop joystick service */ global define boolean Stop() ``{
Would be nice to also remove 'define' and backticks, when you actually touch the code. Stano
- return - (SCR::Execute(.target.bash, "/etc/init.d/joystick stop", $[]) == 0); + return Service::Stop("joystick"); }
/** @@ -268,7 +267,8 @@ global define boolean StartAndEnable() ``{
if (start == "enable") - SCR::Execute(.target.bash, "/etc/init.d/joystick start", $[]); + Service::Start("joystick"); + Service::Adjust("joystick", start); return true; } -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
On Tue, Sep 27, 2011 at 07:20:24PM +0200, Stanislav Višňovský wrote:
On Tuesday 27 of September 2011 16:44:37 lslezak@svn2.opensuse.org wrote:
global define boolean Stop() ``{
Would be nice to also remove 'define' and backticks, when you actually touch the code.
Right. I found lots in my code, so I wrote this script to convert it. Enjoy: https://gist.github.com/1263970 -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu
* Martin Vidner <mvidner@suse.cz> [Oct 05. 2011 10:59]:
On Tue, Sep 27, 2011 at 07:20:24PM +0200, Stanislav Višňovský wrote:
On Tuesday 27 of September 2011 16:44:37 lslezak@svn2.opensuse.org wrote:
global define boolean Stop() ``{
Would be nice to also remove 'define' and backticks, when you actually touch the code.
Right. I found lots in my code, so I wrote this script to convert it. Enjoy: https://gist.github.com/1263970
Should we register goodbye-backticks.de, just like goodbye-dots.de ? ;-) Klaus --- SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstraße 5, 90409 Nürnberg, Germany -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org
participants (3)
-
Klaus Kaempf -
Martin Vidner -
Stanislav Visnovsky